[INFO] updating cached repository coder543/impulse [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/coder543/impulse [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/coder543/impulse" "work/ex/clippy-test-run/sources/stable/gh/coder543/impulse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/coder543/impulse'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/coder543/impulse" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coder543/impulse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coder543/impulse'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a6c811fc3a700b4530dcfbfe676a32ac1b4aab0a [INFO] sha for GitHub repo coder543/impulse: a6c811fc3a700b4530dcfbfe676a32ac1b4aab0a [INFO] validating manifest of coder543/impulse on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coder543/impulse on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coder543/impulse [INFO] finished frobbing coder543/impulse [INFO] frobbed toml for coder543/impulse written to work/ex/clippy-test-run/sources/stable/gh/coder543/impulse/Cargo.toml [INFO] started frobbing coder543/impulse [INFO] finished frobbing coder543/impulse [INFO] frobbed toml for coder543/impulse written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coder543/impulse/Cargo.toml [INFO] crate coder543/impulse has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coder543/impulse against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/coder543/impulse:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e72c9a3815e846d3778a7a03b1b2d0c2e2cbc7f2cb420cc15c98c1407ab1fcb6 [INFO] running `"docker" "start" "-a" "e72c9a3815e846d3778a7a03b1b2d0c2e2cbc7f2cb420cc15c98c1407ab1fcb6"` [INFO] [stderr] Checking ws v0.7.3 [INFO] [stderr] Checking env_logger v0.5.4 [INFO] [stderr] Checking impulse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | sockets.get(user).map(|socket| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 40 | || let _ = socket.send(message.clone()); [INFO] [stderr] 41 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(socket) = sockets.get(user) { let _ = socket.send(message.clone()); }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | .or_insert_with(|| HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | .or_insert_with(|| HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | sockets.get(user).map(|socket| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 40 | || let _ = socket.send(message.clone()); [INFO] [stderr] 41 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(socket) = sockets.get(user) { let _ = socket.send(message.clone()); }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | .or_insert_with(|| HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | .or_insert_with(|| HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.82s [INFO] running `"docker" "inspect" "e72c9a3815e846d3778a7a03b1b2d0c2e2cbc7f2cb420cc15c98c1407ab1fcb6"` [INFO] running `"docker" "rm" "-f" "e72c9a3815e846d3778a7a03b1b2d0c2e2cbc7f2cb420cc15c98c1407ab1fcb6"` [INFO] [stdout] e72c9a3815e846d3778a7a03b1b2d0c2e2cbc7f2cb420cc15c98c1407ab1fcb6