[INFO] updating cached repository coder543/cryptoticker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/coder543/cryptoticker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/coder543/cryptoticker" "work/ex/clippy-test-run/sources/stable/gh/coder543/cryptoticker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/coder543/cryptoticker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/coder543/cryptoticker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coder543/cryptoticker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coder543/cryptoticker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aee15f359b0deeb0313d21656d5a450a4c906bb3 [INFO] sha for GitHub repo coder543/cryptoticker: aee15f359b0deeb0313d21656d5a450a4c906bb3 [INFO] validating manifest of coder543/cryptoticker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coder543/cryptoticker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coder543/cryptoticker [INFO] finished frobbing coder543/cryptoticker [INFO] frobbed toml for coder543/cryptoticker written to work/ex/clippy-test-run/sources/stable/gh/coder543/cryptoticker/Cargo.toml [INFO] started frobbing coder543/cryptoticker [INFO] finished frobbing coder543/cryptoticker [INFO] frobbed toml for coder543/cryptoticker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coder543/cryptoticker/Cargo.toml [INFO] crate coder543/cryptoticker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coder543/cryptoticker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/coder543/cryptoticker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2243450167401c2a6df58b9ccf1d7041544e5297d40a4c5423e2443ca27cb3e [INFO] running `"docker" "start" "-a" "f2243450167401c2a6df58b9ccf1d7041544e5297d40a4c5423e2443ca27cb3e"` [INFO] [stderr] Checking foreign-types-shared v0.1.0 [INFO] [stderr] Checking build_const v0.2.0 [INFO] [stderr] Compiling crc v1.6.0 [INFO] [stderr] Checking app_dirs v1.1.1 [INFO] [stderr] Checking openssl-sys v0.9.21 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking foreign-types v0.2.1 [INFO] [stderr] Checking openssl v0.9.21 [INFO] [stderr] Checking libflate v0.1.12 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking cryptoticker v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ticker.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ticker.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/ticker.rs:41:15 [INFO] [stderr] | [INFO] [stderr] 41 | let url = "https://api.coinmarketcap.com/v1/ticker/".to_string() + &name; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ticker.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | let price = ticker.price_usd.unwrap_or("null".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "null".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | .unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/ticker.rs:41:15 [INFO] [stderr] | [INFO] [stderr] 41 | let url = "https://api.coinmarketcap.com/v1/ticker/".to_string() + &name; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ticker.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | let price = ticker.price_usd.unwrap_or("null".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "null".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | .unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.28s [INFO] running `"docker" "inspect" "f2243450167401c2a6df58b9ccf1d7041544e5297d40a4c5423e2443ca27cb3e"` [INFO] running `"docker" "rm" "-f" "f2243450167401c2a6df58b9ccf1d7041544e5297d40a4c5423e2443ca27cb3e"` [INFO] [stdout] f2243450167401c2a6df58b9ccf1d7041544e5297d40a4c5423e2443ca27cb3e