[INFO] updating cached repository cobalt-org/cobalt.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cobalt-org/cobalt.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cobalt-org/cobalt.rs" "work/ex/clippy-test-run/sources/stable/gh/cobalt-org/cobalt.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cobalt-org/cobalt.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cobalt-org/cobalt.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cobalt-org/cobalt.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cobalt-org/cobalt.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 28a55d2cc6ff7c3999f7d4f2f99bdb30220f3668 [INFO] sha for GitHub repo cobalt-org/cobalt.rs: 28a55d2cc6ff7c3999f7d4f2f99bdb30220f3668 [INFO] validating manifest of cobalt-org/cobalt.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cobalt-org/cobalt.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cobalt-org/cobalt.rs [INFO] finished frobbing cobalt-org/cobalt.rs [INFO] frobbed toml for cobalt-org/cobalt.rs written to work/ex/clippy-test-run/sources/stable/gh/cobalt-org/cobalt.rs/Cargo.toml [INFO] started frobbing cobalt-org/cobalt.rs [INFO] finished frobbing cobalt-org/cobalt.rs [INFO] frobbed toml for cobalt-org/cobalt.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cobalt-org/cobalt.rs/Cargo.toml [INFO] crate cobalt-org/cobalt.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cobalt-org/cobalt.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cobalt-org/cobalt.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 96ef91b2ad4c2e788c63b5b73b358d50618765224f54dd5f9fd9b2a7a4237e33 [INFO] running `"docker" "start" "-a" "96ef91b2ad4c2e788c63b5b73b358d50618765224f54dd5f9fd9b2a7a4237e33"` [INFO] [stderr] Checking liquid-error v0.16.1 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking pulldown-cmark v0.1.2 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking sass-sys v0.4.7 [INFO] [stderr] Checking hyper v0.10.15 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking flate2 v1.0.4 [INFO] [stderr] Checking ghp v0.1.2 [INFO] [stderr] Checking serde v1.0.80 [INFO] [stderr] Checking sass-rs v0.2.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking quick-xml v0.13.1 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking rss v1.6.1 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking env_logger v0.6.0 [INFO] [stderr] Checking predicates v1.0.0 [INFO] [stderr] Checking notify v4.0.6 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking globwalk v0.5.0 [INFO] [stderr] Checking assert_fs v0.10.0 [INFO] [stderr] Checking liquid-value v0.17.1 [INFO] [stderr] Checking plist v0.3.0 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking toml v0.4.9 [INFO] [stderr] Checking serde_yaml v0.8.7 [INFO] [stderr] Checking liquid-interpreter v0.17.1 [INFO] [stderr] Checking liquid-compiler v0.17.1 [INFO] [stderr] Checking syntect v3.0.2 [INFO] [stderr] Checking jsonfeed v0.2.0 [INFO] [stderr] Checking escargot v0.3.1 [INFO] [stderr] Checking assert_cmd v0.10.2 [INFO] [stderr] Checking liquid v0.17.1 [INFO] [stderr] Checking cobalt-bin v0.14.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cobalt_model/frontmatter.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cobalt_model/frontmatter.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pagination.rs:65:37 [INFO] [stderr] | [INFO] [stderr] 65 | self.pages = Some(all_pages.into_iter().map(|p| (*p).clone()).collect()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `60` [INFO] [stderr] --> src/cobalt_model/datetime.rs:237:41 [INFO] [stderr] | [INFO] [stderr] 237 | .and_then(|d| d.with_offset(1 * 60 * 60)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `60` [INFO] [stderr] --> src/cobalt_model/datetime.rs:249:41 [INFO] [stderr] | [INFO] [stderr] 249 | .and_then(|d| d.with_offset(1 * 60 * 60)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `60` [INFO] [stderr] --> src/cobalt_model/datetime.rs:261:41 [INFO] [stderr] | [INFO] [stderr] 261 | .and_then(|d| d.with_offset(1 * 60 * 60)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pagination.rs:65:37 [INFO] [stderr] | [INFO] [stderr] 65 | self.pages = Some(all_pages.into_iter().map(|p| (*p).clone()).collect()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/mod.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | File::open(&src_file).expect(&format!( [INFO] [stderr] | _______________________________^ [INFO] [stderr] 65 | | "File {:?} does not exist in reference ({:?}).", [INFO] [stderr] 66 | | entry.path(), [INFO] [stderr] 67 | | src_file [INFO] [stderr] 68 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("File {:?} does not exist in reference ({:?}).", entry.path()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `"docker" "inspect" "96ef91b2ad4c2e788c63b5b73b358d50618765224f54dd5f9fd9b2a7a4237e33"` [INFO] running `"docker" "rm" "-f" "96ef91b2ad4c2e788c63b5b73b358d50618765224f54dd5f9fd9b2a7a4237e33"` [INFO] [stdout] 96ef91b2ad4c2e788c63b5b73b358d50618765224f54dd5f9fd9b2a7a4237e33