[INFO] updating cached repository cmusser/periodic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cmusser/periodic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cmusser/periodic" "work/ex/clippy-test-run/sources/stable/gh/cmusser/periodic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cmusser/periodic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cmusser/periodic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmusser/periodic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmusser/periodic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 54a0663d4b9db31e3fd571e8bf24c5a7a90aa8f8 [INFO] sha for GitHub repo cmusser/periodic: 54a0663d4b9db31e3fd571e8bf24c5a7a90aa8f8 [INFO] validating manifest of cmusser/periodic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cmusser/periodic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cmusser/periodic [INFO] finished frobbing cmusser/periodic [INFO] frobbed toml for cmusser/periodic written to work/ex/clippy-test-run/sources/stable/gh/cmusser/periodic/Cargo.toml [INFO] started frobbing cmusser/periodic [INFO] finished frobbing cmusser/periodic [INFO] frobbed toml for cmusser/periodic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmusser/periodic/Cargo.toml [INFO] crate cmusser/periodic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cmusser/periodic against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cmusser/periodic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9753e98d74931c32727cef5fb19eda5e7ddc2c4ddf8cc6e13334f36756d68ba3 [INFO] running `"docker" "start" "-a" "9753e98d74931c32727cef5fb19eda5e7ddc2c4ddf8cc6e13334f36756d68ba3"` [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking mio-uds v0.6.4 [INFO] [stderr] Checking tokio-signal v0.1.4 [INFO] [stderr] Checking tokio-process v0.1.5 [INFO] [stderr] Checking periodic v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | const VERSION: &'static str = "0.1.2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | const DEFAULT_CONTROL_FILE: &'static str = "./control.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | const DEFAULT_INTERVAL_SECS: &'static str = "5"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:36:32 [INFO] [stderr] | [INFO] [stderr] 36 | const DEFAULT_MAX_CONCURRENT: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | const DEFAULT_NAME:&'static str = "periodic task"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/periodic.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | return Err(std::io::Error::new(ErrorKind::Interrupted, "done")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(std::io::Error::new(ErrorKind::Interrupted, "done"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | const VERSION: &'static str = "0.1.2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | const DEFAULT_CONTROL_FILE: &'static str = "./control.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | const DEFAULT_INTERVAL_SECS: &'static str = "5"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:36:32 [INFO] [stderr] | [INFO] [stderr] 36 | const DEFAULT_MAX_CONCURRENT: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/periodic.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | const DEFAULT_NAME:&'static str = "periodic task"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/periodic.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | return Err(std::io::Error::new(ErrorKind::Interrupted, "done")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(std::io::Error::new(ErrorKind::Interrupted, "done"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/periodic.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | for ref mut task in tasks_mut.values_mut() { [INFO] [stderr] | ^^^^^^^^^^^^ ---------------------- help: try: `let task = &mut tasks_mut.values_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/periodic.rs:96:33 [INFO] [stderr] | [INFO] [stderr] 96 | task.mode = (*task_mode).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*task_mode)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/periodic.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | for &ref task in tasks_mut.values() { [INFO] [stderr] | ^^^^^^^^^ help: try removing the `&ref` part and just keep: `task` [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/periodic.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | for ref mut task in tasks_mut.values_mut() { [INFO] [stderr] | ^^^^^^^^^^^^ ---------------------- help: try: `let task = &mut tasks_mut.values_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/periodic.rs:96:33 [INFO] [stderr] | [INFO] [stderr] 96 | task.mode = (*task_mode).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*task_mode)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/periodic.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | for &ref task in tasks_mut.values() { [INFO] [stderr] | ^^^^^^^^^ help: try removing the `&ref` part and just keep: `task` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/periodic.rs:210:63 [INFO] [stderr] | [INFO] [stderr] 210 | match Command::new(&cmd_array[0]).args(cmd_array[1..].into_iter()).spawn_async(&handle) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/periodic.rs:210:63 [INFO] [stderr] | [INFO] [stderr] 210 | match Command::new(&cmd_array[0]).args(cmd_array[1..].into_iter()).spawn_async(&handle) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.74s [INFO] running `"docker" "inspect" "9753e98d74931c32727cef5fb19eda5e7ddc2c4ddf8cc6e13334f36756d68ba3"` [INFO] running `"docker" "rm" "-f" "9753e98d74931c32727cef5fb19eda5e7ddc2c4ddf8cc6e13334f36756d68ba3"` [INFO] [stdout] 9753e98d74931c32727cef5fb19eda5e7ddc2c4ddf8cc6e13334f36756d68ba3