[INFO] updating cached repository cmr/cbfi-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cmr/cbfi-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cmr/cbfi-rs" "work/ex/clippy-test-run/sources/stable/gh/cmr/cbfi-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cmr/cbfi-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cmr/cbfi-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmr/cbfi-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmr/cbfi-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c9f4d4267b853de857931b2fb2c181e47a2e136 [INFO] sha for GitHub repo cmr/cbfi-rs: 8c9f4d4267b853de857931b2fb2c181e47a2e136 [INFO] validating manifest of cmr/cbfi-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cmr/cbfi-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cmr/cbfi-rs [INFO] finished frobbing cmr/cbfi-rs [INFO] frobbed toml for cmr/cbfi-rs written to work/ex/clippy-test-run/sources/stable/gh/cmr/cbfi-rs/Cargo.toml [INFO] started frobbing cmr/cbfi-rs [INFO] finished frobbing cmr/cbfi-rs [INFO] frobbed toml for cmr/cbfi-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmr/cbfi-rs/Cargo.toml [INFO] crate cmr/cbfi-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cmr/cbfi-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cmr/cbfi-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51f00a04d9147aff9e585c5ddc12e87c710ee6d24d699fe042f0d37d14a98e97 [INFO] running `"docker" "start" "-a" "51f00a04d9147aff9e585c5ddc12e87c710ee6d24d699fe042f0d37d14a98e97"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/cbfi.rs` was erroneously implicitly accepted for binary `cbfi`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking cbfi v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cbfi.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | prog.push(Insn { op: op, count: 0 }); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cbfi.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | prog.push(Insn { op: op, count: count }); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cbfi.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | prog.push(Insn { op: op, count: count }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cbfi.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | prog.push(Insn { op: op, count: 0 }); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cbfi.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | prog.push(Insn { op: op, count: count }); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cbfi.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | prog.push(Insn { op: op, count: count }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cbfi.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match op { [INFO] [stderr] 75 | | FJump => { [INFO] [stderr] 76 | | let mut num_braces = 1i32; [INFO] [stderr] 77 | | for j in i + 1 .. prog.len() { [INFO] [stderr] ... | [INFO] [stderr] 93 | | _ => { } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let FJump = op { [INFO] [stderr] 75 | let mut num_braces = 1i32; [INFO] [stderr] 76 | for j in i + 1 .. prog.len() { [INFO] [stderr] 77 | let op2 = prog[j].op; [INFO] [stderr] 78 | [INFO] [stderr] 79 | match op2 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cbfi.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | stdout.write(&state[pointer .. pointer + insn.count as usize]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cbfi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cbfi.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match op { [INFO] [stderr] 75 | | FJump => { [INFO] [stderr] 76 | | let mut num_braces = 1i32; [INFO] [stderr] 77 | | for j in i + 1 .. prog.len() { [INFO] [stderr] ... | [INFO] [stderr] 93 | | _ => { } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let FJump = op { [INFO] [stderr] 75 | let mut num_braces = 1i32; [INFO] [stderr] 76 | for j in i + 1 .. prog.len() { [INFO] [stderr] 77 | let op2 = prog[j].op; [INFO] [stderr] 78 | [INFO] [stderr] 79 | match op2 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/cbfi.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | stdout.write(&state[pointer .. pointer + insn.count as usize]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cbfi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "51f00a04d9147aff9e585c5ddc12e87c710ee6d24d699fe042f0d37d14a98e97"` [INFO] running `"docker" "rm" "-f" "51f00a04d9147aff9e585c5ddc12e87c710ee6d24d699fe042f0d37d14a98e97"` [INFO] [stdout] 51f00a04d9147aff9e585c5ddc12e87c710ee6d24d699fe042f0d37d14a98e97