[INFO] updating cached repository cmatsuoka/rustlet
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cmatsuoka/rustlet
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cmatsuoka/rustlet" "work/ex/clippy-test-run/sources/stable/gh/cmatsuoka/rustlet"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cmatsuoka/rustlet'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cmatsuoka/rustlet" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmatsuoka/rustlet"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmatsuoka/rustlet'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1c7b3f05873faa58119f53f99fb3716efbe79ccc
[INFO] sha for GitHub repo cmatsuoka/rustlet: 1c7b3f05873faa58119f53f99fb3716efbe79ccc
[INFO] validating manifest of cmatsuoka/rustlet on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cmatsuoka/rustlet on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cmatsuoka/rustlet
[INFO] finished frobbing cmatsuoka/rustlet
[INFO] frobbed toml for cmatsuoka/rustlet written to work/ex/clippy-test-run/sources/stable/gh/cmatsuoka/rustlet/Cargo.toml
[INFO] started frobbing cmatsuoka/rustlet
[INFO] finished frobbing cmatsuoka/rustlet
[INFO] frobbed toml for cmatsuoka/rustlet written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmatsuoka/rustlet/Cargo.toml
[INFO] crate cmatsuoka/rustlet has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cmatsuoka/rustlet against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cmatsuoka/rustlet:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e5404f492516d72b3ec0ef68d11e3d2f17290d9d7053d33adc6262d81c9e772e
[INFO] running `"docker" "start" "-a" "e5404f492516d72b3ec0ef68d11e3d2f17290d9d7053d33adc6262d81c9e772e"`
[INFO] [stderr]     Checking rustlet v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/smusher/charsmush.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 | /     if mode & figfont::SMUSH_EQUAL != 0 {
[INFO] [stderr] 107 | |         if l == r {
[INFO] [stderr] 108 | |             return Some(l)
[INFO] [stderr] 109 | |         }
[INFO] [stderr] 110 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 106 |     if mode & figfont::SMUSH_EQUAL != 0 && l == r {
[INFO] [stderr] 107 |     return Some(l)
[INFO] [stderr] 108 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/smusher/charsmush.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 | /     if mode & figfont::SMUSH_EQUAL != 0 {
[INFO] [stderr] 107 | |         if l == r {
[INFO] [stderr] 108 | |             return Some(l)
[INFO] [stderr] 109 | |         }
[INFO] [stderr] 110 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 106 |     if mode & figfont::SMUSH_EQUAL != 0 && l == r {
[INFO] [stderr] 107 |     return Some(l)
[INFO] [stderr] 108 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/figfont.rs:108:38
[INFO] [stderr]     |
[INFO] [stderr] 108 |     fn parse_header(&mut self, line: &String) -> Result<&Self, Error> {
[INFO] [stderr]     |                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/figfont.rs:148:22
[INFO] [stderr]     |
[INFO] [stderr] 148 |     if s.starts_with("-") {
[INFO] [stderr]     |                      ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/figfont.rs:188:30
[INFO] [stderr]     |
[INFO] [stderr] 188 |     pub fn from_lines(lines: &Vec<&str>) -> Result<Self, Error> {
[INFO] [stderr]     |                              ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/figfont.rs:239:16
[INFO] [stderr]     |
[INFO] [stderr] 239 |             if line.len() < 1 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_1(l, r, mode) { apply_rule!(rule_1(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 92 |       apply_rule!(rule_1(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_2(l, r, mode) { apply_rule!(rule_2(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 93 |       apply_rule!(rule_2(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_3(l, r, mode) { apply_rule!(rule_3(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 94 |       apply_rule!(rule_3(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_4(l, r, mode) { apply_rule!(rule_4(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 95 |       apply_rule!(rule_4(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_5(l, r, mode) { apply_rule!(rule_5(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 96 |       apply_rule!(rule_5(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/smusher/mod.rs:100:19
[INFO] [stderr]     |
[INFO] [stderr] 100 | fn amount(output: &Vec<String>, c: &FIGchar, hardblank: char, mode: u32) -> usize {
[INFO] [stderr]     |                   ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/smusher/mod.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 | fn trim(output: &Vec<String>, width: usize) -> Vec<String> {
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/smusher/mod.rs:116:18
[INFO] [stderr]     |
[INFO] [stderr] 116 | fn smush(output: &Vec<String>, c: &FIGchar, hardblank: char, full_width: bool, mode: u32) -> Vec<String> {
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/smusher/mod.rs:118:15
[INFO] [stderr]     |
[INFO] [stderr] 118 |       let amt = match full_width {
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 119 | |         true  => 0,
[INFO] [stderr] 120 | |         false => amount(&output, c, hardblank, mode),
[INFO] [stderr] 121 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if full_width { 0 } else { amount(&output, c, hardblank, mode) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> tests/integration_test.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 | fn dummy(_: &Vec<String>) {
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> examples/simple.rs:31:20
[INFO] [stderr]    |
[INFO] [stderr] 31 | fn print_output(v: &Vec<String>) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/figfont.rs:108:38
[INFO] [stderr]     |
[INFO] [stderr] 108 |     fn parse_header(&mut self, line: &String) -> Result<&Self, Error> {
[INFO] [stderr]     |                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/figfont.rs:148:22
[INFO] [stderr]     |
[INFO] [stderr] 148 |     if s.starts_with("-") {
[INFO] [stderr]     |                      ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/figfont.rs:188:30
[INFO] [stderr]     |
[INFO] [stderr] 188 |     pub fn from_lines(lines: &Vec<&str>) -> Result<Self, Error> {
[INFO] [stderr]     |                              ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/figfont.rs:239:16
[INFO] [stderr]     |
[INFO] [stderr] 239 |             if line.len() < 1 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_1(l, r, mode) { apply_rule!(rule_1(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 92 |       apply_rule!(rule_1(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_2(l, r, mode) { apply_rule!(rule_2(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 93 |       apply_rule!(rule_2(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_3(l, r, mode) { apply_rule!(rule_3(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 94 |       apply_rule!(rule_3(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_4(l, r, mode) { apply_rule!(rule_4(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 95 |       apply_rule!(rule_4(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/smusher/charsmush.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         match $cmd {
[INFO] [stderr] 44 | |             Some(val) => return Some(val),
[INFO] [stderr] 45 | |             None      => {},
[INFO] [stderr] 46 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(val) = rule_5(l, r, mode) { apply_rule!(rule_5(l, r, mode)); }`
[INFO] [stderr] ...
[INFO] [stderr] 96 |       apply_rule!(rule_5(l, r, mode));
[INFO] [stderr]    |       -------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/rustlet.rs:12:23
[INFO] [stderr]    |
[INFO] [stderr] 12 | const FONT_DIR     : &'static str = "/usr/share/figlet";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/rustlet.rs:13:23
[INFO] [stderr]    |
[INFO] [stderr] 13 | const DEFAULT_FONT : &'static str = "standard.flf";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/smusher/charsmush.rs:213:27
[INFO] [stderr]     |
[INFO] [stderr] 213 |             for x in list[idx..idx+1].iter() {
[INFO] [stderr]     |                           ^^^^^^^^^^ help: use: `idx..=idx`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 38
[INFO] [stderr]    --> src/smusher/strsmush.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 | /     fn test_amount() {
[INFO] [stderr] 120 | |         assert_eq!(amount("", "", '$', 0xbf), 0);
[INFO] [stderr] 121 | |
[INFO] [stderr] 122 | |         assert_eq!(amount("", "    ", '$', 0xbf), 4);
[INFO] [stderr] ...   |
[INFO] [stderr] 163 | |         assert_eq!(amount("[ ", " {", '$', 0xbf), 3);   // rule 3 + spacing
[INFO] [stderr] 164 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/smusher/mod.rs:100:19
[INFO] [stderr]     |
[INFO] [stderr] 100 | fn amount(output: &Vec<String>, c: &FIGchar, hardblank: char, mode: u32) -> usize {
[INFO] [stderr]     |                   ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/smusher/mod.rs:108:17
[INFO] [stderr]     |
[INFO] [stderr] 108 | fn trim(output: &Vec<String>, width: usize) -> Vec<String> {
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/smusher/mod.rs:116:18
[INFO] [stderr]     |
[INFO] [stderr] 116 | fn smush(output: &Vec<String>, c: &FIGchar, hardblank: char, full_width: bool, mode: u32) -> Vec<String> {
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/smusher/mod.rs:118:15
[INFO] [stderr]     |
[INFO] [stderr] 118 |       let amt = match full_width {
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 119 | |         true  => 0,
[INFO] [stderr] 120 | |         false => amount(&output, c, hardblank, mode),
[INFO] [stderr] 121 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if full_width { 0 } else { amount(&output, c, hardblank, mode) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/bin/rustlet.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     match run(&fontpath, &msg, &matches) {
[INFO] [stderr] 61 | |         Err(e) => { println!("Error: {}", e) }
[INFO] [stderr] 62 | |         Ok(_)  => {},
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Err(e) = run(&fontpath, &msg, &matches) { println!("Error: {}", e) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/rustlet.rs:110:8
[INFO] [stderr]     |
[INFO] [stderr] 110 |     if msg.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/bin/rustlet.rs:142:38
[INFO] [stderr]     |
[INFO] [stderr] 142 |       re.captures_iter(s).for_each(|x| match x.get(0) {
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 143 | |         Some(val) => wr.wrap_str(val.as_str(), &print_output),
[INFO] [stderr] 144 | |         None      => {},
[INFO] [stderr] 145 | |     });
[INFO] [stderr]     | |_____^ help: try this: `if let Some(val) = x.get(0) { wr.wrap_str(val.as_str(), &print_output) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/bin/rustlet.rs:148:20
[INFO] [stderr]     |
[INFO] [stderr] 148 | fn print_output(v: &Vec<String>) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/rustlet.rs:12:23
[INFO] [stderr]    |
[INFO] [stderr] 12 | const FONT_DIR     : &'static str = "/usr/share/figlet";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/rustlet.rs:13:23
[INFO] [stderr]    |
[INFO] [stderr] 13 | const DEFAULT_FONT : &'static str = "standard.flf";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/bin/rustlet.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     match run(&fontpath, &msg, &matches) {
[INFO] [stderr] 61 | |         Err(e) => { println!("Error: {}", e) }
[INFO] [stderr] 62 | |         Ok(_)  => {},
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Err(e) = run(&fontpath, &msg, &matches) { println!("Error: {}", e) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bin/rustlet.rs:110:8
[INFO] [stderr]     |
[INFO] [stderr] 110 |     if msg.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!msg.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/bin/rustlet.rs:142:38
[INFO] [stderr]     |
[INFO] [stderr] 142 |       re.captures_iter(s).for_each(|x| match x.get(0) {
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 143 | |         Some(val) => wr.wrap_str(val.as_str(), &print_output),
[INFO] [stderr] 144 | |         None      => {},
[INFO] [stderr] 145 | |     });
[INFO] [stderr]     | |_____^ help: try this: `if let Some(val) = x.get(0) { wr.wrap_str(val.as_str(), &print_output) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/bin/rustlet.rs:148:20
[INFO] [stderr]     |
[INFO] [stderr] 148 | fn print_output(v: &Vec<String>) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.22s
[INFO] running `"docker" "inspect" "e5404f492516d72b3ec0ef68d11e3d2f17290d9d7053d33adc6262d81c9e772e"`
[INFO] running `"docker" "rm" "-f" "e5404f492516d72b3ec0ef68d11e3d2f17290d9d7053d33adc6262d81c9e772e"`
[INFO] [stdout] e5404f492516d72b3ec0ef68d11e3d2f17290d9d7053d33adc6262d81c9e772e