[INFO] updating cached repository cmatsuoka/fortune-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cmatsuoka/fortune-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cmatsuoka/fortune-rs" "work/ex/clippy-test-run/sources/stable/gh/cmatsuoka/fortune-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cmatsuoka/fortune-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cmatsuoka/fortune-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmatsuoka/fortune-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmatsuoka/fortune-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d11178d541527821ca7ebd0d16e433aef7a52ce0 [INFO] sha for GitHub repo cmatsuoka/fortune-rs: d11178d541527821ca7ebd0d16e433aef7a52ce0 [INFO] validating manifest of cmatsuoka/fortune-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cmatsuoka/fortune-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cmatsuoka/fortune-rs [INFO] finished frobbing cmatsuoka/fortune-rs [INFO] frobbed toml for cmatsuoka/fortune-rs written to work/ex/clippy-test-run/sources/stable/gh/cmatsuoka/fortune-rs/Cargo.toml [INFO] started frobbing cmatsuoka/fortune-rs [INFO] finished frobbing cmatsuoka/fortune-rs [INFO] frobbed toml for cmatsuoka/fortune-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cmatsuoka/fortune-rs/Cargo.toml [INFO] crate cmatsuoka/fortune-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cmatsuoka/fortune-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cmatsuoka/fortune-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d75b23d3425c61ebfc9b81fea16cc25b6d41cadd65b3fb58c2d1768eb3ef9aa4 [INFO] running `"docker" "start" "-a" "d75b23d3425c61ebfc9b81fea16cc25b6d41cadd65b3fb58c2d1768eb3ef9aa4"` [INFO] [stderr] Checking rot13 v0.1.1 [INFO] [stderr] Checking fortune v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const FORTUNE_DIR : &'static str = "/usr/share/games/fortunes"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const FORTUNE_DIR : &'static str = "/usr/share/games/fortunes"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/fortune/strfile.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if (long_only || size > slen) && (short_only || size <= slen) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(long_only || size > slen) && (short_only || size <= slen)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fortune/strfile.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | try!(f.seek(SeekFrom::Start(start as u64))); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/fortune/strfile.rs:121:16 [INFO] [stderr] | [INFO] [stderr] 121 | if (!long_only && size <= slen) || (!short_only && size > slen) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!long_only && size <= slen || !short_only && size > slen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/fortune/strfile.rs:169:18 [INFO] [stderr] | [INFO] [stderr] 169 | for _ in 0..(self.numstr + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.numstr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/fortune/mod.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if files.len() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using files.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/fortune/strfile.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if (long_only || size > slen) && (short_only || size <= slen) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(long_only || size > slen) && (short_only || size <= slen)` [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | if m.ends_with("%") { [INFO] [stderr] | ^^^ help: try using a char instead: `'%'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fortune/strfile.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | try!(f.seek(SeekFrom::Start(start as u64))); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / match matches.opt_str("n") { [INFO] [stderr] 108 | | Some(val) => { [INFO] [stderr] 109 | | fortune = fortune.short_len(val.parse()?); [INFO] [stderr] 110 | | }, [INFO] [stderr] 111 | | None => (), [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | if let Some(val) = matches.opt_str("n") { [INFO] [stderr] 108 | fortune = fortune.short_len(val.parse()?); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/fortune/strfile.rs:121:16 [INFO] [stderr] | [INFO] [stderr] 121 | if (!long_only && size <= slen) || (!short_only && size > slen) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!long_only && size <= slen || !short_only && size > slen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fortune`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/fortune/strfile.rs:169:18 [INFO] [stderr] | [INFO] [stderr] 169 | for _ in 0..(self.numstr + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.numstr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/fortune/mod.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if files.len() <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using files.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | if m.ends_with("%") { [INFO] [stderr] | ^^^ help: try using a char instead: `'%'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / match matches.opt_str("n") { [INFO] [stderr] 108 | | Some(val) => { [INFO] [stderr] 109 | | fortune = fortune.short_len(val.parse()?); [INFO] [stderr] 110 | | }, [INFO] [stderr] 111 | | None => (), [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | if let Some(val) = matches.opt_str("n") { [INFO] [stderr] 108 | fortune = fortune.short_len(val.parse()?); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fortune`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d75b23d3425c61ebfc9b81fea16cc25b6d41cadd65b3fb58c2d1768eb3ef9aa4"` [INFO] running `"docker" "rm" "-f" "d75b23d3425c61ebfc9b81fea16cc25b6d41cadd65b3fb58c2d1768eb3ef9aa4"` [INFO] [stdout] d75b23d3425c61ebfc9b81fea16cc25b6d41cadd65b3fb58c2d1768eb3ef9aa4