[INFO] updating cached repository clynamen/rust_pcd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/clynamen/rust_pcd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/clynamen/rust_pcd" "work/ex/clippy-test-run/sources/stable/gh/clynamen/rust_pcd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/clynamen/rust_pcd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/clynamen/rust_pcd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clynamen/rust_pcd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clynamen/rust_pcd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 02cdad962057775a35bc873c61dcd126595c2e3f [INFO] sha for GitHub repo clynamen/rust_pcd: 02cdad962057775a35bc873c61dcd126595c2e3f [INFO] validating manifest of clynamen/rust_pcd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clynamen/rust_pcd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clynamen/rust_pcd [INFO] finished frobbing clynamen/rust_pcd [INFO] frobbed toml for clynamen/rust_pcd written to work/ex/clippy-test-run/sources/stable/gh/clynamen/rust_pcd/Cargo.toml [INFO] started frobbing clynamen/rust_pcd [INFO] finished frobbing clynamen/rust_pcd [INFO] frobbed toml for clynamen/rust_pcd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clynamen/rust_pcd/Cargo.toml [INFO] crate clynamen/rust_pcd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clynamen/rust_pcd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/clynamen/rust_pcd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0743c7a17020f646996f394c7067aad0def6819ddc05536272f33e940f2146e9 [INFO] running `"docker" "start" "-a" "0743c7a17020f646996f394c7067aad0def6819ddc05536272f33e940f2146e9"` [INFO] [stderr] Checking pcd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:153:72 [INFO] [stderr] | [INFO] [stderr] 153 | Ok(ar) => { header.viewpoint(Viewpoint{ar:ar}); } [INFO] [stderr] | ^^^^^ help: replace it with: `ar` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | type_: type_, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | count: count [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:153:72 [INFO] [stderr] | [INFO] [stderr] 153 | Ok(ar) => { header.viewpoint(Viewpoint{ar:ar}); } [INFO] [stderr] | ^^^^^ help: replace it with: `ar` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | type_: type_, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pcd_parser.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | count: count [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Error` [INFO] [stderr] --> src/pcd_parser.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::io::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Error` [INFO] [stderr] --> src/pcd_parser.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::io::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/pcd_parser.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tmp_fields` [INFO] [stderr] --> src/pcd_parser.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let tmp_fields : Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_tmp_fields` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `error` [INFO] [stderr] --> src/pcd_parser.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | fn from(error: ParseIntError) -> HeaderError { HeaderError::IntError } [INFO] [stderr] | ^^^^^ help: consider using `_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `error` [INFO] [stderr] --> src/pcd_parser.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | fn from(error: String) -> HeaderError { HeaderError::IntError } [INFO] [stderr] | ^^^^^ help: consider using `_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tmp_fields` [INFO] [stderr] --> src/pcd_parser.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let tmp_fields : Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_tmp_fields` instead [INFO] [stderr] | [INFO] [stderr] warning: variant is never constructed: `BINARY` [INFO] [stderr] --> src/pcd_parser.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | BINARY, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] extern crate derive_builder; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `error` [INFO] [stderr] --> src/pcd_parser.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | fn from(error: ParseIntError) -> HeaderError { HeaderError::IntError } [INFO] [stderr] | ^^^^^ help: consider using `_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `error` [INFO] [stderr] --> src/pcd_parser.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | fn from(error: String) -> HeaderError { HeaderError::IntError } [INFO] [stderr] | ^^^^^ help: consider using `_error` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `D` [INFO] [stderr] --> src/pcd_parser.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | D [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BINARY` [INFO] [stderr] --> src/pcd_parser.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | BINARY, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FloatError` [INFO] [stderr] --> src/pcd_parser.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | FloatError, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ErrorDesc` [INFO] [stderr] --> src/pcd_parser.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | ErrorDesc(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FieldIncomplete` [INFO] [stderr] --> src/pcd_parser.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | FieldIncomplete [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_pcd_header_from_lines` [INFO] [stderr] --> src/pcd_parser.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / fn read_pcd_header_from_lines(lines: Lines) -> Result [INFO] [stderr] 100 | | where T: BufRead [INFO] [stderr] 101 | | { [INFO] [stderr] 102 | | let mut header = PcdHeaderBuilder::default(); [INFO] [stderr] ... | [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] extern crate derive_builder; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `HEADER` should have a snake case name such as `header` [INFO] [stderr] --> src/pcd_parser.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | let HEADER = br#" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.34s [INFO] running `"docker" "inspect" "0743c7a17020f646996f394c7067aad0def6819ddc05536272f33e940f2146e9"` [INFO] running `"docker" "rm" "-f" "0743c7a17020f646996f394c7067aad0def6819ddc05536272f33e940f2146e9"` [INFO] [stdout] 0743c7a17020f646996f394c7067aad0def6819ddc05536272f33e940f2146e9