[INFO] updating cached repository clemarescx/simd_bench [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/clemarescx/simd_bench [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/clemarescx/simd_bench" "work/ex/clippy-test-run/sources/stable/gh/clemarescx/simd_bench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/clemarescx/simd_bench'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/clemarescx/simd_bench" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clemarescx/simd_bench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clemarescx/simd_bench'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7d64d5c31bf35f272114d363712778876853b807 [INFO] sha for GitHub repo clemarescx/simd_bench: 7d64d5c31bf35f272114d363712778876853b807 [INFO] validating manifest of clemarescx/simd_bench on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clemarescx/simd_bench on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clemarescx/simd_bench [INFO] finished frobbing clemarescx/simd_bench [INFO] frobbed toml for clemarescx/simd_bench written to work/ex/clippy-test-run/sources/stable/gh/clemarescx/simd_bench/Cargo.toml [INFO] started frobbing clemarescx/simd_bench [INFO] finished frobbing clemarescx/simd_bench [INFO] frobbed toml for clemarescx/simd_bench written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clemarescx/simd_bench/Cargo.toml [INFO] crate clemarescx/simd_bench has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clemarescx/simd_bench against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/clemarescx/simd_bench:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2c1e06b56fca87c541347c3d319ad4e714b251709d6c2f384a79b015d184a29d [INFO] running `"docker" "start" "-a" "2c1e06b56fca87c541347c3d319ad4e714b251709d6c2f384a79b015d184a29d"` [INFO] [stderr] Checking criterion-plot v0.2.5 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stderr] Checking simding_benches v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> benches/simd_benches.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> benches/simd_benches.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let r = add_two_inline_return_inner(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> benches/simd_benches.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> benches/simd_benches.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let r = add_two_iter_return_inner(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> benches/simd_benches.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> benches/simd_benches.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let r = add_two_par_iter_return_inner(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> benches/simd_benches.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> benches/simd_benches.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let r = add_two_par_intoiter_return_inner(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> benches/simd_benches.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> benches/simd_benches.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let r = add_two_else_add_three_return_inner(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> benches/simd_benches.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> benches/simd_benches.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | let r = add_two_else_add_three_par_return_inner(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> benches/simd_benches.rs:164:27 [INFO] [stderr] | [INFO] [stderr] 164 | b.iter(|| return unsafe { add_two_with_intrinsics_auto(&mut v) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { add_two_with_intrinsics_auto(&mut v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> benches/simd_benches.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | v.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> benches/simd_benches.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | v.as_mut_ptr().offset(offset as isize) as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `v.as_mut_ptr().add(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.85s [INFO] running `"docker" "inspect" "2c1e06b56fca87c541347c3d319ad4e714b251709d6c2f384a79b015d184a29d"` [INFO] running `"docker" "rm" "-f" "2c1e06b56fca87c541347c3d319ad4e714b251709d6c2f384a79b015d184a29d"` [INFO] [stdout] 2c1e06b56fca87c541347c3d319ad4e714b251709d6c2f384a79b015d184a29d