[INFO] updating cached repository cleap/square_sums [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cleap/square_sums [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cleap/square_sums" "work/ex/clippy-test-run/sources/stable/gh/cleap/square_sums"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cleap/square_sums'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cleap/square_sums" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cleap/square_sums"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cleap/square_sums'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c098c8cc938ac6c8fee7b2ed4f3e0c2b6672c37 [INFO] sha for GitHub repo cleap/square_sums: 8c098c8cc938ac6c8fee7b2ed4f3e0c2b6672c37 [INFO] validating manifest of cleap/square_sums on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cleap/square_sums on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cleap/square_sums [INFO] finished frobbing cleap/square_sums [INFO] frobbed toml for cleap/square_sums written to work/ex/clippy-test-run/sources/stable/gh/cleap/square_sums/Cargo.toml [INFO] started frobbing cleap/square_sums [INFO] finished frobbing cleap/square_sums [INFO] frobbed toml for cleap/square_sums written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cleap/square_sums/Cargo.toml [INFO] crate cleap/square_sums has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cleap/square_sums against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cleap/square_sums:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51c7492db2006049a62ddca60a91c18ebc1905ecc77aae568fd154f2f25837fc [INFO] running `"docker" "start" "-a" "51c7492db2006049a62ddca60a91c18ebc1905ecc77aae568fd154f2f25837fc"` [INFO] [stderr] Compiling phf v0.7.23 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.1 [INFO] [stderr] Checking piston-gfx_texture v0.26.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.43.0 [INFO] [stderr] Checking piston_window v0.70.0 [INFO] [stderr] Checking square_sums v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | ((self.num + other) as f64).sqrt().fract() == 0.0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num + other)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | for n in 1..number+1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | for other in 1..number+1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | let scale: f64 = 2.0*std::f64::consts::PI / (maxn as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(maxn)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:24 [INFO] [stderr] | [INFO] [stderr] 92 | let xcoord: f64 = (n as f64 * scale).sin() * radius + WIDTH as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:59 [INFO] [stderr] | [INFO] [stderr] 92 | let xcoord: f64 = (n as f64 * scale).sin() * radius + WIDTH as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | let ycoord: f64 = -(n as f64 * scale).cos() * radius + HEIGHT as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:60 [INFO] [stderr] | [INFO] [stderr] 93 | let ycoord: f64 = -(n as f64 * scale).cos() * radius + HEIGHT as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let ref font = "fonts/FreeMono.ttf"; [INFO] [stderr] | ----^^^^^^^^------------------------ help: try: `let font = &"fonts/FreeMono.ttf";` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | let radius: f64 = 8.0 * number as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | ((self.num + other) as f64).sqrt().fract() == 0.0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num + other)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | for n in 1..number+1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | for other in 1..number+1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | let scale: f64 = 2.0*std::f64::consts::PI / (maxn as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(maxn)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:24 [INFO] [stderr] | [INFO] [stderr] 92 | let xcoord: f64 = (n as f64 * scale).sin() * radius + WIDTH as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:59 [INFO] [stderr] | [INFO] [stderr] 92 | let xcoord: f64 = (n as f64 * scale).sin() * radius + WIDTH as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | let ycoord: f64 = -(n as f64 * scale).cos() * radius + HEIGHT as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:60 [INFO] [stderr] | [INFO] [stderr] 93 | let ycoord: f64 = -(n as f64 * scale).cos() * radius + HEIGHT as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let ref font = "fonts/FreeMono.ttf"; [INFO] [stderr] | ----^^^^^^^^------------------------ help: try: `let font = &"fonts/FreeMono.ttf";` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | let radius: f64 = 8.0 * number as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 13s [INFO] running `"docker" "inspect" "51c7492db2006049a62ddca60a91c18ebc1905ecc77aae568fd154f2f25837fc"` [INFO] running `"docker" "rm" "-f" "51c7492db2006049a62ddca60a91c18ebc1905ecc77aae568fd154f2f25837fc"` [INFO] [stdout] 51c7492db2006049a62ddca60a91c18ebc1905ecc77aae568fd154f2f25837fc