[INFO] updating cached repository clarkenciel/debug-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/clarkenciel/debug-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/clarkenciel/debug-server" "work/ex/clippy-test-run/sources/stable/gh/clarkenciel/debug-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/clarkenciel/debug-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/clarkenciel/debug-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkenciel/debug-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkenciel/debug-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a084755cd8509f7802f2cf2fdcad81614a91edd4 [INFO] sha for GitHub repo clarkenciel/debug-server: a084755cd8509f7802f2cf2fdcad81614a91edd4 [INFO] validating manifest of clarkenciel/debug-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clarkenciel/debug-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clarkenciel/debug-server [INFO] finished frobbing clarkenciel/debug-server [INFO] frobbed toml for clarkenciel/debug-server written to work/ex/clippy-test-run/sources/stable/gh/clarkenciel/debug-server/Cargo.toml [INFO] started frobbing clarkenciel/debug-server [INFO] finished frobbing clarkenciel/debug-server [INFO] frobbed toml for clarkenciel/debug-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkenciel/debug-server/Cargo.toml [INFO] crate clarkenciel/debug-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clarkenciel/debug-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/clarkenciel/debug-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d94d370736f68634e6aa89f5be067cb2957ac887dfb1619641b065c862690266 [INFO] running `"docker" "start" "-a" "d94d370736f68634e6aa89f5be067cb2957ac887dfb1619641b065c862690266"` [INFO] [stderr] Checking debug-server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | Box::new(ok(println!("{}", DebugRequest { [INFO] [stderr] | _________________^ [INFO] [stderr] 30 | | url: uri, [INFO] [stderr] 31 | | method: method, [INFO] [stderr] 32 | | body: body, [INFO] [stderr] 33 | | }))) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | ).unwrap_or("".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | chunks.iter().map(|c| *c).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `chunks.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:64:39 [INFO] [stderr] | [INFO] [stderr] 64 | let port = env::var("DEBUG_PORT").unwrap_or("8080".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "8080".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | Box::new(ok(println!("{}", DebugRequest { [INFO] [stderr] | _________________^ [INFO] [stderr] 30 | | url: uri, [INFO] [stderr] 31 | | method: method, [INFO] [stderr] 32 | | body: body, [INFO] [stderr] 33 | | }))) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | ).unwrap_or("".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | chunks.iter().map(|c| *c).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `chunks.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:64:39 [INFO] [stderr] | [INFO] [stderr] 64 | let port = env::var("DEBUG_PORT").unwrap_or("8080".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "8080".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.60s [INFO] running `"docker" "inspect" "d94d370736f68634e6aa89f5be067cb2957ac887dfb1619641b065c862690266"` [INFO] running `"docker" "rm" "-f" "d94d370736f68634e6aa89f5be067cb2957ac887dfb1619641b065c862690266"` [INFO] [stdout] d94d370736f68634e6aa89f5be067cb2957ac887dfb1619641b065c862690266