[INFO] updating cached repository clarkema/csv-clean [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/clarkema/csv-clean [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/clarkema/csv-clean" "work/ex/clippy-test-run/sources/stable/gh/clarkema/csv-clean"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/clarkema/csv-clean'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/clarkema/csv-clean" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkema/csv-clean"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkema/csv-clean'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0e46aadce4f6eae88d6025030b6c04bddcc5f543 [INFO] sha for GitHub repo clarkema/csv-clean: 0e46aadce4f6eae88d6025030b6c04bddcc5f543 [INFO] validating manifest of clarkema/csv-clean on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clarkema/csv-clean on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clarkema/csv-clean [INFO] finished frobbing clarkema/csv-clean [INFO] frobbed toml for clarkema/csv-clean written to work/ex/clippy-test-run/sources/stable/gh/clarkema/csv-clean/Cargo.toml [INFO] started frobbing clarkema/csv-clean [INFO] finished frobbing clarkema/csv-clean [INFO] frobbed toml for clarkema/csv-clean written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/clarkema/csv-clean/Cargo.toml [INFO] crate clarkema/csv-clean has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clarkema/csv-clean against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/clarkema/csv-clean:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c885ced874d5d6bfc4849836d1fd94a9a9e02130756dab415934417481577584 [INFO] running `"docker" "start" "-a" "c885ced874d5d6bfc4849836d1fd94a9a9e02130756dab415934417481577584"` [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.1 [INFO] [stderr] Checking csv-clean v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is used to index `last_line` [INFO] [stderr] --> src/main.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 0..(line.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for (i, ) in last_line.iter_mut().enumerate().take((line.len())) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | if field.len() > 0 || ! cascade_p { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!field.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | / match NaiveDate::parse_from_str(field, format) { [INFO] [stderr] 87 | | Ok(date) => { [INFO] [stderr] 88 | | iso_date = Some(date); [INFO] [stderr] 89 | | break; [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | Err(_) => {} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let Ok(date) = NaiveDate::parse_from_str(field, format) { [INFO] [stderr] 87 | iso_date = Some(date); [INFO] [stderr] 88 | break; [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:117:15 [INFO] [stderr] | [INFO] [stderr] 117 | raw.split(",").map(|c| [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `last_line` [INFO] [stderr] --> src/main.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 0..(line.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for (i, ) in last_line.iter_mut().enumerate().take((line.len())) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | if field.len() > 0 || ! cascade_p { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!field.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | / match NaiveDate::parse_from_str(field, format) { [INFO] [stderr] 87 | | Ok(date) => { [INFO] [stderr] 88 | | iso_date = Some(date); [INFO] [stderr] 89 | | break; [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | Err(_) => {} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let Ok(date) = NaiveDate::parse_from_str(field, format) { [INFO] [stderr] 87 | iso_date = Some(date); [INFO] [stderr] 88 | break; [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:117:15 [INFO] [stderr] | [INFO] [stderr] 117 | raw.split(",").map(|c| [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.17s [INFO] running `"docker" "inspect" "c885ced874d5d6bfc4849836d1fd94a9a9e02130756dab415934417481577584"` [INFO] running `"docker" "rm" "-f" "c885ced874d5d6bfc4849836d1fd94a9a9e02130756dab415934417481577584"` [INFO] [stdout] c885ced874d5d6bfc4849836d1fd94a9a9e02130756dab415934417481577584