[INFO] updating cached repository claes-magnus/test_stuff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/claes-magnus/test_stuff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/claes-magnus/test_stuff" "work/ex/clippy-test-run/sources/stable/gh/claes-magnus/test_stuff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/claes-magnus/test_stuff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/claes-magnus/test_stuff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/claes-magnus/test_stuff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/claes-magnus/test_stuff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 52814efbad7df1efd08cf31f62bd525e610e0ae3 [INFO] sha for GitHub repo claes-magnus/test_stuff: 52814efbad7df1efd08cf31f62bd525e610e0ae3 [INFO] validating manifest of claes-magnus/test_stuff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of claes-magnus/test_stuff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing claes-magnus/test_stuff [INFO] finished frobbing claes-magnus/test_stuff [INFO] frobbed toml for claes-magnus/test_stuff written to work/ex/clippy-test-run/sources/stable/gh/claes-magnus/test_stuff/Cargo.toml [INFO] started frobbing claes-magnus/test_stuff [INFO] finished frobbing claes-magnus/test_stuff [INFO] frobbed toml for claes-magnus/test_stuff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/claes-magnus/test_stuff/Cargo.toml [INFO] crate claes-magnus/test_stuff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting claes-magnus/test_stuff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/claes-magnus/test_stuff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc2b131ea770b52ec5eea8fec69d724b9a398b8581d78c112e302236421644ff [INFO] running `"docker" "start" "-a" "dc2b131ea770b52ec5eea8fec69d724b9a398b8581d78c112e302236421644ff"` [INFO] [stderr] Checking test_stuff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wall` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let wall = TileData { [INFO] [stderr] | ^^^^ help: consider using `_wall` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Floor` [INFO] [stderr] --> src/main.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | Floor, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Object` [INFO] [stderr] --> src/main.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | Object [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `kind` [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | kind: TileType, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `map_representation` [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | map_representation: i8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `filename` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | filename: String [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `MAP_WIDTH` should have a snake case name such as `map_width` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let MAP_WIDTH = 40; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `MAP_HEIGHT` should have a snake case name such as `map_height` [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let MAP_HEIGHT = 40; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `PLAYER_VIEW` should have a snake case name such as `player_view` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let PLAYER_VIEW = 8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `map2d` [INFO] [stderr] --> src/main.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..MAP_HEIGHT { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in map2d.iter_mut().enumerate().take(MAP_HEIGHT) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/main.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | } else if pos_x < 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | } else if pos_x < 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/main.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | } else if pos_y < 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | } else if pos_y < 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `map2d`. [INFO] [stderr] --> src/main.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for y in draw_map_y..(draw_map_y+PLAYER_VIEW) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for in map2d.iter().skip(draw_map_y).take(PLAYER_VIEW) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `test_stuff`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `wall` [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let wall = TileData { [INFO] [stderr] | ^^^^ help: consider using `_wall` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `MAP_WIDTH` should have a snake case name such as `map_width` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let MAP_WIDTH = 40; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `MAP_HEIGHT` should have a snake case name such as `map_height` [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let MAP_HEIGHT = 40; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `PLAYER_VIEW` should have a snake case name such as `player_view` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let PLAYER_VIEW = 8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `map2d` [INFO] [stderr] --> src/main.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..MAP_HEIGHT { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in map2d.iter_mut().enumerate().take(MAP_HEIGHT) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/main.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | } else if pos_x < 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | } else if pos_x < 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/main.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | } else if pos_y < 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | } else if pos_y < 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `map2d`. [INFO] [stderr] --> src/main.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for y in draw_map_y..(draw_map_y+PLAYER_VIEW) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for in map2d.iter().skip(draw_map_y).take(PLAYER_VIEW) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `test_stuff`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dc2b131ea770b52ec5eea8fec69d724b9a398b8581d78c112e302236421644ff"` [INFO] running `"docker" "rm" "-f" "dc2b131ea770b52ec5eea8fec69d724b9a398b8581d78c112e302236421644ff"` [INFO] [stdout] dc2b131ea770b52ec5eea8fec69d724b9a398b8581d78c112e302236421644ff