[INFO] updating cached repository ckee83/snake-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ckee83/snake-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ckee83/snake-rs" "work/ex/clippy-test-run/sources/stable/gh/ckee83/snake-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ckee83/snake-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ckee83/snake-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ckee83/snake-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ckee83/snake-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c7232745d281ae97e1baceed29a889feb22de363 [INFO] sha for GitHub repo ckee83/snake-rs: c7232745d281ae97e1baceed29a889feb22de363 [INFO] validating manifest of ckee83/snake-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ckee83/snake-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ckee83/snake-rs [INFO] finished frobbing ckee83/snake-rs [INFO] frobbed toml for ckee83/snake-rs written to work/ex/clippy-test-run/sources/stable/gh/ckee83/snake-rs/Cargo.toml [INFO] started frobbing ckee83/snake-rs [INFO] finished frobbing ckee83/snake-rs [INFO] frobbed toml for ckee83/snake-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ckee83/snake-rs/Cargo.toml [INFO] crate ckee83/snake-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ckee83/snake-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ckee83/snake-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9018103d4ddcf38cc2ce7ae7f0bd122c9f62752ce5d16f05f3460026cae4fba [INFO] running `"docker" "start" "-a" "a9018103d4ddcf38cc2ce7ae7f0bd122c9f62752ce5d16f05f3460026cae4fba"` [INFO] [stderr] Compiling bitflags v1.0.2 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking snake_rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:61:35 [INFO] [stderr] | [INFO] [stderr] 61 | let bg_outer_width: f64 = self.dimension as f64 * bg_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimension)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `40` [INFO] [stderr] --> src/game.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | let score_y = 0 + 40; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | let dim: f64 = self.dimension as f64 * self.width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimension)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:122:48 [INFO] [stderr] | [INFO] [stderr] 122 | let dim: f64 = self.dimension as f64 * self.width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:153:36 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / match btn { [INFO] [stderr] 179 | | // allow unpause [INFO] [stderr] 180 | | &Button::Keyboard(Key::Space) => { [INFO] [stderr] 181 | | if self.game_over { [INFO] [stderr] ... | [INFO] [stderr] 186 | | _ => (), [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let &Button::Keyboard(Key::Space) = btn { [INFO] [stderr] 179 | if self.game_over { [INFO] [stderr] 180 | self.reset(); [INFO] [stderr] 181 | } [INFO] [stderr] 182 | self.paused = false; [INFO] [stderr] 183 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / match btn { [INFO] [stderr] 179 | | // allow unpause [INFO] [stderr] 180 | | &Button::Keyboard(Key::Space) => { [INFO] [stderr] 181 | | if self.game_over { [INFO] [stderr] ... | [INFO] [stderr] 186 | | _ => (), [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | match *btn { [INFO] [stderr] 179 | // allow unpause [INFO] [stderr] 180 | Button::Keyboard(Key::Space) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | / match btn { [INFO] [stderr] 190 | | // Spacebar pauses the game! [INFO] [stderr] 191 | | &Button::Keyboard(Key::Space) => self.paused = !self.paused, [INFO] [stderr] 192 | | // If pressed key was an arrow, change the snake's direction [INFO] [stderr] ... | [INFO] [stderr] 197 | | _ => (), [INFO] [stderr] 198 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | match *btn { [INFO] [stderr] 190 | // Spacebar pauses the game! [INFO] [stderr] 191 | Button::Keyboard(Key::Space) => self.paused = !self.paused, [INFO] [stderr] 192 | // If pressed key was an arrow, change the snake's direction [INFO] [stderr] 193 | Button::Keyboard(Key::Up) => self.snake.change_dir(Direction::Up), [INFO] [stderr] 194 | Button::Keyboard(Key::Down) => self.snake.change_dir(Direction::Down), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | p.0 as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | p.1 as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | width as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | let x_rot_axis: f64 = (self.pos_x as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pos_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | let x_rot_axis: f64 = (self.pos_x as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:50:79 [INFO] [stderr] | [INFO] [stderr] 50 | let x_rot_axis: f64 = (self.pos_x as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | let y_rot_axis: f64 = (self.pos_y as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pos_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:51:56 [INFO] [stderr] | [INFO] [stderr] 51 | let y_rot_axis: f64 = (self.pos_y as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:51:79 [INFO] [stderr] | [INFO] [stderr] 51 | let y_rot_axis: f64 = (self.pos_y as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | .trans(-0.5 * width as f64, -0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:55:52 [INFO] [stderr] | [INFO] [stderr] 55 | .trans(-0.5 * width as f64, -0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | width as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/food.rs:67:36 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn update(&mut self, args: &UpdateArgs, snake: &Snake) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/text_renderer.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | txt: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/text_renderer.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn render( [INFO] [stderr] 26 | | &mut self, [INFO] [stderr] 27 | | gl: &mut GlGraphics, [INFO] [stderr] 28 | | args: &RenderArgs, [INFO] [stderr] ... | [INFO] [stderr] 48 | | }); [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/text_renderer.rs:51:90 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn large(&mut self, gl: &mut GlGraphics, args: &RenderArgs, x: u32, y: u32, txt: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/text_renderer.rs:54:91 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn medium(&mut self, gl: &mut GlGraphics, args: &RenderArgs, x: u32, y: u32, txt: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/text_renderer.rs:57:90 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn small(&mut self, gl: &mut GlGraphics, args: &RenderArgs, x: u32, y: u32, txt: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:61:35 [INFO] [stderr] | [INFO] [stderr] 61 | let bg_outer_width: f64 = self.dimension as f64 * bg_offset; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimension)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `40` [INFO] [stderr] --> src/game.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | let score_y = 0 + 40; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | let dim: f64 = self.dimension as f64 * self.width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimension)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:122:48 [INFO] [stderr] | [INFO] [stderr] 122 | let dim: f64 = self.dimension as f64 * self.width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:153:36 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / match btn { [INFO] [stderr] 179 | | // allow unpause [INFO] [stderr] 180 | | &Button::Keyboard(Key::Space) => { [INFO] [stderr] 181 | | if self.game_over { [INFO] [stderr] ... | [INFO] [stderr] 186 | | _ => (), [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let &Button::Keyboard(Key::Space) = btn { [INFO] [stderr] 179 | if self.game_over { [INFO] [stderr] 180 | self.reset(); [INFO] [stderr] 181 | } [INFO] [stderr] 182 | self.paused = false; [INFO] [stderr] 183 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / match btn { [INFO] [stderr] 179 | | // allow unpause [INFO] [stderr] 180 | | &Button::Keyboard(Key::Space) => { [INFO] [stderr] 181 | | if self.game_over { [INFO] [stderr] ... | [INFO] [stderr] 186 | | _ => (), [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | match *btn { [INFO] [stderr] 179 | // allow unpause [INFO] [stderr] 180 | Button::Keyboard(Key::Space) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | / match btn { [INFO] [stderr] 190 | | // Spacebar pauses the game! [INFO] [stderr] 191 | | &Button::Keyboard(Key::Space) => self.paused = !self.paused, [INFO] [stderr] 192 | | // If pressed key was an arrow, change the snake's direction [INFO] [stderr] ... | [INFO] [stderr] 197 | | _ => (), [INFO] [stderr] 198 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | match *btn { [INFO] [stderr] 190 | // Spacebar pauses the game! [INFO] [stderr] 191 | Button::Keyboard(Key::Space) => self.paused = !self.paused, [INFO] [stderr] 192 | // If pressed key was an arrow, change the snake's direction [INFO] [stderr] 193 | Button::Keyboard(Key::Up) => self.snake.change_dir(Direction::Up), [INFO] [stderr] 194 | Button::Keyboard(Key::Down) => self.snake.change_dir(Direction::Down), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | p.0 as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | p.1 as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | width as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | let x_rot_axis: f64 = (self.pos_x as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pos_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | let x_rot_axis: f64 = (self.pos_x as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:50:79 [INFO] [stderr] | [INFO] [stderr] 50 | let x_rot_axis: f64 = (self.pos_x as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | let y_rot_axis: f64 = (self.pos_y as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pos_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:51:56 [INFO] [stderr] | [INFO] [stderr] 51 | let y_rot_axis: f64 = (self.pos_y as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:51:79 [INFO] [stderr] | [INFO] [stderr] 51 | let y_rot_axis: f64 = (self.pos_y as f64 * width as f64) + (0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | .trans(-0.5 * width as f64, -0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:55:52 [INFO] [stderr] | [INFO] [stderr] 55 | .trans(-0.5 * width as f64, -0.5 * width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/food.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | width as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/food.rs:67:36 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn update(&mut self, args: &UpdateArgs, snake: &Snake) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/text_renderer.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | txt: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/text_renderer.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn render( [INFO] [stderr] 26 | | &mut self, [INFO] [stderr] 27 | | gl: &mut GlGraphics, [INFO] [stderr] 28 | | args: &RenderArgs, [INFO] [stderr] ... | [INFO] [stderr] 48 | | }); [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/text_renderer.rs:51:90 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn large(&mut self, gl: &mut GlGraphics, args: &RenderArgs, x: u32, y: u32, txt: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/text_renderer.rs:54:91 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn medium(&mut self, gl: &mut GlGraphics, args: &RenderArgs, x: u32, y: u32, txt: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/text_renderer.rs:57:90 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn small(&mut self, gl: &mut GlGraphics, args: &RenderArgs, x: u32, y: u32, txt: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.19s [INFO] running `"docker" "inspect" "a9018103d4ddcf38cc2ce7ae7f0bd122c9f62752ce5d16f05f3460026cae4fba"` [INFO] running `"docker" "rm" "-f" "a9018103d4ddcf38cc2ce7ae7f0bd122c9f62752ce5d16f05f3460026cae4fba"` [INFO] [stdout] a9018103d4ddcf38cc2ce7ae7f0bd122c9f62752ce5d16f05f3460026cae4fba