[INFO] updating cached repository ckauhaus/multiping [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ckauhaus/multiping [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ckauhaus/multiping" "work/ex/clippy-test-run/sources/stable/gh/ckauhaus/multiping"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ckauhaus/multiping'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ckauhaus/multiping" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ckauhaus/multiping"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ckauhaus/multiping'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c1e2212894ccb8d01b0c4a091097240079c5b38 [INFO] sha for GitHub repo ckauhaus/multiping: 5c1e2212894ccb8d01b0c4a091097240079c5b38 [INFO] validating manifest of ckauhaus/multiping on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ckauhaus/multiping on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ckauhaus/multiping [INFO] finished frobbing ckauhaus/multiping [INFO] frobbed toml for ckauhaus/multiping written to work/ex/clippy-test-run/sources/stable/gh/ckauhaus/multiping/Cargo.toml [INFO] started frobbing ckauhaus/multiping [INFO] finished frobbing ckauhaus/multiping [INFO] frobbed toml for ckauhaus/multiping written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ckauhaus/multiping/Cargo.toml [INFO] crate ckauhaus/multiping has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ckauhaus/multiping against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ckauhaus/multiping:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01911e2c9bd8b11274b5575cc8e388922b7004fb912adb5fefd2c238e7653b46 [INFO] running `"docker" "start" "-a" "01911e2c9bd8b11274b5575cc8e388922b7004fb912adb5fefd2c238e7653b46"` [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-ping v0.1.2 [INFO] [stderr] Checking multiping v1.1.2-dev (/opt/crater/workdir) [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/engine.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | let times: Times = timeseries.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/status.rs:46:30 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(Status::check(0. / 0., 0.1, 0.2), Unknown); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: constant division of 0.0 with 0.0 will always result in NaN [INFO] [stderr] --> src/status.rs:46:30 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(Status::check(0. / 0., 0.1, 0.2), Unknown); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_divided_by_zero)] on by default [INFO] [stderr] = help: Consider using `std::f64::NAN` if you would like a constant representing NaN [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tests.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | assert!(t.addr.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!t.addr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/tests.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | pt(&[("1.1.1.1", Some(0. / 0.)), ("2.2.2.2", Some(0.2))]).min_rtt(), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: constant division of 0.0 with 0.0 will always result in NaN [INFO] [stderr] --> src/tests.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | pt(&[("1.1.1.1", Some(0. / 0.)), ("2.2.2.2", Some(0.2))]).min_rtt(), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using `std::f64::NAN` if you would like a constant representing NaN [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `multiping`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "01911e2c9bd8b11274b5575cc8e388922b7004fb912adb5fefd2c238e7653b46"` [INFO] running `"docker" "rm" "-f" "01911e2c9bd8b11274b5575cc8e388922b7004fb912adb5fefd2c238e7653b46"` [INFO] [stdout] 01911e2c9bd8b11274b5575cc8e388922b7004fb912adb5fefd2c238e7653b46