[INFO] updating cached repository cjrh/pwrgen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cjrh/pwrgen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cjrh/pwrgen" "work/ex/clippy-test-run/sources/stable/gh/cjrh/pwrgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cjrh/pwrgen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cjrh/pwrgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cjrh/pwrgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cjrh/pwrgen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d48b5877e21f0556558830257832ba40807a5bf9
[INFO] sha for GitHub repo cjrh/pwrgen: d48b5877e21f0556558830257832ba40807a5bf9
[INFO] validating manifest of cjrh/pwrgen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cjrh/pwrgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cjrh/pwrgen
[INFO] finished frobbing cjrh/pwrgen
[INFO] frobbed toml for cjrh/pwrgen written to work/ex/clippy-test-run/sources/stable/gh/cjrh/pwrgen/Cargo.toml
[INFO] started frobbing cjrh/pwrgen
[INFO] finished frobbing cjrh/pwrgen
[INFO] frobbed toml for cjrh/pwrgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cjrh/pwrgen/Cargo.toml
[INFO] crate cjrh/pwrgen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting cjrh/pwrgen against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cjrh/pwrgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 091d5a17a8a6ba178824204f86734ad7b6c88afc0ac8b4579d455550264cf424
[INFO] running `"docker" "start" "-a" "091d5a17a8a6ba178824204f86734ad7b6c88afc0ac8b4579d455550264cf424"`
[INFO] [stderr]     Checking random_choice v0.3.2
[INFO] [stderr]     Checking pwrgen v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/methods.rs:46:38
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn password(length: u8, numbers: &bool, upper: &bool, lower: &bool,
[INFO] [stderr]    |                                      ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/methods.rs:46:52
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn password(length: u8, numbers: &bool, upper: &bool, lower: &bool,
[INFO] [stderr]    |                                                    ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/methods.rs:46:66
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn password(length: u8, numbers: &bool, upper: &bool, lower: &bool,
[INFO] [stderr]    |                                                                  ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/methods.rs:51:8
[INFO] [stderr]    |
[INFO] [stderr] 51 |     if *numbers == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*numbers`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/methods.rs:54:8
[INFO] [stderr]    |
[INFO] [stderr] 54 |     if *upper == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: try simplifying it as shown: `*upper`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/methods.rs:57:8
[INFO] [stderr]    |
[INFO] [stderr] 57 |     if *lower == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: try simplifying it as shown: `*lower`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/methods.rs:69:18
[INFO] [stderr]    |
[INFO] [stderr] 69 |         .map(|_| choicevalues.chars().choose(&mut rng).unwrap().clone())
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `choicevalues.chars().choose(&mut rng).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/methods.rs:46:38
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn password(length: u8, numbers: &bool, upper: &bool, lower: &bool,
[INFO] [stderr]    |                                      ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/methods.rs:46:52
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn password(length: u8, numbers: &bool, upper: &bool, lower: &bool,
[INFO] [stderr]    |                                                    ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/methods.rs:46:66
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn password(length: u8, numbers: &bool, upper: &bool, lower: &bool,
[INFO] [stderr]    |                                                                  ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/methods.rs:51:8
[INFO] [stderr]    |
[INFO] [stderr] 51 |     if *numbers == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*numbers`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/methods.rs:54:8
[INFO] [stderr]    |
[INFO] [stderr] 54 |     if *upper == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: try simplifying it as shown: `*upper`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/methods.rs:57:8
[INFO] [stderr]    |
[INFO] [stderr] 57 |     if *lower == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: try simplifying it as shown: `*lower`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/methods.rs:69:18
[INFO] [stderr]    |
[INFO] [stderr] 69 |         .map(|_| choicevalues.chars().choose(&mut rng).unwrap().clone())
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `choicevalues.chars().choose(&mut rng).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/methods.rs:79:47
[INFO] [stderr]    |
[INFO] [stderr] 79 |         assert_eq!(passphrase(1, " ").matches(" ").count(), 0);
[INFO] [stderr]    |                                               ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/methods.rs:80:47
[INFO] [stderr]    |
[INFO] [stderr] 80 |         assert_eq!(passphrase(2, " ").matches(" ").count(), 1);
[INFO] [stderr]    |                                               ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/methods.rs:81:47
[INFO] [stderr]    |
[INFO] [stderr] 81 |         assert_eq!(passphrase(3, " ").matches(" ").count(), 2);
[INFO] [stderr]    |                                               ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/methods.rs:82:47
[INFO] [stderr]    |
[INFO] [stderr] 82 |         assert_eq!(passphrase(4, " ").matches(" ").count(), 3);
[INFO] [stderr]    |                                               ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/methods.rs:83:47
[INFO] [stderr]    |
[INFO] [stderr] 83 |         assert_eq!(passphrase(5, " ").matches(" ").count(), 4);
[INFO] [stderr]    |                                               ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.98s
[INFO] running `"docker" "inspect" "091d5a17a8a6ba178824204f86734ad7b6c88afc0ac8b4579d455550264cf424"`
[INFO] running `"docker" "rm" "-f" "091d5a17a8a6ba178824204f86734ad7b6c88afc0ac8b4579d455550264cf424"`
[INFO] [stdout] 091d5a17a8a6ba178824204f86734ad7b6c88afc0ac8b4579d455550264cf424