[INFO] updating cached repository cjmochrie/Advent-of-Code-2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cjmochrie/Advent-of-Code-2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cjmochrie/Advent-of-Code-2017" "work/ex/clippy-test-run/sources/stable/gh/cjmochrie/Advent-of-Code-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cjmochrie/Advent-of-Code-2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cjmochrie/Advent-of-Code-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cjmochrie/Advent-of-Code-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cjmochrie/Advent-of-Code-2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4dee8ec92972b670e8feb5086cb2db7381608423 [INFO] sha for GitHub repo cjmochrie/Advent-of-Code-2017: 4dee8ec92972b670e8feb5086cb2db7381608423 [INFO] validating manifest of cjmochrie/Advent-of-Code-2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cjmochrie/Advent-of-Code-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cjmochrie/Advent-of-Code-2017 [INFO] finished frobbing cjmochrie/Advent-of-Code-2017 [INFO] frobbed toml for cjmochrie/Advent-of-Code-2017 written to work/ex/clippy-test-run/sources/stable/gh/cjmochrie/Advent-of-Code-2017/Cargo.toml [INFO] started frobbing cjmochrie/Advent-of-Code-2017 [INFO] finished frobbing cjmochrie/Advent-of-Code-2017 [INFO] frobbed toml for cjmochrie/Advent-of-Code-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cjmochrie/Advent-of-Code-2017/Cargo.toml [INFO] crate cjmochrie/Advent-of-Code-2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting cjmochrie/Advent-of-Code-2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cjmochrie/Advent-of-Code-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d49834c70d93f679484400938b0279e306ce2312230faf6bae1efa12facd35f [INFO] running `"docker" "start" "-a" "7d49834c70d93f679484400938b0279e306ce2312230faf6bae1efa12facd35f"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_3.rs:54:80 [INFO] [stderr] | [INFO] [stderr] 54 | State { direction: Direction::Right, steps: 1, row: 0, column: 0, size: 3, board: board } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_7.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | Program { name: name, weight: weight, children: children } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_7.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | Program { name: name, weight: weight, children: children } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_7.rs:29:43 [INFO] [stderr] | [INFO] [stderr] 29 | Program { name: name, weight: weight, children: children } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_8.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_8.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | condition_register: condition_register, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `condition_register` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_8.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | condition: condition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `condition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_3.rs:54:80 [INFO] [stderr] | [INFO] [stderr] 54 | State { direction: Direction::Right, steps: 1, row: 0, column: 0, size: 3, board: board } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_7.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | Program { name: name, weight: weight, children: children } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_7.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | Program { name: name, weight: weight, children: children } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_7.rs:29:43 [INFO] [stderr] | [INFO] [stderr] 29 | Program { name: name, weight: weight, children: children } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_8.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_8.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | condition_register: condition_register, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `condition_register` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problems/day_8.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | condition: condition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `condition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problems/day_2.rs:10:7 [INFO] [stderr] | [INFO] [stderr] 10 | }) [INFO] [stderr] | _______^ [INFO] [stderr] 11 | | .fold(0, |sum, i| sum + i) [INFO] [stderr] | |______________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problems/day_2.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | .map(process_row) [INFO] [stderr] | ______________________^ [INFO] [stderr] 20 | | .fold(0, |sum, i| sum + i).to_string() [INFO] [stderr] | |______________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/problems/day_3.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | (self.steps as f64).sqrt() as i32 == self.size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.steps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_5.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | let elem = instructions.get_mut(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `instructions[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_6.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | let elem = banks.get_mut(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `banks[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_6.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let balance = banks.get_mut(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `banks[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problems/day_6.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | let value = balance.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*balance` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/problems/day_6.rs:71:20 [INFO] [stderr] | [INFO] [stderr] 71 | fn find_max(banks: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/problems/day_7.rs:64:37 [INFO] [stderr] | [INFO] [stderr] 64 | (*weights.entry(program_weight).or_insert(vec![])).push(child); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/problems/day_7.rs:99:62 [INFO] [stderr] | [INFO] [stderr] 99 | fn child_weight(programs: &HashMap<&str, Program>, children: &Vec<&str>) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/problems/day_8.rs:109:58 [INFO] [stderr] | [INFO] [stderr] 109 | let register = registers.entry(instruction.register).or_insert(Register::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Register::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/problems/day_9.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | fn read_data<'a>(data: String) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/problems/day_9.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | / loop { [INFO] [stderr] 96 | | match symbols.next() { [INFO] [stderr] 97 | | Some(symbol) => { [INFO] [stderr] 98 | | if symbol == Bang { [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |___^ help: try: `while let Some(symbol) = symbols.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/problems/day_10.rs:22:53 [INFO] [stderr] | [INFO] [stderr] 22 | fn reverse_list(position: u32, length: u32, list: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/problems/day_10.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | data.trim().split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/problems/day_11.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | data.trim().split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_11.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | let a_count = counter.get(&a).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counter[&a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_11.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | let b_count = counter.get(&b).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counter[&b]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problems/day_11.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | let a_count = counter.get(&a).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*counter.get(&a).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problems/day_11.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | let b_count = counter.get(&b).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*counter.get(&b).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problems/day_11.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | let result_count = counter.get(&result).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*counter.get(&result).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/problems/day_12.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | fn connections(programs: &Programs, program: usize, visited: &mut HashSet) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problems/day_2.rs:10:7 [INFO] [stderr] | [INFO] [stderr] 10 | }) [INFO] [stderr] | _______^ [INFO] [stderr] 11 | | .fold(0, |sum, i| sum + i) [INFO] [stderr] | |______________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/problems/day_2.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | .map(process_row) [INFO] [stderr] | ______________________^ [INFO] [stderr] 20 | | .fold(0, |sum, i| sum + i).to_string() [INFO] [stderr] | |______________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/problems/day_3.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | (self.steps as f64).sqrt() as i32 == self.size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.steps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_5.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | let elem = instructions.get_mut(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `instructions[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_6.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | let elem = banks.get_mut(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `banks[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_6.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let balance = banks.get_mut(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `banks[index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problems/day_6.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | let value = balance.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*balance` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/problems/day_6.rs:71:20 [INFO] [stderr] | [INFO] [stderr] 71 | fn find_max(banks: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/problems/day_7.rs:64:37 [INFO] [stderr] | [INFO] [stderr] 64 | (*weights.entry(program_weight).or_insert(vec![])).push(child); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/problems/day_7.rs:99:62 [INFO] [stderr] | [INFO] [stderr] 99 | fn child_weight(programs: &HashMap<&str, Program>, children: &Vec<&str>) -> i32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/problems/day_8.rs:109:58 [INFO] [stderr] | [INFO] [stderr] 109 | let register = registers.entry(instruction.register).or_insert(Register::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Register::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/problems/day_9.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | fn read_data<'a>(data: String) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/problems/day_9.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | / loop { [INFO] [stderr] 96 | | match symbols.next() { [INFO] [stderr] 97 | | Some(symbol) => { [INFO] [stderr] 98 | | if symbol == Bang { [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |___^ help: try: `while let Some(symbol) = symbols.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/problems/day_10.rs:22:53 [INFO] [stderr] | [INFO] [stderr] 22 | fn reverse_list(position: u32, length: u32, list: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/problems/day_10.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | data.trim().split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/problems/day_11.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | data.trim().split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_11.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | let a_count = counter.get(&a).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counter[&a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/problems/day_11.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | let b_count = counter.get(&b).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counter[&b]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problems/day_11.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | let a_count = counter.get(&a).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*counter.get(&a).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problems/day_11.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | let b_count = counter.get(&b).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*counter.get(&b).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/problems/day_11.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | let result_count = counter.get(&result).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*counter.get(&result).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/problems/day_12.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | fn connections(programs: &Programs, program: usize, visited: &mut HashSet) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.16s [INFO] running `"docker" "inspect" "7d49834c70d93f679484400938b0279e306ce2312230faf6bae1efa12facd35f"` [INFO] running `"docker" "rm" "-f" "7d49834c70d93f679484400938b0279e306ce2312230faf6bae1efa12facd35f"` [INFO] [stdout] 7d49834c70d93f679484400938b0279e306ce2312230faf6bae1efa12facd35f