[INFO] updating cached repository cite-reader/slide-puzzle
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cite-reader/slide-puzzle
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cite-reader/slide-puzzle" "work/ex/clippy-test-run/sources/stable/gh/cite-reader/slide-puzzle"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cite-reader/slide-puzzle'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cite-reader/slide-puzzle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cite-reader/slide-puzzle"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cite-reader/slide-puzzle'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5f288a9154b1793a87fb40593cc65271edafd7c6
[INFO] sha for GitHub repo cite-reader/slide-puzzle: 5f288a9154b1793a87fb40593cc65271edafd7c6
[INFO] validating manifest of cite-reader/slide-puzzle on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cite-reader/slide-puzzle on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cite-reader/slide-puzzle
[INFO] finished frobbing cite-reader/slide-puzzle
[INFO] frobbed toml for cite-reader/slide-puzzle written to work/ex/clippy-test-run/sources/stable/gh/cite-reader/slide-puzzle/Cargo.toml
[INFO] started frobbing cite-reader/slide-puzzle
[INFO] finished frobbing cite-reader/slide-puzzle
[INFO] frobbed toml for cite-reader/slide-puzzle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cite-reader/slide-puzzle/Cargo.toml
[INFO] crate cite-reader/slide-puzzle has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cite-reader/slide-puzzle against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cite-reader/slide-puzzle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7b2869a645992cd70860e8517f3e17a9a9b5057c6f4777aed8a54da3462b1c5f
[INFO] running `"docker" "start" "-a" "7b2869a645992cd70860e8517f3e17a9a9b5057c6f4777aed8a54da3462b1c5f"`
[INFO] [stderr]     Checking slide-puzzle v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/game.rs:102:25
[INFO] [stderr]     |
[INFO] [stderr] 102 |             Some(Board{ cells: cells, side: size as usize})
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `cells`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/search.rs:25:29
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fringe.push(AstarNode { goal: goal, node: start.clone(), path_len: 0 });
[INFO] [stderr]    |                             ^^^^^^^^^^ help: replace it with: `goal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/search.rs:41:29
[INFO] [stderr]    |
[INFO] [stderr] 41 |                             goal: goal,
[INFO] [stderr]    |                             ^^^^^^^^^^ help: replace it with: `goal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/game.rs:102:25
[INFO] [stderr]     |
[INFO] [stderr] 102 |             Some(Board{ cells: cells, side: size as usize})
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `cells`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/search.rs:25:29
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fringe.push(AstarNode { goal: goal, node: start.clone(), path_len: 0 });
[INFO] [stderr]    |                             ^^^^^^^^^^ help: replace it with: `goal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/search.rs:41:29
[INFO] [stderr]    |
[INFO] [stderr] 41 |                             goal: goal,
[INFO] [stderr]    |                             ^^^^^^^^^^ help: replace it with: `goal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         return board == *target;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `board == *target`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/game.rs:172:21
[INFO] [stderr]     |
[INFO] [stderr] 172 |         for tile in (1 .. self.cells.len() - 1) {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         return board == *target;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `board == *target`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> src/game.rs:172:21
[INFO] [stderr]     |
[INFO] [stderr] 172 |         for tile in (1 .. self.cells.len() - 1) {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/game.rs:121:26
[INFO] [stderr]     |
[INFO] [stderr] 121 |     fn from_linear_index(&self, i: usize) -> (usize, usize) {
[INFO] [stderr]     |                          ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/game.rs:193:18
[INFO] [stderr]     |
[INFO] [stderr] 193 |                 .expect(&format!("The board didn’t have a {} tile", tile))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("The board didn’t have a {} tile", tile))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/game.rs:191:13
[INFO] [stderr]     |
[INFO] [stderr] 191 | /             self.cells.iter().enumerate().filter(|&(_, &cell)| cell == tile)
[INFO] [stderr] 192 | |                 .next()
[INFO] [stderr]     | |_______________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|&(_, &cell)| cell == tile).next()` with `find(|&(_, &cell)| cell == tile)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/search.rs:59:20
[INFO] [stderr]    |
[INFO] [stderr] 59 |       let movement = match movements.get(ending)
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 60 | |         .expect("Surely the ending configuration has a path to it.") {
[INFO] [stderr] 61 | |             &None => /* special case: the goal is the start, return the trivial
[INFO] [stderr] 62 | |                 path */ return Vec::new(),
[INFO] [stderr] 63 | |             &Some(m) => m
[INFO] [stderr] 64 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 59 |     let movement = match *movements.get(ending)
[INFO] [stderr] 60 |         .expect("Surely the ending configuration has a path to it.") {
[INFO] [stderr] 61 |             None => /* special case: the goal is the start, return the trivial
[INFO] [stderr] 62 |                 path */ return Vec::new(),
[INFO] [stderr] 63 |             Some(m) => m
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/game.rs:121:26
[INFO] [stderr]     |
[INFO] [stderr] 121 |     fn from_linear_index(&self, i: usize) -> (usize, usize) {
[INFO] [stderr]     |                          ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/game.rs:193:18
[INFO] [stderr]     |
[INFO] [stderr] 193 |                 .expect(&format!("The board didn’t have a {} tile", tile))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("The board didn’t have a {} tile", tile))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/game.rs:191:13
[INFO] [stderr]     |
[INFO] [stderr] 191 | /             self.cells.iter().enumerate().filter(|&(_, &cell)| cell == tile)
[INFO] [stderr] 192 | |                 .next()
[INFO] [stderr]     | |_______________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|&(_, &cell)| cell == tile).next()` with `find(|&(_, &cell)| cell == tile)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/search.rs:59:20
[INFO] [stderr]    |
[INFO] [stderr] 59 |       let movement = match movements.get(ending)
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 60 | |         .expect("Surely the ending configuration has a path to it.") {
[INFO] [stderr] 61 | |             &None => /* special case: the goal is the start, return the trivial
[INFO] [stderr] 62 | |                 path */ return Vec::new(),
[INFO] [stderr] 63 | |             &Some(m) => m
[INFO] [stderr] 64 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 59 |     let movement = match *movements.get(ending)
[INFO] [stderr] 60 |         .expect("Surely the ending configuration has a path to it.") {
[INFO] [stderr] 61 |             None => /* special case: the goal is the start, return the trivial
[INFO] [stderr] 62 |                 path */ return Vec::new(),
[INFO] [stderr] 63 |             Some(m) => m
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> terminal-puzzle/main.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         (1 .. start_board.side() * start_board.side() + 1)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=start_board.side() * start_board.side())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> terminal-puzzle/main.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         stdin().read_line(&mut user_input).ok().expect("Failed to read line");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> terminal-puzzle/main.rs:57:12
[INFO] [stderr]    |
[INFO] [stderr] 57 |         if trimmed.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> terminal-puzzle/main.rs:61:22
[INFO] [stderr]    |
[INFO] [stderr] 61 |           numbers.push(trimmed.parse()
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 62 | |                      .ok()
[INFO] [stderr] 63 | |                      .expect("That doesn’t look like a number."));
[INFO] [stderr]    | |________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> terminal-puzzle/main.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         (1 .. start_board.side() * start_board.side() + 1)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=start_board.side() * start_board.side())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> terminal-puzzle/main.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         stdin().read_line(&mut user_input).ok().expect("Failed to read line");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> terminal-puzzle/main.rs:57:12
[INFO] [stderr]    |
[INFO] [stderr] 57 |         if trimmed.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> terminal-puzzle/main.rs:61:22
[INFO] [stderr]    |
[INFO] [stderr] 61 |           numbers.push(trimmed.parse()
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 62 | |                      .ok()
[INFO] [stderr] 63 | |                      .expect("That doesn’t look like a number."));
[INFO] [stderr]    | |________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.26s
[INFO] running `"docker" "inspect" "7b2869a645992cd70860e8517f3e17a9a9b5057c6f4777aed8a54da3462b1c5f"`
[INFO] running `"docker" "rm" "-f" "7b2869a645992cd70860e8517f3e17a9a9b5057c6f4777aed8a54da3462b1c5f"`
[INFO] [stdout] 7b2869a645992cd70860e8517f3e17a9a9b5057c6f4777aed8a54da3462b1c5f