[INFO] updating cached repository chufanl/shiori
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/chufanl/shiori
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/chufanl/shiori" "work/ex/clippy-test-run/sources/stable/gh/chufanl/shiori"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chufanl/shiori'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/chufanl/shiori" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chufanl/shiori"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chufanl/shiori'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f25319a3bab9b36f7f309f0366335d37bb8562bf
[INFO] sha for GitHub repo chufanl/shiori: f25319a3bab9b36f7f309f0366335d37bb8562bf
[INFO] validating manifest of chufanl/shiori on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chufanl/shiori on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chufanl/shiori
[INFO] finished frobbing chufanl/shiori
[INFO] frobbed toml for chufanl/shiori written to work/ex/clippy-test-run/sources/stable/gh/chufanl/shiori/Cargo.toml
[INFO] started frobbing chufanl/shiori
[INFO] finished frobbing chufanl/shiori
[INFO] frobbed toml for chufanl/shiori written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chufanl/shiori/Cargo.toml
[INFO] crate chufanl/shiori has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chufanl/shiori against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chufanl/shiori:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a32b11132cfd54c25505180d036e13c22be664a0ce710d380a3b58ed2031c934
[INFO] running `"docker" "start" "-a" "a32b11132cfd54c25505180d036e13c22be664a0ce710d380a3b58ed2031c934"`
[INFO] [stderr]    Compiling syn v0.13.10
[INFO] [stderr]    Compiling serde_derive v1.0.55
[INFO] [stderr]     Checking shiori v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |     database
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:66:20
[INFO] [stderr]    |
[INFO] [stderr] 66 |       let database = match File::open(file) {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 67 | |         Ok(mut f) => {
[INFO] [stderr] 68 | |             let mut contents = String::new();
[INFO] [stderr] 69 | |             f.read_to_string(&mut contents)
[INFO] [stderr] ...  |
[INFO] [stderr] 76 | |         }
[INFO] [stderr] 77 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sub_m`
[INFO] [stderr]   --> src/main.rs:51:23
[INFO] [stderr]    |
[INFO] [stderr] 51 |         ("list", Some(sub_m)) => {
[INFO] [stderr]    |                       ^^^^^ help: consider using `_sub_m` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sub_m`
[INFO] [stderr]   --> src/main.rs:54:24
[INFO] [stderr]    |
[INFO] [stderr] 54 |         ("watch", Some(sub_m)) => {
[INFO] [stderr]    |                        ^^^^^ help: consider using `_sub_m` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `db`
[INFO] [stderr]   --> src/main.rs:89:9
[INFO] [stderr]    |
[INFO] [stderr] 89 |     let db = load_db(file);
[INFO] [stderr]    |         ^^ help: consider using `_db` instead
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 |     database
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:66:20
[INFO] [stderr]    |
[INFO] [stderr] 66 |       let database = match File::open(file) {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 67 | |         Ok(mut f) => {
[INFO] [stderr] 68 | |             let mut contents = String::new();
[INFO] [stderr] 69 | |             f.read_to_string(&mut contents)
[INFO] [stderr] ...  |
[INFO] [stderr] 76 | |         }
[INFO] [stderr] 77 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sub_m`
[INFO] [stderr]   --> src/main.rs:51:23
[INFO] [stderr]    |
[INFO] [stderr] 51 |         ("list", Some(sub_m)) => {
[INFO] [stderr]    |                       ^^^^^ help: consider using `_sub_m` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sub_m`
[INFO] [stderr]   --> src/main.rs:54:24
[INFO] [stderr]    |
[INFO] [stderr] 54 |         ("watch", Some(sub_m)) => {
[INFO] [stderr]    |                        ^^^^^ help: consider using `_sub_m` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `db`
[INFO] [stderr]   --> src/main.rs:89:9
[INFO] [stderr]    |
[INFO] [stderr] 89 |     let db = load_db(file);
[INFO] [stderr]    |         ^^ help: consider using `_db` instead
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 20.08s
[INFO] running `"docker" "inspect" "a32b11132cfd54c25505180d036e13c22be664a0ce710d380a3b58ed2031c934"`
[INFO] running `"docker" "rm" "-f" "a32b11132cfd54c25505180d036e13c22be664a0ce710d380a3b58ed2031c934"`
[INFO] [stdout] a32b11132cfd54c25505180d036e13c22be664a0ce710d380a3b58ed2031c934