[INFO] updating cached repository chufanl/plainchat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chufanl/plainchat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chufanl/plainchat" "work/ex/clippy-test-run/sources/stable/gh/chufanl/plainchat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chufanl/plainchat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chufanl/plainchat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chufanl/plainchat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chufanl/plainchat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ee5e322a18fbe86c3e34e8d3cbecb812dd3c147a [INFO] sha for GitHub repo chufanl/plainchat: ee5e322a18fbe86c3e34e8d3cbecb812dd3c147a [INFO] validating manifest of chufanl/plainchat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chufanl/plainchat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chufanl/plainchat [INFO] finished frobbing chufanl/plainchat [INFO] frobbed toml for chufanl/plainchat written to work/ex/clippy-test-run/sources/stable/gh/chufanl/plainchat/Cargo.toml [INFO] started frobbing chufanl/plainchat [INFO] finished frobbing chufanl/plainchat [INFO] frobbed toml for chufanl/plainchat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chufanl/plainchat/Cargo.toml [INFO] crate chufanl/plainchat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chufanl/plainchat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chufanl/plainchat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c352d39d78c57ce058f8aafdbc13b13bc596366e3697a03d4a31eebd35e0b60a [INFO] running `"docker" "start" "-a" "c352d39d78c57ce058f8aafdbc13b13bc596366e3697a03d4a31eebd35e0b60a"` [INFO] [stderr] Checking plainchat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_server.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | if let Ok(_) = client.write(b"\n") { [INFO] [stderr] | _________________________________- ^^^^^ [INFO] [stderr] 69 | | if let Ok(_) = client.flush() { [INFO] [stderr] 70 | | clientscopy.push(client); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________________________________- help: try this: `if client.write(b"\n").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_server.rs:69:44 [INFO] [stderr] | [INFO] [stderr] 69 | if let Ok(_) = client.flush() { [INFO] [stderr] | _____________________________________- ^^^^^ [INFO] [stderr] 70 | | clientscopy.push(client); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________________________________- help: try this: `if client.flush().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/pc_server.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | writer.write(b"OK\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_server.rs:111:24 [INFO] [stderr] | [INFO] [stderr] 111 | if let Ok(_) = reader.read_line(&mut bufn) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 112 | | if bufn.trim() == "OK" { [INFO] [stderr] 113 | | println!("successful handshake"); [INFO] [stderr] 114 | | return Ok(name.trim().to_string()); [INFO] [stderr] ... | [INFO] [stderr] 120 | | return Err("Connection error"); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________________- help: try this: `if reader.read_line(&mut bufn).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/pc_client.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | writer.write(ident_string.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_client.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | if let Ok(_) = reader.read_line(&mut buf) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 44 | | if buf.trim() == "OK" { [INFO] [stderr] 45 | | writer.write(b"OK\n").unwrap(); [INFO] [stderr] 46 | | writer.flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 52 | | return Err("connection error"); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_line(&mut buf).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/pc_client.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | writer.write(b"OK\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_client.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | if let Ok(_) = inp.read_line(&mut msg) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 75 | | match send.write(msg.as_bytes()) { [INFO] [stderr] 76 | | Ok(_) => { [INFO] [stderr] 77 | | send.flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________- help: try this: `if inp.read_line(&mut msg).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_server.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | if let Ok(_) = client.write(b"\n") { [INFO] [stderr] | _________________________________- ^^^^^ [INFO] [stderr] 69 | | if let Ok(_) = client.flush() { [INFO] [stderr] 70 | | clientscopy.push(client); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________________________________- help: try this: `if client.write(b"\n").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_server.rs:69:44 [INFO] [stderr] | [INFO] [stderr] 69 | if let Ok(_) = client.flush() { [INFO] [stderr] | _____________________________________- ^^^^^ [INFO] [stderr] 70 | | clientscopy.push(client); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________________________________- help: try this: `if client.flush().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: Could not compile `plainchat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/pc_server.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | writer.write(b"OK\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_server.rs:111:24 [INFO] [stderr] | [INFO] [stderr] 111 | if let Ok(_) = reader.read_line(&mut bufn) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 112 | | if bufn.trim() == "OK" { [INFO] [stderr] 113 | | println!("successful handshake"); [INFO] [stderr] 114 | | return Ok(name.trim().to_string()); [INFO] [stderr] ... | [INFO] [stderr] 120 | | return Err("Connection error"); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________________- help: try this: `if reader.read_line(&mut bufn).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/pc_client.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | writer.write(ident_string.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_client.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | if let Ok(_) = reader.read_line(&mut buf) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 44 | | if buf.trim() == "OK" { [INFO] [stderr] 45 | | writer.write(b"OK\n").unwrap(); [INFO] [stderr] 46 | | writer.flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 52 | | return Err("connection error"); [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_line(&mut buf).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/pc_client.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | writer.write(b"OK\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pc_client.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | if let Ok(_) = inp.read_line(&mut msg) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 75 | | match send.write(msg.as_bytes()) { [INFO] [stderr] 76 | | Ok(_) => { [INFO] [stderr] 77 | | send.flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________- help: try this: `if inp.read_line(&mut msg).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `plainchat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c352d39d78c57ce058f8aafdbc13b13bc596366e3697a03d4a31eebd35e0b60a"` [INFO] running `"docker" "rm" "-f" "c352d39d78c57ce058f8aafdbc13b13bc596366e3697a03d4a31eebd35e0b60a"` [INFO] [stdout] c352d39d78c57ce058f8aafdbc13b13bc596366e3697a03d4a31eebd35e0b60a