[INFO] updating cached repository chucksmash/tetris
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/chucksmash/tetris
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/chucksmash/tetris" "work/ex/clippy-test-run/sources/stable/gh/chucksmash/tetris"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chucksmash/tetris'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/chucksmash/tetris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/tetris"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/tetris'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4deac6cce2db9b49af85dcf4d2b7fbf0c16dfea5
[INFO] sha for GitHub repo chucksmash/tetris: 4deac6cce2db9b49af85dcf4d2b7fbf0c16dfea5
[INFO] validating manifest of chucksmash/tetris on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chucksmash/tetris on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chucksmash/tetris
[INFO] finished frobbing chucksmash/tetris
[INFO] frobbed toml for chucksmash/tetris written to work/ex/clippy-test-run/sources/stable/gh/chucksmash/tetris/Cargo.toml
[INFO] started frobbing chucksmash/tetris
[INFO] finished frobbing chucksmash/tetris
[INFO] frobbed toml for chucksmash/tetris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/tetris/Cargo.toml
[INFO] crate chucksmash/tetris has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chucksmash/tetris against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chucksmash/tetris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e82d4a1ff490e776b7df53765006f2f0a615ebd988f796c7586be843a20091ad
[INFO] running `"docker" "start" "-a" "e82d4a1ff490e776b7df53765006f2f0a615ebd988f796c7586be843a20091ad"`
[INFO] [stderr]     Checking num_cpus v1.6.0
[INFO] [stderr]     Checking rayon-core v1.2.1
[INFO] [stderr]     Checking rayon v0.8.1
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking image v0.13.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.43.1
[INFO] [stderr]     Checking tetris v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/lib.rs:192:17
[INFO] [stderr]     |
[INFO] [stderr] 192 | /                 if self.state == States::Clearing {
[INFO] [stderr] 193 | |                     if self.clear_ticks % 8 < 4 {
[INFO] [stderr] 194 | |                         return !full_rows.contains(&block.y);
[INFO] [stderr] 195 | |                     }
[INFO] [stderr] 196 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 if self.state == States::Clearing && self.clear_ticks % 8 < 4 {
[INFO] [stderr] 193 |     return !full_rows.contains(&block.y);
[INFO] [stderr] 194 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/lib.rs:192:17
[INFO] [stderr]     |
[INFO] [stderr] 192 | /                 if self.state == States::Clearing {
[INFO] [stderr] 193 | |                     if self.clear_ticks % 8 < 4 {
[INFO] [stderr] 194 | |                         return !full_rows.contains(&block.y);
[INFO] [stderr] 195 | |                     }
[INFO] [stderr] 196 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 if self.state == States::Clearing && self.clear_ticks % 8 < 4 {
[INFO] [stderr] 193 |     return !full_rows.contains(&block.y);
[INFO] [stderr] 194 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/models.rs:36:18
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn color(&self) -> [f32; 4] {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/models.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         match self {
[INFO] [stderr] 38 | |             &TetriminoType::O => hex("f0f000"),
[INFO] [stderr] 39 | |             &TetriminoType::I => hex("00f0f0"),
[INFO] [stderr] 40 | |             &TetriminoType::T => hex("a000f0"),
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |             &TetriminoType::L => hex("f0a000"),
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 37 |         match *self {
[INFO] [stderr] 38 |             TetriminoType::O => hex("f0f000"),
[INFO] [stderr] 39 |             TetriminoType::I => hex("00f0f0"),
[INFO] [stderr] 40 |             TetriminoType::T => hex("a000f0"),
[INFO] [stderr] 41 |             TetriminoType::S => hex("00f000"),
[INFO] [stderr] 42 |             TetriminoType::Z => hex("f00000"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/models.rs:73:25
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn as_blocks(state: &Vec<Vec<bool>>, x_offset: i32, y_offset: i32, color: [f32; 4])
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: change this to: `&[Vec<bool>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/models.rs:73:18
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn as_blocks(state: &Vec<Vec<bool>>, x_offset: i32, y_offset: i32, color: [f32; 4])
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/models.rs:36:18
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn color(&self) -> [f32; 4] {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/models.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 | /         match self {
[INFO] [stderr] 38 | |             &TetriminoType::O => hex("f0f000"),
[INFO] [stderr] 39 | |             &TetriminoType::I => hex("00f0f0"),
[INFO] [stderr] 40 | |             &TetriminoType::T => hex("a000f0"),
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |             &TetriminoType::L => hex("f0a000"),
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 37 |         match *self {
[INFO] [stderr] 38 |             TetriminoType::O => hex("f0f000"),
[INFO] [stderr] 39 |             TetriminoType::I => hex("00f0f0"),
[INFO] [stderr] 40 |             TetriminoType::T => hex("a000f0"),
[INFO] [stderr] 41 |             TetriminoType::S => hex("00f000"),
[INFO] [stderr] 42 |             TetriminoType::Z => hex("f00000"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/models.rs:92:29
[INFO] [stderr]    |
[INFO] [stderr] 92 |         Rotation::as_blocks(self.internal.get(idx).unwrap(),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.internal[idx]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/models.rs:99:29
[INFO] [stderr]    |
[INFO] [stderr] 99 |         Rotation::as_blocks(self.internal.get(next_idx).unwrap(),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.internal[next_idx]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/models.rs:73:25
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn as_blocks(state: &Vec<Vec<bool>>, x_offset: i32, y_offset: i32, color: [f32; 4])
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: change this to: `&[Vec<bool>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/models.rs:73:18
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn as_blocks(state: &Vec<Vec<bool>>, x_offset: i32, y_offset: i32, color: [f32; 4])
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/models.rs:92:29
[INFO] [stderr]    |
[INFO] [stderr] 92 |         Rotation::as_blocks(self.internal.get(idx).unwrap(),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.internal[idx]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/models.rs:99:29
[INFO] [stderr]    |
[INFO] [stderr] 99 |         Rotation::as_blocks(self.internal.get(next_idx).unwrap(),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.internal[next_idx]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/models.rs:148:9
[INFO] [stderr]     |
[INFO] [stderr] 148 |         self.states.states.keys().map(|k| k.clone()).collect()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.states.states.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:148:43
[INFO] [stderr]     |
[INFO] [stderr] 148 |         self.states.states.keys().map(|k| k.clone()).collect()
[INFO] [stderr]     |                                           ^^^^^^^^^ help: try dereferencing it: `*k`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/models.rs:152:9
[INFO] [stderr]     |
[INFO] [stderr] 152 | /         let mut was_empty = false;
[INFO] [stderr] 153 | |         if self.queued.is_empty() {
[INFO] [stderr] 154 | |             let mut rng = thread_rng();
[INFO] [stderr] 155 | |             let mut types = self.types();
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |             was_empty = true;
[INFO] [stderr] 162 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> was_empty = if self.queued.is_empty() { ..; true } else { false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:158:48
[INFO] [stderr]     |
[INFO] [stderr] 158 |                 .map(|tet_type| Tetrimino::new(tet_type.clone(), &self))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tet_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/models.rs:148:9
[INFO] [stderr]     |
[INFO] [stderr] 148 |         self.states.states.keys().map(|k| k.clone()).collect()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.states.states.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:148:43
[INFO] [stderr]     |
[INFO] [stderr] 148 |         self.states.states.keys().map(|k| k.clone()).collect()
[INFO] [stderr]     |                                           ^^^^^^^^^ help: try dereferencing it: `*k`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/models.rs:152:9
[INFO] [stderr]     |
[INFO] [stderr] 152 | /         let mut was_empty = false;
[INFO] [stderr] 153 | |         if self.queued.is_empty() {
[INFO] [stderr] 154 | |             let mut rng = thread_rng();
[INFO] [stderr] 155 | |             let mut types = self.types();
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |             was_empty = true;
[INFO] [stderr] 162 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> was_empty = if self.queued.is_empty() { ..; true } else { false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:242:65
[INFO] [stderr]     |
[INFO] [stderr] 242 |         let next = self.rotation.peek_as_blocks(self.x, self.y, self.color.clone());
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/models.rs:243:9
[INFO] [stderr]     |
[INFO] [stderr] 243 | /         match on_grid.is_legal(&next) {
[INFO] [stderr] 244 | |             true => { self.rotation.change(); true },
[INFO] [stderr] 245 | |             false => { false },
[INFO] [stderr] 246 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if on_grid.is_legal(&next) { self.rotation.change(); true } else { false }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:158:48
[INFO] [stderr]     |
[INFO] [stderr] 158 |                 .map(|tet_type| Tetrimino::new(tet_type.clone(), &self))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tet_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/models.rs:250:9
[INFO] [stderr]     |
[INFO] [stderr] 250 | /         match movement {
[INFO] [stderr] 251 | |             &Movement::Rotate => self.rotation.peek_as_blocks(self.x, self.y, self.color.clone()),
[INFO] [stderr] 252 | |             &Movement::Shift(ref dir) => {
[INFO] [stderr] 253 | |                 let blocks = self.blocks();
[INFO] [stderr] ...   |
[INFO] [stderr] 271 | |             }
[INFO] [stderr] 272 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 250 |         match *movement {
[INFO] [stderr] 251 |             Movement::Rotate => self.rotation.peek_as_blocks(self.x, self.y, self.color.clone()),
[INFO] [stderr] 252 |             Movement::Shift(ref dir) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:251:79
[INFO] [stderr]     |
[INFO] [stderr] 251 |             &Movement::Rotate => self.rotation.peek_as_blocks(self.x, self.y, self.color.clone()),
[INFO] [stderr]     |                                                                               ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/models.rs:254:17
[INFO] [stderr]     |
[INFO] [stderr] 254 | /                 match dir {
[INFO] [stderr] 255 | |                     &Direction::Down => blocks.iter().map(|block| Block {
[INFO] [stderr] 256 | |                         x: block.x,
[INFO] [stderr] 257 | |                         y: block.y - 1,
[INFO] [stderr] ...   |
[INFO] [stderr] 269 | |                     }).collect(),
[INFO] [stderr] 270 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 254 |                 match *dir {
[INFO] [stderr] 255 |                     Direction::Down => blocks.iter().map(|block| Block {
[INFO] [stderr] 256 |                         x: block.x,
[INFO] [stderr] 257 |                         y: block.y - 1,
[INFO] [stderr] 258 |                         color: block.color.clone(),
[INFO] [stderr] 259 |                     }).collect(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:242:65
[INFO] [stderr]     |
[INFO] [stderr] 242 |         let next = self.rotation.peek_as_blocks(self.x, self.y, self.color.clone());
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/models.rs:243:9
[INFO] [stderr]     |
[INFO] [stderr] 243 | /         match on_grid.is_legal(&next) {
[INFO] [stderr] 244 | |             true => { self.rotation.change(); true },
[INFO] [stderr] 245 | |             false => { false },
[INFO] [stderr] 246 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if on_grid.is_legal(&next) { self.rotation.change(); true } else { false }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/models.rs:250:9
[INFO] [stderr]     |
[INFO] [stderr] 250 | /         match movement {
[INFO] [stderr] 251 | |             &Movement::Rotate => self.rotation.peek_as_blocks(self.x, self.y, self.color.clone()),
[INFO] [stderr] 252 | |             &Movement::Shift(ref dir) => {
[INFO] [stderr] 253 | |                 let blocks = self.blocks();
[INFO] [stderr] ...   |
[INFO] [stderr] 271 | |             }
[INFO] [stderr] 272 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 250 |         match *movement {
[INFO] [stderr] 251 |             Movement::Rotate => self.rotation.peek_as_blocks(self.x, self.y, self.color.clone()),
[INFO] [stderr] 252 |             Movement::Shift(ref dir) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:251:79
[INFO] [stderr]     |
[INFO] [stderr] 251 |             &Movement::Rotate => self.rotation.peek_as_blocks(self.x, self.y, self.color.clone()),
[INFO] [stderr]     |                                                                               ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:258:32
[INFO] [stderr]     |
[INFO] [stderr] 258 |                         color: block.color.clone(),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/models.rs:254:17
[INFO] [stderr]     |
[INFO] [stderr] 254 | /                 match dir {
[INFO] [stderr] 255 | |                     &Direction::Down => blocks.iter().map(|block| Block {
[INFO] [stderr] 256 | |                         x: block.x,
[INFO] [stderr] 257 | |                         y: block.y - 1,
[INFO] [stderr] ...   |
[INFO] [stderr] 269 | |                     }).collect(),
[INFO] [stderr] 
[INFO] [stderr] 270 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 254 |                 match *dir {
[INFO] [stderr] 255 |                     Direction::Down => blocks.iter().map(|block| Block {
[INFO] [stderr] 256 |                         x: block.x,
[INFO] [stderr] 257 |                         y: block.y - 1,
[INFO] [stderr] 258 |                         color: block.color.clone(),
[INFO] [stderr] 259 |                     }).collect(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:263:32
[INFO] [stderr]     |
[INFO] [stderr] 263 |                         color: block.color.clone(),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:258:32
[INFO] [stderr]     |
[INFO] [stderr] 258 |                         color: block.color.clone(),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:263:32
[INFO] [stderr]     |
[INFO] [stderr] 263 |                         color: block.color.clone(),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:268:32
[INFO] [stderr]     |
[INFO] [stderr] 268 |                         color: block.color.clone(),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:268:32
[INFO] [stderr]     |
[INFO] [stderr] 268 |                         color: block.color.clone(),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:278:21
[INFO] [stderr]     |
[INFO] [stderr] 278 |         let color = self.color.clone();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:278:21
[INFO] [stderr]     |
[INFO] [stderr] 278 |         let color = self.color.clone();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/models.rs:316:34
[INFO] [stderr]     |
[INFO] [stderr] 316 |           let result: Vec<Block> = self.blocks.iter()
[INFO] [stderr]     |  __________________________________^
[INFO] [stderr] 317 | |             .map(|block| block.clone())
[INFO] [stderr]     | |_______________________________________^ help: Consider calling the dedicated `cloned` method: `self.blocks.iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/models.rs:316:34
[INFO] [stderr]     |
[INFO] [stderr] 316 |           let result: Vec<Block> = self.blocks.iter()
[INFO] [stderr]     |  __________________________________^
[INFO] [stderr] 317 | |             .map(|block| block.clone())
[INFO] [stderr]     | |_______________________________________^ help: Consider calling the dedicated `cloned` method: `self.blocks.iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/models.rs:331:17
[INFO] [stderr]     |
[INFO] [stderr] 331 |                 block.y = block.y - 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block.y -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/models.rs:331:17
[INFO] [stderr]     |
[INFO] [stderr] 331 |                 block.y = block.y - 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block.y -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/models.rs:345:30
[INFO] [stderr]     |
[INFO] [stderr] 345 |         let rows: Vec<i32> = (0..self.height+1).rev()
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^ help: use: `(0..=self.height)`
[INFO] [stderr]     |
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/models.rs:345:30
[INFO] [stderr]     |
[INFO] [stderr] 345 |         let rows: Vec<i32> = (0..self.height+1).rev()
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^ help: use: `(0..=self.height)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/models.rs:358:20
[INFO] [stderr]     |
[INFO] [stderr] 358 |         let rows = (0..self.height+1).rev();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: use: `(0..=self.height)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/models.rs:358:20
[INFO] [stderr]     |
[INFO] [stderr] 358 |         let rows = (0..self.height+1).rev();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^ help: use: `(0..=self.height)`
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:379:32
[INFO] [stderr]     |
[INFO] [stderr] 379 |                         color: block.color.clone(),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/models.rs:379:32
[INFO] [stderr]     |
[INFO] [stderr] 379 |                         color: block.color.clone(),
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/models.rs:384:36
[INFO] [stderr]     |
[INFO] [stderr] 384 |     pub fn is_legal(&self, blocks: &Vec<Block>) -> bool {
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]     |                                    ^^^^^^^^^^^ help: change this to: `&[Block]`
[INFO] [stderr]    --> src/models.rs:384:36
[INFO] [stderr]     |
[INFO] [stderr] 384 |     pub fn is_legal(&self, blocks: &Vec<Block>) -> bool {
[INFO] [stderr]     |                                    ^^^^^^^^^^^ help: change this to: `&[Block]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:107:21
[INFO] [stderr]     |
[INFO] [stderr] 107 | /                     match key {
[INFO] [stderr] 108 | |                         Key::P => self.resume(prev_state.as_ref().clone()),
[INFO] [stderr] 109 | |                         _ => {},
[INFO] [stderr] 110 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Key::P = key { self.resume(prev_state.as_ref().clone()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:113:21
[INFO] [stderr]     |
[INFO] [stderr] 113 | /                     match key {
[INFO] [stderr] 114 | |                         Key::Space => self.restart(),
[INFO] [stderr] 115 | |                         _ => {},
[INFO] [stderr] 116 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Key::Space = key { self.restart() }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:107:21
[INFO] [stderr]     |
[INFO] [stderr] 107 | /                     match key {
[INFO] [stderr] 108 | |                         Key::P => self.resume(prev_state.as_ref().clone()),
[INFO] [stderr] 109 | |                         _ => {},
[INFO] [stderr] 110 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Key::P = key { self.resume(prev_state.as_ref().clone()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:113:21
[INFO] [stderr]     |
[INFO] [stderr] 113 | /                     match key {
[INFO] [stderr] 114 | |                         Key::Space => self.restart(),
[INFO] [stderr] 115 | |                         _ => {},
[INFO] [stderr] 116 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Key::Space = key { self.restart() }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:205:26
[INFO] [stderr]     |
[INFO] [stderr] 205 |             let x_cell = block.x as f64;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^ help: try: `f64::from(block.x)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:206:26
[INFO] [stderr]     |
[INFO] [stderr] 206 |             let y_cell = height as f64 - block.y as f64;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:206:42
[INFO] [stderr]     |
[INFO] [stderr] 206 |             let y_cell = height as f64 - block.y as f64;
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^ help: try: `f64::from(block.y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:209:25
[INFO] [stderr]     |
[INFO] [stderr] 209 |             let color = block.color.clone();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:205:26
[INFO] [stderr]     |
[INFO] [stderr] 205 |             let x_cell = block.x as f64;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^ help: try: `f64::from(block.x)`
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:229:25
[INFO] [stderr]     |
[INFO] [stderr] 229 |             let x_cell= (block.x - 2) as f64;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(block.x - 2)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:206:26
[INFO] [stderr]     |
[INFO] [stderr] 206 |             let y_cell = height as f64 - block.y as f64;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:230:33
[INFO] [stderr]     |
[INFO] [stderr] 230 |             let y_cell = 21.0 - block.y as f64;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: try: `f64::from(block.y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:206:42
[INFO] [stderr]     |
[INFO] [stderr] 206 |             let y_cell = height as f64 - block.y as f64;
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^ help: try: `f64::from(block.y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:233:25
[INFO] [stderr]     |
[INFO] [stderr] 233 |             let color = block.color.clone();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:209:25
[INFO] [stderr]     |
[INFO] [stderr] 209 |             let color = block.color.clone();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:244:13
[INFO] [stderr]     |
[INFO] [stderr] 244 |         let ref mut font = self.cache;
[INFO] [stderr]     |         ----^^^^^^^^^^^^-------------- help: try: `let font = &mut self.cache;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:229:25
[INFO] [stderr]     |
[INFO] [stderr] 229 |             let x_cell= (block.x - 2) as f64;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(block.x - 2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:230:33
[INFO] [stderr]     |
[INFO] [stderr] 230 |             let y_cell = 21.0 - block.y as f64;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: try: `f64::from(block.y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:233:25
[INFO] [stderr]     |
[INFO] [stderr] 233 |             let color = block.color.clone();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `block.color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:244:13
[INFO] [stderr]     |
[INFO] [stderr] 244 |         let ref mut font = self.cache;
[INFO] [stderr]     |         ----^^^^^^^^^^^^-------------- help: try: `let font = &mut self.cache;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:297:13
[INFO] [stderr]     |
[INFO] [stderr] 297 |         let ref mut font = self.cache;
[INFO] [stderr]     |         ----^^^^^^^^^^^^-------------- help: try: `let font = &mut self.cache;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:301:32
[INFO] [stderr]     |
[INFO] [stderr] 301 |             screen_size[idx] = rect[idx] as f64;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^ help: try: `f64::from(rect[idx])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:329:13
[INFO] [stderr]     |
[INFO] [stderr] 329 |         let ref mut font = self.cache;
[INFO] [stderr]     |         ----^^^^^^^^^^^^-------------- help: try: `let font = &mut self.cache;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:333:32
[INFO] [stderr]     |
[INFO] [stderr] 333 |             screen_size[idx] = rect[idx] as f64;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^ help: try: `f64::from(rect[idx])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:297:13
[INFO] [stderr]     |
[INFO] [stderr] 297 |         let ref mut font = self.cache;
[INFO] [stderr]     |         ----^^^^^^^^^^^^-------------- help: try: `let font = &mut self.cache;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:301:32
[INFO] [stderr]     |
[INFO] [stderr] 301 |             screen_size[idx] = rect[idx] as f64;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^ help: try: `f64::from(rect[idx])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:378:17
[INFO] [stderr]     |
[INFO] [stderr] 378 |         let l = (self.level + 1) as u32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.level + 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:329:13
[INFO] [stderr]     |
[INFO] [stderr] 329 |         let ref mut font = self.cache;
[INFO] [stderr]     |         ----^^^^^^^^^^^^-------------- help: try: `let font = &mut self.cache;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:333:32
[INFO] [stderr]     |
[INFO] [stderr] 333 |             screen_size[idx] = rect[idx] as f64;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^ help: try: `f64::from(rect[idx])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:378:17
[INFO] [stderr]     |
[INFO] [stderr] 378 |         let l = (self.level + 1) as u32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.level + 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:468:13
[INFO] [stderr]     |
[INFO] [stderr] 468 |         let ref mut gl = GlGraphics::new(opengl);
[INFO] [stderr]     |         ----^^^^^^^^^^--------------------------- help: try: `let gl = &mut GlGraphics::new(opengl);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/lib.rs:468:13
[INFO] [stderr]     |
[INFO] [stderr] 468 |         let ref mut gl = GlGraphics::new(opengl);
[INFO] [stderr]     |         ----^^^^^^^^^^--------------------------- help: try: `let gl = &mut GlGraphics::new(opengl);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 22.84s
[INFO] running `"docker" "inspect" "e82d4a1ff490e776b7df53765006f2f0a615ebd988f796c7586be843a20091ad"`
[INFO] running `"docker" "rm" "-f" "e82d4a1ff490e776b7df53765006f2f0a615ebd988f796c7586be843a20091ad"`
[INFO] [stdout] e82d4a1ff490e776b7df53765006f2f0a615ebd988f796c7586be843a20091ad