[INFO] updating cached repository chucksmash/prev_hejmo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chucksmash/prev_hejmo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chucksmash/prev_hejmo" "work/ex/clippy-test-run/sources/stable/gh/chucksmash/prev_hejmo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chucksmash/prev_hejmo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chucksmash/prev_hejmo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/prev_hejmo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/prev_hejmo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cfa599318bf3b32c953dd1b0bca7af09a46816fb [INFO] sha for GitHub repo chucksmash/prev_hejmo: cfa599318bf3b32c953dd1b0bca7af09a46816fb [INFO] validating manifest of chucksmash/prev_hejmo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chucksmash/prev_hejmo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chucksmash/prev_hejmo [INFO] finished frobbing chucksmash/prev_hejmo [INFO] frobbed toml for chucksmash/prev_hejmo written to work/ex/clippy-test-run/sources/stable/gh/chucksmash/prev_hejmo/Cargo.toml [INFO] started frobbing chucksmash/prev_hejmo [INFO] finished frobbing chucksmash/prev_hejmo [INFO] frobbed toml for chucksmash/prev_hejmo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/prev_hejmo/Cargo.toml [INFO] crate chucksmash/prev_hejmo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chucksmash/prev_hejmo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chucksmash/prev_hejmo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05d076b23ba34e68672ec05e7269daef8426cbae97007882a519f9f64d1723b0 [INFO] running `"docker" "start" "-a" "05d076b23ba34e68672ec05e7269daef8426cbae97007882a519f9f64d1723b0"` [INFO] [stderr] Checking hejmo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | write!(screen, "{}\r\n", line).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | write!(screen, "{}\r\n", line).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `max` [INFO] [stderr] --> src/main.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | use std::cmp::{ max, min }; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/main.rs:399:12 [INFO] [stderr] | [INFO] [stderr] 399 | if new_cursor.x + 1 <= buffer.lines[new_cursor.y].len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 399 | if new_cursor.x < buffer.lines[new_cursor.y].len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `max` [INFO] [stderr] --> src/main.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | use std::cmp::{ max, min }; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/main.rs:399:12 [INFO] [stderr] | [INFO] [stderr] 399 | if new_cursor.x + 1 <= buffer.lines[new_cursor.y].len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 399 | if new_cursor.x < buffer.lines[new_cursor.y].len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d` [INFO] [stderr] --> src/main.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | let d = Dispatcher {}; [INFO] [stderr] | ^ help: consider using `_d` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:219:18 [INFO] [stderr] | [INFO] [stderr] 219 | let (x, y) = (self.cursor.x, self.cursor.y); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let (x, y) = (self.cursor.x, self.cursor.y); [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:331:32 [INFO] [stderr] | [INFO] [stderr] 331 | pub fn to_beginning(&self, buffer: &Buffer) -> Cursor { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:342:33 [INFO] [stderr] | [INFO] [stderr] 342 | pub fn to_line_start(&self, buffer: &Buffer) -> Cursor { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:356:27 [INFO] [stderr] | [INFO] [stderr] 356 | pub fn move_to(&self, buffer: &Buffer, x: usize, y: usize) -> Cursor { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:431:32 [INFO] [stderr] | [INFO] [stderr] 431 | fn to_beginning(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cursor` [INFO] [stderr] --> src/main.rs:431:49 [INFO] [stderr] | [INFO] [stderr] 431 | fn to_beginning(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^ help: consider using `_cursor` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:435:26 [INFO] [stderr] | [INFO] [stderr] 435 | fn to_end(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:451:28 [INFO] [stderr] | [INFO] [stderr] 451 | fn recenter(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | let mut line = new_buffer.lines[y].clone(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | let mut line = new_buffer.lines[y].clone(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Quit` [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Quit, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:156:18 [INFO] [stderr] | [INFO] [stderr] 156 | .map(|s| String::from(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:431:21 [INFO] [stderr] | [INFO] [stderr] 431 | fn to_beginning(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:435:15 [INFO] [stderr] | [INFO] [stderr] 435 | fn to_end(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:463:5 [INFO] [stderr] | [INFO] [stderr] 463 | env_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d` [INFO] [stderr] --> src/main.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | let d = Dispatcher {}; [INFO] [stderr] | ^ help: consider using `_d` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:219:18 [INFO] [stderr] | [INFO] [stderr] 219 | let (x, y) = (self.cursor.x, self.cursor.y); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | let (x, y) = (self.cursor.x, self.cursor.y); [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:331:32 [INFO] [stderr] | [INFO] [stderr] 331 | pub fn to_beginning(&self, buffer: &Buffer) -> Cursor { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:342:33 [INFO] [stderr] | [INFO] [stderr] 342 | pub fn to_line_start(&self, buffer: &Buffer) -> Cursor { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:356:27 [INFO] [stderr] | [INFO] [stderr] 356 | pub fn move_to(&self, buffer: &Buffer, x: usize, y: usize) -> Cursor { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:431:32 [INFO] [stderr] | [INFO] [stderr] 431 | fn to_beginning(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cursor` [INFO] [stderr] --> src/main.rs:431:49 [INFO] [stderr] | [INFO] [stderr] 431 | fn to_beginning(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^ help: consider using `_cursor` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:435:26 [INFO] [stderr] | [INFO] [stderr] 435 | fn to_end(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer` [INFO] [stderr] --> src/main.rs:451:28 [INFO] [stderr] | [INFO] [stderr] 451 | fn recenter(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^ help: consider using `_buffer` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | let mut line = new_buffer.lines[y].clone(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | let mut line = new_buffer.lines[y].clone(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Quit` [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Quit, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:156:18 [INFO] [stderr] | [INFO] [stderr] 156 | .map(|s| String::from(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:431:21 [INFO] [stderr] | [INFO] [stderr] 431 | fn to_beginning(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:435:15 [INFO] [stderr] | [INFO] [stderr] 435 | fn to_end(&mut self, buffer: &Buffer, cursor: &Cursor) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:463:5 [INFO] [stderr] | [INFO] [stderr] 463 | env_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.85s [INFO] running `"docker" "inspect" "05d076b23ba34e68672ec05e7269daef8426cbae97007882a519f9f64d1723b0"` [INFO] running `"docker" "rm" "-f" "05d076b23ba34e68672ec05e7269daef8426cbae97007882a519f9f64d1723b0"` [INFO] [stdout] 05d076b23ba34e68672ec05e7269daef8426cbae97007882a519f9f64d1723b0