[INFO] updating cached repository chucksmash/pomo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chucksmash/pomo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chucksmash/pomo" "work/ex/clippy-test-run/sources/stable/gh/chucksmash/pomo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chucksmash/pomo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chucksmash/pomo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/pomo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/pomo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f50ef9284bc51e975bfa923884a51f82af73dbff [INFO] sha for GitHub repo chucksmash/pomo: f50ef9284bc51e975bfa923884a51f82af73dbff [INFO] validating manifest of chucksmash/pomo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chucksmash/pomo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chucksmash/pomo [INFO] finished frobbing chucksmash/pomo [INFO] frobbed toml for chucksmash/pomo written to work/ex/clippy-test-run/sources/stable/gh/chucksmash/pomo/Cargo.toml [INFO] started frobbing chucksmash/pomo [INFO] finished frobbing chucksmash/pomo [INFO] frobbed toml for chucksmash/pomo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chucksmash/pomo/Cargo.toml [INFO] crate chucksmash/pomo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chucksmash/pomo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chucksmash/pomo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d9e9c9d228c2027d7c71a15667eb0ab52249bc044e7cfd269f8113e055f2d8b [INFO] running `"docker" "start" "-a" "7d9e9c9d228c2027d7c71a15667eb0ab52249bc044e7cfd269f8113e055f2d8b"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking pomo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | / write!( [INFO] [stderr] 201 | | self.stdout, [INFO] [stderr] 202 | | "{}{}{}{}{}{}\n", [INFO] [stderr] 203 | | cursor::Goto(1, 1), [INFO] [stderr] ... | [INFO] [stderr] 208 | | style::Reset [INFO] [stderr] 209 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | / write!( [INFO] [stderr] 201 | | self.stdout, [INFO] [stderr] 202 | | "{}{}{}{}{}{}\n", [INFO] [stderr] 203 | | cursor::Goto(1, 1), [INFO] [stderr] ... | [INFO] [stderr] 208 | | style::Reset [INFO] [stderr] 209 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/lib.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | use std::time::{Duration, Instant}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/lib.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | use std::time::{Duration, Instant}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | let ref mut states = self.states; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let states = &mut self.states;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | self.stdin.read(&mut key_bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | write!(self.stdout, "{}", clear::All); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:224:44 [INFO] [stderr] | [INFO] [stderr] 224 | let parts: Vec<_> = raw_time.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:557:18 [INFO] [stderr] | [INFO] [stderr] 557 | .map(|c| String::from(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | / match $test { [INFO] [stderr] 367 | | true => format!("{}", $val), [INFO] [stderr] 368 | | false => "".to_owned(), [INFO] [stderr] 369 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if total >= SEC_IN_HOUR { maybe_str!(format!("{}:", hours), total >= SEC_IN_HOUR) } else { maybe_str!(format!("{}:", hours), total >= SEC_IN_HOUR) }` [INFO] [stderr] ... [INFO] [stderr] 550 | maybe_str!(format!("{}:", hours), total >= SEC_IN_HOUR), [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | let ref mut states = self.states; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let states = &mut self.states;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:571:31 [INFO] [stderr] | [INFO] [stderr] 571 | let rendered_status = format!( [INFO] [stderr] | _______________________________^ [INFO] [stderr] 572 | | "{}", [INFO] [stderr] 573 | | match countdown.state { [INFO] [stderr] 574 | | State::Paused => "[PAUSED]", [INFO] [stderr] 575 | | _ => "", [INFO] [stderr] 576 | | } [INFO] [stderr] 577 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match countdown.state { [INFO] [stderr] 3 | State::Paused => "[PAUSED]", [INFO] [stderr] 4 | _ => "", [INFO] [stderr] 5 | }.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | self.stdin.read(&mut key_bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | write!(self.stdout, "{}", clear::All); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: Could not compile `pomo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:224:44 [INFO] [stderr] | [INFO] [stderr] 224 | let parts: Vec<_> = raw_time.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:557:18 [INFO] [stderr] | [INFO] [stderr] 557 | .map(|c| String::from(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:366:13 [INFO] [stderr] | [INFO] [stderr] 366 | / match $test { [INFO] [stderr] 367 | | true => format!("{}", $val), [INFO] [stderr] 368 | | false => "".to_owned(), [INFO] [stderr] 369 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if total >= SEC_IN_HOUR { maybe_str!(format!("{}:", hours), total >= SEC_IN_HOUR) } else { maybe_str!(format!("{}:", hours), total >= SEC_IN_HOUR) }` [INFO] [stderr] ... [INFO] [stderr] 550 | maybe_str!(format!("{}:", hours), total >= SEC_IN_HOUR), [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:571:31 [INFO] [stderr] | [INFO] [stderr] 571 | let rendered_status = format!( [INFO] [stderr] | _______________________________^ [INFO] [stderr] 572 | | "{}", [INFO] [stderr] 573 | | match countdown.state { [INFO] [stderr] 574 | | State::Paused => "[PAUSED]", [INFO] [stderr] 575 | | _ => "", [INFO] [stderr] 576 | | } [INFO] [stderr] 577 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match countdown.state { [INFO] [stderr] 3 | State::Paused => "[PAUSED]", [INFO] [stderr] 4 | _ => "", [INFO] [stderr] 5 | }.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pomo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7d9e9c9d228c2027d7c71a15667eb0ab52249bc044e7cfd269f8113e055f2d8b"` [INFO] running `"docker" "rm" "-f" "7d9e9c9d228c2027d7c71a15667eb0ab52249bc044e7cfd269f8113e055f2d8b"` [INFO] [stdout] 7d9e9c9d228c2027d7c71a15667eb0ab52249bc044e7cfd269f8113e055f2d8b