[INFO] updating cached repository chrlie/frogsay-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrlie/frogsay-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrlie/frogsay-rust" "work/ex/clippy-test-run/sources/stable/gh/chrlie/frogsay-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrlie/frogsay-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrlie/frogsay-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrlie/frogsay-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrlie/frogsay-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ba0c0851617b70e5d7001f1ac79909bddca9faae [INFO] sha for GitHub repo chrlie/frogsay-rust: ba0c0851617b70e5d7001f1ac79909bddca9faae [INFO] validating manifest of chrlie/frogsay-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrlie/frogsay-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrlie/frogsay-rust [INFO] finished frobbing chrlie/frogsay-rust [INFO] frobbed toml for chrlie/frogsay-rust written to work/ex/clippy-test-run/sources/stable/gh/chrlie/frogsay-rust/Cargo.toml [INFO] started frobbing chrlie/frogsay-rust [INFO] finished frobbing chrlie/frogsay-rust [INFO] frobbed toml for chrlie/frogsay-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrlie/frogsay-rust/Cargo.toml [INFO] crate chrlie/frogsay-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrlie/frogsay-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chrlie/frogsay-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd91b85c6336979e449bdf10035062e77748fef630b5ea00dfc055ce9e1c2846 [INFO] running `"docker" "start" "-a" "cd91b85c6336979e449bdf10035062e77748fef630b5ea00dfc055ce9e1c2846"` [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking openssl-sys v0.9.14 [INFO] [stderr] Checking bytes v0.4.4 [INFO] [stderr] Checking openssl v0.9.14 [INFO] [stderr] Checking mio v0.6.9 [INFO] [stderr] Checking tokio-io v0.1.2 [INFO] [stderr] Checking tokio-core v0.1.8 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper v0.11.1 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking frogsay v3.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pond.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | const CACHE_VERSION: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pond.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | const PROGRAM_AUTHOR: &'static str = "FROG SYSTEMS"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pond.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | const PROGRAM_NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pond.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | const CACHE_VERSION: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pond.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | const PROGRAM_AUTHOR: &'static str = "FROG SYSTEMS"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pond.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | const PROGRAM_NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/private_path.rs:220:19 [INFO] [stderr] | [INFO] [stderr] 220 | path.push(env::home_dir().ok_or(Error::from(ErrorKind::NoHomeDir))?); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/private_path.rs:220:19 [INFO] [stderr] | [INFO] [stderr] 220 | path.push(env::home_dir().ok_or(Error::from(ErrorKind::NoHomeDir))?); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/pond.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(println!("{}", speech::say(tip.tip))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pond.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | let tip = tips.pop().ok_or(Error::from(ErrorKind::NoTips))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoTips))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pond.rs:103:22 [INFO] [stderr] | [INFO] [stderr] 103 | .ok_or(Error::from(ErrorKind::NoTips)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoTips))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/speech.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | .map(|p| wrapper.fill(&format!("{}", p))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `p.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private_path.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn push<'a, S>(&'a mut self, path: S) -> &'a mut Self [INFO] [stderr] 50 | | where S: Into { [INFO] [stderr] 51 | | self.subpath.push(path.into()); [INFO] [stderr] 52 | | self [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/private_path.rs:220:35 [INFO] [stderr] | [INFO] [stderr] 220 | path.push(env::home_dir().ok_or(Error::from(ErrorKind::NoHomeDir))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoHomeDir))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | write!(io::stderr(), "{}", speech::say(format!("error: {}", why).to_uppercase().as_ref())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/pond.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(println!("{}", speech::say(tip.tip))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pond.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | let tip = tips.pop().ok_or(Error::from(ErrorKind::NoTips))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoTips))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pond.rs:103:22 [INFO] [stderr] | [INFO] [stderr] 103 | .ok_or(Error::from(ErrorKind::NoTips)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoTips))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/speech.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | .map(|p| wrapper.fill(&format!("{}", p))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `p.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/private_path.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn push<'a, S>(&'a mut self, path: S) -> &'a mut Self [INFO] [stderr] 50 | | where S: Into { [INFO] [stderr] 51 | | self.subpath.push(path.into()); [INFO] [stderr] 52 | | self [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/private_path.rs:220:35 [INFO] [stderr] | [INFO] [stderr] 220 | path.push(env::home_dir().ok_or(Error::from(ErrorKind::NoHomeDir))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoHomeDir))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | write!(io::stderr(), "{}", speech::say(format!("error: {}", why).to_uppercase().as_ref())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.25s [INFO] running `"docker" "inspect" "cd91b85c6336979e449bdf10035062e77748fef630b5ea00dfc055ce9e1c2846"` [INFO] running `"docker" "rm" "-f" "cd91b85c6336979e449bdf10035062e77748fef630b5ea00dfc055ce9e1c2846"` [INFO] [stdout] cd91b85c6336979e449bdf10035062e77748fef630b5ea00dfc055ce9e1c2846