[INFO] updating cached repository christopherjmedlin/yalc8emu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/christopherjmedlin/yalc8emu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/christopherjmedlin/yalc8emu" "work/ex/clippy-test-run/sources/stable/gh/christopherjmedlin/yalc8emu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/christopherjmedlin/yalc8emu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/christopherjmedlin/yalc8emu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christopherjmedlin/yalc8emu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christopherjmedlin/yalc8emu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa140db9922c8fff32635f89eb72ce5c7183ab59 [INFO] sha for GitHub repo christopherjmedlin/yalc8emu: fa140db9922c8fff32635f89eb72ce5c7183ab59 [INFO] validating manifest of christopherjmedlin/yalc8emu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of christopherjmedlin/yalc8emu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing christopherjmedlin/yalc8emu [INFO] finished frobbing christopherjmedlin/yalc8emu [INFO] frobbed toml for christopherjmedlin/yalc8emu written to work/ex/clippy-test-run/sources/stable/gh/christopherjmedlin/yalc8emu/Cargo.toml [INFO] started frobbing christopherjmedlin/yalc8emu [INFO] finished frobbing christopherjmedlin/yalc8emu [INFO] frobbed toml for christopherjmedlin/yalc8emu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/christopherjmedlin/yalc8emu/Cargo.toml [INFO] crate christopherjmedlin/yalc8emu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting christopherjmedlin/yalc8emu against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/christopherjmedlin/yalc8emu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e000fb397720de10a8707d97feb95b11dcfa9fbc43bd6f2977e31ece7cd7b05c [INFO] running `"docker" "start" "-a" "e000fb397720de10a8707d97feb95b11dcfa9fbc43bd6f2977e31ece7cd7b05c"` [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking chip8 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/audio.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | device: device [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/audio.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | device: device [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Duration` [INFO] [stderr] --> src/cpu/timers.rs:1:26 [INFO] [stderr] | [INFO] [stderr] 1 | use std::time::{Instant, Duration}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/timers.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return timers; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `timers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::num::Wrapping` [INFO] [stderr] --> src/cpu/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::num::Wrapping; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return self.timer_subsystem.sound > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.timer_subsystem.sound > 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/cpu/mod.rs:378:22 [INFO] [stderr] | [INFO] [stderr] 378 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/cpu/mod.rs:389:22 [INFO] [stderr] | [INFO] [stderr] 389 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return self.pixels[y][x]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pixels[y][x]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/keypad.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return self.keys[key]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.keys[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/timers.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return timers; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `timers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::num::Wrapping` [INFO] [stderr] --> src/cpu/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::num::Wrapping; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return self.timer_subsystem.sound > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.timer_subsystem.sound > 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/cpu/mod.rs:378:22 [INFO] [stderr] | [INFO] [stderr] 378 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/cpu/mod.rs:389:22 [INFO] [stderr] | [INFO] [stderr] 389 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/display.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return self.pixels[y][x]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pixels[y][x]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/keypad.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return self.keys[key]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.keys[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | Err(why) => panic!("Couldn't open ROM"), [INFO] [stderr] | ^^^ help: consider using `_why` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | for (i, &b) in rom.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 10, 10)); [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_keycode` [INFO] [stderr] --> src/keypad.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let event_keycode: Keycode; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_event_keycode` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/timers.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let mut timers = TimerSubsystem { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_pixel` [INFO] [stderr] --> src/display.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/timers.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | dur.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | (self.ram[self.pc] as u16) << 8 | (self.ram[self.pc + 1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[self.pc])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:123:43 [INFO] [stderr] | [INFO] [stderr] 123 | (self.ram[self.pc] as u16) << 8 | (self.ram[self.pc + 1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[self.pc + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method `op_00E0` should have a snake case name such as `op_00_e0` [INFO] [stderr] --> src/cpu/mod.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / fn op_00E0(&mut self) -> (usize) { [INFO] [stderr] 128 | | self.display.clear(); [INFO] [stderr] 129 | | 2 [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method `op_00EE` should have a snake case name such as `op_00_ee` [INFO] [stderr] --> src/cpu/mod.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / fn op_00EE(&mut self) -> (usize) { [INFO] [stderr] 134 | | self.pc = self.stack[self.sp]; [INFO] [stderr] 135 | | self.sp -= 1; [INFO] [stderr] 136 | | 0 [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:186:22 [INFO] [stderr] | [INFO] [stderr] 186 | let result = self.v[x] as u16 + kk as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:186:41 [INFO] [stderr] | [INFO] [stderr] 186 | let result = self.v[x] as u16 + kk as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(kk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | let vx = self.v[x] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:218:18 [INFO] [stderr] | [INFO] [stderr] 218 | let vy = self.v[y] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[y])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method `op_8xyE` should have a snake case name such as `op_8xy_e` [INFO] [stderr] --> src/cpu/mod.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stderr] 265 | | self.v[0xF] = if self.v[x] & 1 == 1 {1} else {0}; [INFO] [stderr] 266 | | self.v[x] <<= 1; [INFO] [stderr] 267 | | 2 [INFO] [stderr] 268 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Annn` should have a snake case name such as `op_annn` [INFO] [stderr] --> src/cpu/mod.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | / fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] 280 | | self.i = nnn; [INFO] [stderr] 281 | | 2 [INFO] [stderr] 282 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Bnnn` should have a snake case name such as `op_bnnn` [INFO] [stderr] --> src/cpu/mod.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | / fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] 286 | | self.pc = nnn + (self.v[0] as usize); [INFO] [stderr] 287 | | 0 [INFO] [stderr] 288 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Cxkk` should have a snake case name such as `op_cxkk` [INFO] [stderr] --> src/cpu/mod.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | / fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stderr] 292 | | let rn: u8 = rand::random(); [INFO] [stderr] 293 | | self.v[x] = rn & kk; [INFO] [stderr] 294 | | 2 [INFO] [stderr] 295 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Dxyn` should have a snake case name such as `op_dxyn` [INFO] [stderr] --> src/cpu/mod.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | / fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stderr] 299 | | let mut sprite = [0; 15]; [INFO] [stderr] 300 | | [INFO] [stderr] 301 | | for j in 0..n { [INFO] [stderr] ... | [INFO] [stderr] 308 | | 2 [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `sprite` [INFO] [stderr] --> src/cpu/mod.rs:301:18 [INFO] [stderr] | [INFO] [stderr] 301 | for j in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 301 | for (j, ) in sprite.iter_mut().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Ex9E` should have a snake case name such as `op_ex9_e` [INFO] [stderr] --> src/cpu/mod.rs:312:5 [INFO] [stderr] | [INFO] [stderr] 312 | / fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stderr] 313 | | if self.keypad.get_key(self.v[x] as usize) { return 4 } [INFO] [stderr] 314 | | 2 [INFO] [stderr] 315 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_ExA1` should have a snake case name such as `op_ex_a1` [INFO] [stderr] --> src/cpu/mod.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | / fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stderr] 319 | | if self.keypad.get_key(self.v[x] as usize) { return 2 } [INFO] [stderr] 320 | | 4 [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx07` should have a snake case name such as `op_fx07` [INFO] [stderr] --> src/cpu/mod.rs:324:5 [INFO] [stderr] | [INFO] [stderr] 324 | / fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stderr] 325 | | self.v[x] = self.timer_subsystem.delay; [INFO] [stderr] 326 | | 2 [INFO] [stderr] 327 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx0A` should have a snake case name such as `op_fx0_a` [INFO] [stderr] --> src/cpu/mod.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | / fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stderr] 331 | | let keypress = self.keypad.wait_for_keypress(); [INFO] [stderr] 332 | | if keypress == 0x10 { [INFO] [stderr] 333 | | // keep pc where it is and keep executing this same instruction [INFO] [stderr] ... | [INFO] [stderr] 340 | | 2 [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx15` should have a snake case name such as `op_fx15` [INFO] [stderr] --> src/cpu/mod.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | / fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stderr] 345 | | self.timer_subsystem.delay = self.v[x]; [INFO] [stderr] 346 | | 2 [INFO] [stderr] 347 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx18` should have a snake case name such as `op_fx18` [INFO] [stderr] --> src/cpu/mod.rs:350:5 [INFO] [stderr] | [INFO] [stderr] 350 | / fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stderr] 351 | | self.timer_subsystem.sound = self.v[x]; [INFO] [stderr] 352 | | 2 [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx1E` should have a snake case name such as `op_fx1_e` [INFO] [stderr] --> src/cpu/mod.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | / fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stderr] 357 | | self.i = self.v[x] as usize + self.i; [INFO] [stderr] 358 | | 2 [INFO] [stderr] 359 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu/mod.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | self.i = self.v[x] as usize + self.i; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i += self.v[x] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx29` should have a snake case name such as `op_fx29` [INFO] [stderr] --> src/cpu/mod.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stderr] 363 | | self.i = (self.v[x] * 5) as usize; [INFO] [stderr] 364 | | 2 [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx33` should have a snake case name such as `op_fx33` [INFO] [stderr] --> src/cpu/mod.rs:368:5 [INFO] [stderr] | [INFO] [stderr] 368 | / fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stderr] 369 | | self.ram[self.i] = self.v[x] / 100; [INFO] [stderr] 370 | | self.ram[self.i + 1] = (self.v[x] % 100) / 10; [INFO] [stderr] 371 | | self.ram[self.i + 2] = self.v[x] % 10; [INFO] [stderr] 372 | | 2 [INFO] [stderr] 373 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx55` should have a snake case name such as `op_fx55` [INFO] [stderr] --> src/cpu/mod.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | / fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stderr] 377 | | // prevent out of bounds [INFO] [stderr] 378 | | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] 379 | | [INFO] [stderr] ... | [INFO] [stderr] 383 | | 2 [INFO] [stderr] 384 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu/mod.rs:380:21 [INFO] [stderr] | [INFO] [stderr] 380 | for addr in 0..end + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx65` should have a snake case name such as `op_fx65` [INFO] [stderr] --> src/cpu/mod.rs:387:5 [INFO] [stderr] | [INFO] [stderr] 387 | / fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stderr] 388 | | // prevent out of bounds [INFO] [stderr] 389 | | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] 390 | | [INFO] [stderr] ... | [INFO] [stderr] 394 | | 2 [INFO] [stderr] 395 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu/mod.rs:391:21 [INFO] [stderr] | [INFO] [stderr] 391 | for addr in 0..end + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rom.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | file.read(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `sprite` [INFO] [stderr] --> src/display.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in sprite.iter().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | Err(why) => panic!("Couldn't open ROM"), [INFO] [stderr] | ^^^ help: consider using `_why` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pixels_cleared` [INFO] [stderr] --> src/display.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let pixels_cleared = display.draw(63, 31, 5, &sprite); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_pixels_cleared` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | for (i, &b) in rom.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 10, 10)); [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_keycode` [INFO] [stderr] --> src/keypad.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let event_keycode: Keycode; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_event_keycode` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/timers.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let mut timers = TimerSubsystem { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/timers.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | dur.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | (self.ram[self.pc] as u16) << 8 | (self.ram[self.pc + 1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[self.pc])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:123:43 [INFO] [stderr] | [INFO] [stderr] 123 | (self.ram[self.pc] as u16) << 8 | (self.ram[self.pc + 1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[self.pc + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method `op_00E0` should have a snake case name such as `op_00_e0` [INFO] [stderr] --> src/cpu/mod.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / fn op_00E0(&mut self) -> (usize) { [INFO] [stderr] 128 | | self.display.clear(); [INFO] [stderr] 129 | | 2 [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method `op_00EE` should have a snake case name such as `op_00_ee` [INFO] [stderr] --> src/cpu/mod.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / fn op_00EE(&mut self) -> (usize) { [INFO] [stderr] 134 | | self.pc = self.stack[self.sp]; [INFO] [stderr] 135 | | self.sp -= 1; [INFO] [stderr] 136 | | 0 [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:186:22 [INFO] [stderr] | [INFO] [stderr] 186 | let result = self.v[x] as u16 + kk as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:186:41 [INFO] [stderr] | [INFO] [stderr] 186 | let result = self.v[x] as u16 + kk as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(kk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | let vx = self.v[x] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:218:18 [INFO] [stderr] | [INFO] [stderr] 218 | let vy = self.v[y] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[y])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method `op_8xyE` should have a snake case name such as `op_8xy_e` [INFO] [stderr] --> src/cpu/mod.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stderr] 265 | | self.v[0xF] = if self.v[x] & 1 == 1 {1} else {0}; [INFO] [stderr] 266 | | self.v[x] <<= 1; [INFO] [stderr] 267 | | 2 [INFO] [stderr] 268 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Annn` should have a snake case name such as `op_annn` [INFO] [stderr] --> src/cpu/mod.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | / fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] 280 | | self.i = nnn; [INFO] [stderr] 281 | | 2 [INFO] [stderr] 282 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Bnnn` should have a snake case name such as `op_bnnn` [INFO] [stderr] --> src/cpu/mod.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | / fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] 286 | | self.pc = nnn + (self.v[0] as usize); [INFO] [stderr] 287 | | 0 [INFO] [stderr] 288 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Cxkk` should have a snake case name such as `op_cxkk` [INFO] [stderr] --> src/cpu/mod.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | / fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stderr] 292 | | let rn: u8 = rand::random(); [INFO] [stderr] 293 | | self.v[x] = rn & kk; [INFO] [stderr] 294 | | 2 [INFO] [stderr] 295 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Dxyn` should have a snake case name such as `op_dxyn` [INFO] [stderr] --> src/cpu/mod.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | / fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stderr] 299 | | let mut sprite = [0; 15]; [INFO] [stderr] 300 | | [INFO] [stderr] 301 | | for j in 0..n { [INFO] [stderr] ... | [INFO] [stderr] 308 | | 2 [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `sprite` [INFO] [stderr] --> src/cpu/mod.rs:301:18 [INFO] [stderr] | [INFO] [stderr] 301 | for j in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 301 | for (j, ) in sprite.iter_mut().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Ex9E` should have a snake case name such as `op_ex9_e` [INFO] [stderr] --> src/cpu/mod.rs:312:5 [INFO] [stderr] | [INFO] [stderr] 312 | / fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stderr] 313 | | if self.keypad.get_key(self.v[x] as usize) { return 4 } [INFO] [stderr] 314 | | 2 [INFO] [stderr] 315 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_ExA1` should have a snake case name such as `op_ex_a1` [INFO] [stderr] --> src/cpu/mod.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | / fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stderr] 319 | | if self.keypad.get_key(self.v[x] as usize) { return 2 } [INFO] [stderr] 320 | | 4 [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx07` should have a snake case name such as `op_fx07` [INFO] [stderr] --> src/cpu/mod.rs:324:5 [INFO] [stderr] | [INFO] [stderr] 324 | / fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stderr] 325 | | self.v[x] = self.timer_subsystem.delay; [INFO] [stderr] 326 | | 2 [INFO] [stderr] 327 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx0A` should have a snake case name such as `op_fx0_a` [INFO] [stderr] --> src/cpu/mod.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | / fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stderr] 331 | | let keypress = self.keypad.wait_for_keypress(); [INFO] [stderr] 332 | | if keypress == 0x10 { [INFO] [stderr] 333 | | // keep pc where it is and keep executing this same instruction [INFO] [stderr] ... | [INFO] [stderr] 340 | | 2 [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx15` should have a snake case name such as `op_fx15` [INFO] [stderr] --> src/cpu/mod.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | / fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stderr] 345 | | self.timer_subsystem.delay = self.v[x]; [INFO] [stderr] 346 | | 2 [INFO] [stderr] 347 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx18` should have a snake case name such as `op_fx18` [INFO] [stderr] --> src/cpu/mod.rs:350:5 [INFO] [stderr] | [INFO] [stderr] 350 | / fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stderr] 351 | | self.timer_subsystem.sound = self.v[x]; [INFO] [stderr] 352 | | 2 [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx1E` should have a snake case name such as `op_fx1_e` [INFO] [stderr] --> src/cpu/mod.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | / fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stderr] 357 | | self.i = self.v[x] as usize + self.i; [INFO] [stderr] 358 | | 2 [INFO] [stderr] 359 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu/mod.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | self.i = self.v[x] as usize + self.i; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i += self.v[x] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx29` should have a snake case name such as `op_fx29` [INFO] [stderr] --> src/cpu/mod.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stderr] 363 | | self.i = (self.v[x] * 5) as usize; [INFO] [stderr] 364 | | 2 [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx33` should have a snake case name such as `op_fx33` [INFO] [stderr] --> src/cpu/mod.rs:368:5 [INFO] [stderr] | [INFO] [stderr] 368 | / fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stderr] 369 | | self.ram[self.i] = self.v[x] / 100; [INFO] [stderr] 370 | | self.ram[self.i + 1] = (self.v[x] % 100) / 10; [INFO] [stderr] 371 | | self.ram[self.i + 2] = self.v[x] % 10; [INFO] [stderr] 372 | | 2 [INFO] [stderr] 373 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx55` should have a snake case name such as `op_fx55` [INFO] [stderr] --> src/cpu/mod.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | / fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stderr] 377 | | // prevent out of bounds [INFO] [stderr] 378 | | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] 379 | | [INFO] [stderr] ... | [INFO] [stderr] 383 | | 2 [INFO] [stderr] 384 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu/mod.rs:380:21 [INFO] [stderr] | [INFO] [stderr] 380 | for addr in 0..end + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx65` should have a snake case name such as `op_fx65` [INFO] [stderr] --> src/cpu/mod.rs:387:5 [INFO] [stderr] | [INFO] [stderr] 387 | / fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stderr] 388 | | // prevent out of bounds [INFO] [stderr] 389 | | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] 390 | | [INFO] [stderr] ... | [INFO] [stderr] 394 | | 2 [INFO] [stderr] 395 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu/mod.rs:391:21 [INFO] [stderr] | [INFO] [stderr] 391 | for addr in 0..end + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: function `test_2nnn_and_00EE` should have a snake case name such as `test_2nnn_and_00_ee` [INFO] [stderr] --> src/cpu/tests.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / fn test_2nnn_and_00EE() { [INFO] [stderr] 69 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 70 | | [INFO] [stderr] 71 | | // jump to subroutine at 0x205 [INFO] [stderr] ... | [INFO] [stderr] 78 | | assert_eq!(chip8.sp, 0); [INFO] [stderr] 79 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_8xyE` should have a snake case name such as `test_8xy_e` [INFO] [stderr] --> src/cpu/tests.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / fn $name() { [INFO] [stderr] 145 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 146 | | chip8.v[1] = $r1; [INFO] [stderr] 147 | | chip8.v[2] = $r2; [INFO] [stderr] ... | [INFO] [stderr] 151 | | assert_eq!(chip8.v[0xF], $carry); [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 170 | test_register_op!(test_8xyE, 0x821E, 123, 20, 40, 0); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function `test_8xyE_odd` should have a snake case name such as `test_8xy_e_odd` [INFO] [stderr] --> src/cpu/tests.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / fn $name() { [INFO] [stderr] 145 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 146 | | chip8.v[1] = $r1; [INFO] [stderr] 147 | | chip8.v[2] = $r2; [INFO] [stderr] ... | [INFO] [stderr] 151 | | assert_eq!(chip8.v[0xF], $carry); [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 171 | test_register_op!(test_8xyE_odd, 0x821E, 123, 21, 42, 1); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function `test_Annn` should have a snake case name such as `test_annn` [INFO] [stderr] --> src/cpu/tests.rs:187:1 [INFO] [stderr] | [INFO] [stderr] 187 | / fn test_Annn() { [INFO] [stderr] 188 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 189 | | chip8.run_opcode(0xA20F); [INFO] [stderr] 190 | | [INFO] [stderr] 191 | | assert_eq!(chip8.i, 0x20F); [INFO] [stderr] 192 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Bnnn` should have a snake case name such as `test_bnnn` [INFO] [stderr] --> src/cpu/tests.rs:195:1 [INFO] [stderr] | [INFO] [stderr] 195 | / fn test_Bnnn() { [INFO] [stderr] 196 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 197 | | chip8.v[0] = 5; [INFO] [stderr] 198 | | chip8.run_opcode(0xB200); [INFO] [stderr] 199 | | [INFO] [stderr] 200 | | assert_eq!(chip8.pc, 0x205); [INFO] [stderr] 201 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Dxyn` should have a snake case name such as `test_dxyn` [INFO] [stderr] --> src/cpu/tests.rs:204:1 [INFO] [stderr] | [INFO] [stderr] 204 | / fn test_Dxyn() { [INFO] [stderr] 205 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 206 | | chip8.ram[0x200] = 0xF0; [INFO] [stderr] 207 | | chip8.i = 0x200; [INFO] [stderr] ... | [INFO] [stderr] 210 | | assert_eq!(chip8.display.get_pixel(0, 0), true); [INFO] [stderr] 211 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Cnnn` should have a snake case name such as `test_cnnn` [INFO] [stderr] --> src/cpu/tests.rs:214:1 [INFO] [stderr] | [INFO] [stderr] 214 | / fn test_Cnnn() { [INFO] [stderr] 215 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 216 | | chip8.v[1] = 15; [INFO] [stderr] 217 | | chip8.run_opcode(0xC100); [INFO] [stderr] 218 | | assert_eq!(chip8.v[1], 0); [INFO] [stderr] 219 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx1E` should have a snake case name such as `test_fx1_e` [INFO] [stderr] --> src/cpu/tests.rs:222:1 [INFO] [stderr] | [INFO] [stderr] 222 | / fn test_Fx1E() { [INFO] [stderr] 223 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 224 | | chip8.v[1] = 0x5; [INFO] [stderr] 225 | | chip8.i = 0x20F; [INFO] [stderr] ... | [INFO] [stderr] 228 | | assert_eq!(chip8.i, 0x214); [INFO] [stderr] 229 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx29` should have a snake case name such as `test_fx29` [INFO] [stderr] --> src/cpu/tests.rs:232:1 [INFO] [stderr] | [INFO] [stderr] 232 | / fn test_Fx29() { [INFO] [stderr] 233 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 234 | | chip8.v[1] = 5; [INFO] [stderr] 235 | | chip8.run_opcode(0xF129); [INFO] [stderr] ... | [INFO] [stderr] 244 | | assert_eq!(chip8.ram[chip8.i + 4], 0xF0); [INFO] [stderr] 245 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx33` should have a snake case name such as `test_fx33` [INFO] [stderr] --> src/cpu/tests.rs:248:1 [INFO] [stderr] | [INFO] [stderr] 248 | / fn test_Fx33() { [INFO] [stderr] 249 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 250 | | chip8.v[0] = 123; [INFO] [stderr] 251 | | chip8.i = 0x200; [INFO] [stderr] ... | [INFO] [stderr] 256 | | assert_eq!(chip8.ram[0x202], 3); [INFO] [stderr] 257 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx55` should have a snake case name such as `test_fx55` [INFO] [stderr] --> src/cpu/tests.rs:260:1 [INFO] [stderr] | [INFO] [stderr] 260 | / fn test_Fx55() { [INFO] [stderr] 261 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 262 | | chip8.v[0] = 5; [INFO] [stderr] 263 | | chip8.v[5] = 30; [INFO] [stderr] ... | [INFO] [stderr] 273 | | assert_ne!(chip8.ram[0x20F], 4); [INFO] [stderr] 274 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx65` should have a snake case name such as `test_fx65` [INFO] [stderr] --> src/cpu/tests.rs:277:1 [INFO] [stderr] | [INFO] [stderr] 277 | / fn test_Fx65() { [INFO] [stderr] 278 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 279 | | chip8.i = 0x200; [INFO] [stderr] 280 | | chip8.ram[0x200] = 1; [INFO] [stderr] ... | [INFO] [stderr] 288 | | assert_ne!(chip8.v[2], 3); [INFO] [stderr] 289 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx07` should have a snake case name such as `test_fx07` [INFO] [stderr] --> src/cpu/tests.rs:292:1 [INFO] [stderr] | [INFO] [stderr] 292 | / fn test_Fx07() { [INFO] [stderr] 293 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 294 | | chip8.timer_subsystem.delay = 50; [INFO] [stderr] 295 | | chip8.run_opcode(0xF007); [INFO] [stderr] 296 | | [INFO] [stderr] 297 | | assert_eq!(chip8.v[0], chip8.timer_subsystem.delay); [INFO] [stderr] 298 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx15_and_Fx18` should have a snake case name such as `test_fx15_and_fx18` [INFO] [stderr] --> src/cpu/tests.rs:301:1 [INFO] [stderr] | [INFO] [stderr] 301 | / fn test_Fx15_and_Fx18() { [INFO] [stderr] 302 | | let mut chip8 = Chip8::new(); [INFO] [stderr] 303 | | chip8.v[0] = 50; [INFO] [stderr] 304 | | chip8.run_opcode(0xF015); [INFO] [stderr] ... | [INFO] [stderr] 308 | | assert_eq!(chip8.timer_subsystem.sound, chip8.v[0]); [INFO] [stderr] 309 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rom.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | file.read(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `sprite` [INFO] [stderr] --> src/display.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in sprite.iter().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.89s [INFO] running `"docker" "inspect" "e000fb397720de10a8707d97feb95b11dcfa9fbc43bd6f2977e31ece7cd7b05c"` [INFO] running `"docker" "rm" "-f" "e000fb397720de10a8707d97feb95b11dcfa9fbc43bd6f2977e31ece7cd7b05c"` [INFO] [stdout] e000fb397720de10a8707d97feb95b11dcfa9fbc43bd6f2977e31ece7cd7b05c