[INFO] updating cached repository chrisrhayden/drift [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrisrhayden/drift [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrisrhayden/drift" "work/ex/clippy-test-run/sources/stable/gh/chrisrhayden/drift"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisrhayden/drift'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrisrhayden/drift" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisrhayden/drift"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisrhayden/drift'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] acd164bbbe0a1f9550debf9ab5a86fec280f7892 [INFO] sha for GitHub repo chrisrhayden/drift: acd164bbbe0a1f9550debf9ab5a86fec280f7892 [INFO] validating manifest of chrisrhayden/drift on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrisrhayden/drift on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrisrhayden/drift [INFO] finished frobbing chrisrhayden/drift [INFO] frobbed toml for chrisrhayden/drift written to work/ex/clippy-test-run/sources/stable/gh/chrisrhayden/drift/Cargo.toml [INFO] started frobbing chrisrhayden/drift [INFO] finished frobbing chrisrhayden/drift [INFO] frobbed toml for chrisrhayden/drift written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisrhayden/drift/Cargo.toml [INFO] crate chrisrhayden/drift has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrisrhayden/drift against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chrisrhayden/drift:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32f770a3561ed8e9b8f3f51b4f53e3f3a40e8dcfc7198444a027c829ff0b2df6 [INFO] running `"docker" "start" "-a" "32f770a3561ed8e9b8f3f51b4f53e3f3a40e8dcfc7198444a027c829ff0b2df6"` [INFO] [stderr] Compiling minimp3-sys v0.3.0 [INFO] [stderr] Checking ogg v0.7.0 [INFO] [stderr] Checking slice-deque v0.1.15 [INFO] [stderr] Checking alsa-sys v0.1.2 [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking lewton v0.9.3 [INFO] [stderr] Checking minimp3 v0.3.0 [INFO] [stderr] Checking rodio v0.8.1 [INFO] [stderr] Checking drift v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `daemon::Daemon` [INFO] [stderr] --> src/daemon.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | let this_app = App::new(None); [INFO] [stderr] 18 | | [INFO] [stderr] 19 | | Daemon { [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for daemon::Daemon { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/events.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | Err(_) => panic!("couldn't clone stream"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `status::CurrentStatus` [INFO] [stderr] --> src/status.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | CurrentStatus { [INFO] [stderr] 12 | | sink: None, [INFO] [stderr] 13 | | stoped: true, [INFO] [stderr] 14 | | song_name: String::from("No song is playing"), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/player.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match song.is_paused() { [INFO] [stderr] 36 | | true => song.play(), [INFO] [stderr] 37 | | false => song.pause(), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if song.is_paused() { song.play() } else { song.pause() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `daemon::Daemon` [INFO] [stderr] --> src/daemon.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | let this_app = App::new(None); [INFO] [stderr] 18 | | [INFO] [stderr] 19 | | Daemon { [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for daemon::Daemon { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/events.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | Err(_) => panic!("couldn't clone stream"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `status::CurrentStatus` [INFO] [stderr] --> src/status.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | CurrentStatus { [INFO] [stderr] 12 | | sink: None, [INFO] [stderr] 13 | | stoped: true, [INFO] [stderr] 14 | | song_name: String::from("No song is playing"), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/player.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match song.is_paused() { [INFO] [stderr] 36 | | true => song.play(), [INFO] [stderr] 37 | | false => song.pause(), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if song.is_paused() { song.play() } else { song.pause() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.59s [INFO] running `"docker" "inspect" "32f770a3561ed8e9b8f3f51b4f53e3f3a40e8dcfc7198444a027c829ff0b2df6"` [INFO] running `"docker" "rm" "-f" "32f770a3561ed8e9b8f3f51b4f53e3f3a40e8dcfc7198444a027c829ff0b2df6"` [INFO] [stdout] 32f770a3561ed8e9b8f3f51b4f53e3f3a40e8dcfc7198444a027c829ff0b2df6