[INFO] updating cached repository chriskrycho/lightning-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chriskrycho/lightning-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chriskrycho/lightning-rs" "work/ex/clippy-test-run/sources/stable/gh/chriskrycho/lightning-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chriskrycho/lightning-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chriskrycho/lightning-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chriskrycho/lightning-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chriskrycho/lightning-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4462714ec54adcdbcfe029b0238abc9c5f4ea659 [INFO] sha for GitHub repo chriskrycho/lightning-rs: 4462714ec54adcdbcfe029b0238abc9c5f4ea659 [INFO] validating manifest of chriskrycho/lightning-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chriskrycho/lightning-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chriskrycho/lightning-rs [INFO] finished frobbing chriskrycho/lightning-rs [INFO] frobbed toml for chriskrycho/lightning-rs written to work/ex/clippy-test-run/sources/stable/gh/chriskrycho/lightning-rs/Cargo.toml [INFO] started frobbing chriskrycho/lightning-rs [INFO] finished frobbing chriskrycho/lightning-rs [INFO] frobbed toml for chriskrycho/lightning-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chriskrycho/lightning-rs/Cargo.toml [INFO] crate chriskrycho/lightning-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chriskrycho/lightning-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chriskrycho/lightning-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64d0cbb7cdee33d9169d6743c5cacbde49ff9a8ba937e59b8b14852a730642af [INFO] running `"docker" "start" "-a" "64d0cbb7cdee33d9169d6743c5cacbde49ff9a8ba937e59b8b14852a730642af"` [INFO] [stderr] Compiling plist v0.3.0 [INFO] [stderr] Compiling onig_sys v69.0.0 [INFO] [stderr] Checking xml-rs v0.7.0 [INFO] [stderr] Checking quick-xml v0.4.2 [INFO] [stderr] Checking flate2 v1.0.5 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking onig v4.2.1 [INFO] [stderr] Checking syntect v3.0.2 [INFO] [stderr] Checking lightning v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/config.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/builder.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | const CONFIG_FILE_NAME: &'static str = "lightning.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/config.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | config [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/config.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let config = serde_yaml::from_str(&source).map_err(|e| format!("{:}", e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/builder.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | const CONFIG_FILE_NAME: &'static str = "lightning.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/config.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | config [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/config.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let config = serde_yaml::from_str(&source).map_err(|e| format!("{:}", e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | const TAXONOMIES: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:332:23 [INFO] [stderr] | [INFO] [stderr] 332 | const SITE_INFO: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:359:38 [INFO] [stderr] | [INFO] [stderr] 359 | const SITE_INFO_EMPTY_METADATA: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: function is never used: `load_templates` [INFO] [stderr] --> src/builder.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | fn load_templates(_site_directory: &PathBuf, _config: &Config) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/validated_types.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(unvalidated_url: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `value` [INFO] [stderr] --> src/validated_types.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn value(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or(format!("bad `site`: {:?}", site_directory)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("bad `site`: {:?}", site_directory))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:30:59 [INFO] [stderr] | [INFO] [stderr] 30 | let directories = config.directories.content.to_str().ok_or(format!( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 31 | | "bad content directory: {:?}", [INFO] [stderr] 32 | | config.directories.content [INFO] [stderr] 33 | | )); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | let directories = config.directories.content.to_str().ok_or_else(|| format!( [INFO] [stderr] 31 | "bad content directory: {:?}", [INFO] [stderr] 32 | config.directories.content [INFO] [stderr] 33 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder.rs:51:8 [INFO] [stderr] | [INFO] [stderr] 51 | if errors.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/builder.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder.rs:73:8 [INFO] [stderr] | [INFO] [stderr] 73 | if errs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/builder.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | Highlight(syntect::highlighting::Theme), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 108 | Highlight(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/builder.rs:253:42 [INFO] [stderr] | [INFO] [stderr] 253 | std::fs::create_dir(&output_dir).expect(&format!( [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 254 | | "could not create output directory {:?}", [INFO] [stderr] 255 | | &output_dir [INFO] [stderr] 256 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("could not create output directory {:?}", &output_dir))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:262:14 [INFO] [stderr] | [INFO] [stderr] 262 | .ok_or(format!("invalid file: {:?}", path))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("invalid file: {:?}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/config.rs:160:33 [INFO] [stderr] | [INFO] [stderr] 160 | .map(|value: Option<_>| value.unwrap_or(serde_yaml::Mapping::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `value.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/config.rs:222:63 [INFO] [stderr] | [INFO] [stderr] 222 | serde::Deserialize::deserialize(d).map(|value: Option<_>| value.unwrap_or(Vec::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `value.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: function is never used: `load_templates` [INFO] [stderr] --> src/builder.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | fn load_templates(_site_directory: &PathBuf, _config: &Config) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/validated_types.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(unvalidated_url: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `value` [INFO] [stderr] --> src/validated_types.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn value(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or(format!("bad `site`: {:?}", site_directory)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("bad `site`: {:?}", site_directory))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:30:59 [INFO] [stderr] | [INFO] [stderr] 30 | let directories = config.directories.content.to_str().ok_or(format!( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 31 | | "bad content directory: {:?}", [INFO] [stderr] 32 | | config.directories.content [INFO] [stderr] 33 | | )); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | let directories = config.directories.content.to_str().ok_or_else(|| format!( [INFO] [stderr] 31 | "bad content directory: {:?}", [INFO] [stderr] 32 | config.directories.content [INFO] [stderr] 33 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder.rs:51:8 [INFO] [stderr] | [INFO] [stderr] 51 | if errors.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/builder.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builder.rs:73:8 [INFO] [stderr] | [INFO] [stderr] 73 | if errs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/builder.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | Highlight(syntect::highlighting::Theme), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 108 | Highlight(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/builder.rs:253:42 [INFO] [stderr] | [INFO] [stderr] 253 | std::fs::create_dir(&output_dir).expect(&format!( [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 254 | | "could not create output directory {:?}", [INFO] [stderr] 255 | | &output_dir [INFO] [stderr] 256 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("could not create output directory {:?}", &output_dir))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/builder.rs:262:14 [INFO] [stderr] | [INFO] [stderr] 262 | .ok_or(format!("invalid file: {:?}", path))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("invalid file: {:?}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/config.rs:160:33 [INFO] [stderr] | [INFO] [stderr] 160 | .map(|value: Option<_>| value.unwrap_or(serde_yaml::Mapping::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `value.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/config.rs:222:63 [INFO] [stderr] | [INFO] [stderr] 222 | serde::Deserialize::deserialize(d).map(|value: Option<_>| value.unwrap_or(Vec::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `value.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/bin/lx/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | local: _, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Build { site_directory, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/bin/lx/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | Command::Create { template: _ } => lightning::create(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Create { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/bin/lx/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | write!(std::io::stderr(), "failure: {}", reason).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/bin/lx/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | local: _, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Build { site_directory, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/bin/lx/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | Command::Create { template: _ } => lightning::create(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Create { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/bin/lx/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | write!(std::io::stderr(), "failure: {}", reason).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.57s [INFO] running `"docker" "inspect" "64d0cbb7cdee33d9169d6743c5cacbde49ff9a8ba937e59b8b14852a730642af"` [INFO] running `"docker" "rm" "-f" "64d0cbb7cdee33d9169d6743c5cacbde49ff9a8ba937e59b8b14852a730642af"` [INFO] [stdout] 64d0cbb7cdee33d9169d6743c5cacbde49ff9a8ba937e59b8b14852a730642af