[INFO] updating cached repository chrisj/piston-tests [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrisj/piston-tests [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrisj/piston-tests" "work/ex/clippy-test-run/sources/stable/gh/chrisj/piston-tests"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisj/piston-tests'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrisj/piston-tests" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisj/piston-tests"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisj/piston-tests'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0aafc5f8cfe8c75c5f555b0aebe6047494b14f5 [INFO] sha for GitHub repo chrisj/piston-tests: b0aafc5f8cfe8c75c5f555b0aebe6047494b14f5 [INFO] validating manifest of chrisj/piston-tests on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrisj/piston-tests on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrisj/piston-tests [INFO] finished frobbing chrisj/piston-tests [INFO] frobbed toml for chrisj/piston-tests written to work/ex/clippy-test-run/sources/stable/gh/chrisj/piston-tests/Cargo.toml [INFO] started frobbing chrisj/piston-tests [INFO] finished frobbing chrisj/piston-tests [INFO] frobbed toml for chrisj/piston-tests written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisj/piston-tests/Cargo.toml [INFO] crate chrisj/piston-tests has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrisj/piston-tests against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chrisj/piston-tests:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ee2205bcfe96a759aab0fd60dc888a8730262373df6eb58728434acef7e8243 [INFO] running `"docker" "start" "-a" "3ee2205bcfe96a759aab0fd60dc888a8730262373df6eb58728434acef7e8243"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `spinning-square`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Compiling libc v0.2.17 [INFO] [stderr] Compiling phf_shared v0.7.19 [INFO] [stderr] Compiling serde v0.8.17 [INFO] [stderr] Checking lazy_static v0.2.1 [INFO] [stderr] Checking odds v0.2.24 [INFO] [stderr] Compiling xml-rs v0.3.4 [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking pistoncore-input v0.14.0 [INFO] [stderr] Compiling phf v0.7.19 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking x11-dl v2.11.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.4 [INFO] [stderr] Compiling rand v0.3.14 [INFO] [stderr] Checking nodrop v0.1.8 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking arrayvec v0.3.20 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Checking pistoncore-window v0.23.0 [INFO] [stderr] Compiling phf_generator v0.7.19 [INFO] [stderr] Compiling wayland-scanner v0.5.11 [INFO] [stderr] Compiling gl_generator v0.5.2 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Compiling phf_codegen v0.7.19 [INFO] [stderr] Checking pistoncore-event_loop v0.26.0 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking piston v0.26.0 [INFO] [stderr] Compiling wayland-client v0.5.12 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Compiling glutin v0.6.2 [INFO] [stderr] Compiling serde_json v0.8.3 [INFO] [stderr] Checking image v0.10.3 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking piston2d-opengl_graphics v0.36.1 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.31.0 [INFO] [stderr] Checking getting-started v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: static variable `lastTime` should have an upper case name such as `LAST_TIME` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | static mut lastTime: f64 = 0.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:38:58 [INFO] [stderr] | [INFO] [stderr] 38 | let (x, y) = ((position + 500.0 * args.ext_dt) % args.width as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:58:32 [INFO] [stderr] | [INFO] [stderr] 58 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | / match button { [INFO] [stderr] 119 | | Button::Keyboard(key) => { [INFO] [stderr] 120 | | println!("pressed: {:?}", key); [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | _ => {} [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Button::Keyboard(key) = button { [INFO] [stderr] 119 | println!("pressed: {:?}", key); [INFO] [stderr] 120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: static variable `lastTime` should have an upper case name such as `LAST_TIME` [INFO] [stderr] --> src/main.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | static mut lastTime: f64 = 0.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:38:58 [INFO] [stderr] | [INFO] [stderr] 38 | let (x, y) = ((position + 500.0 * args.ext_dt) % args.width as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:39:23 [INFO] [stderr] | [INFO] [stderr] 39 | (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:58:32 [INFO] [stderr] | [INFO] [stderr] 58 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | / match button { [INFO] [stderr] 119 | | Button::Keyboard(key) => { [INFO] [stderr] 120 | | println!("pressed: {:?}", key); [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | _ => {} [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Button::Keyboard(key) = button { [INFO] [stderr] 119 | println!("pressed: {:?}", key); [INFO] [stderr] 120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.33s [INFO] running `"docker" "inspect" "3ee2205bcfe96a759aab0fd60dc888a8730262373df6eb58728434acef7e8243"` [INFO] running `"docker" "rm" "-f" "3ee2205bcfe96a759aab0fd60dc888a8730262373df6eb58728434acef7e8243"` [INFO] [stdout] 3ee2205bcfe96a759aab0fd60dc888a8730262373df6eb58728434acef7e8243