[INFO] updating cached repository chrishutchinson/train-delay-logger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrishutchinson/train-delay-logger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrishutchinson/train-delay-logger" "work/ex/clippy-test-run/sources/stable/gh/chrishutchinson/train-delay-logger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrishutchinson/train-delay-logger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrishutchinson/train-delay-logger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrishutchinson/train-delay-logger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrishutchinson/train-delay-logger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eea8d08a0f333c7f1d60d7a3c61e4925cf015c57 [INFO] sha for GitHub repo chrishutchinson/train-delay-logger: eea8d08a0f333c7f1d60d7a3c61e4925cf015c57 [INFO] validating manifest of chrishutchinson/train-delay-logger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrishutchinson/train-delay-logger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrishutchinson/train-delay-logger [INFO] finished frobbing chrishutchinson/train-delay-logger [INFO] frobbed toml for chrishutchinson/train-delay-logger written to work/ex/clippy-test-run/sources/stable/gh/chrishutchinson/train-delay-logger/Cargo.toml [INFO] started frobbing chrishutchinson/train-delay-logger [INFO] finished frobbing chrishutchinson/train-delay-logger [INFO] frobbed toml for chrishutchinson/train-delay-logger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrishutchinson/train-delay-logger/Cargo.toml [INFO] crate chrishutchinson/train-delay-logger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrishutchinson/train-delay-logger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chrishutchinson/train-delay-logger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a83f3b582da4559bc2f6df413d0a6eb69053b87a327960412788f346cee7a11d [INFO] running `"docker" "start" "-a" "a83f3b582da4559bc2f6df413d0a6eb69053b87a327960412788f346cee7a11d"` [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.5 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking train-delay-logger v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/service_query/mod.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / writeln!( [INFO] [stderr] 83 | | ::std::io::stderr(), [INFO] [stderr] 84 | | "Please provide the SERVICE_USERNAME environment variable" [INFO] [stderr] 85 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/service_query/mod.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / writeln!( [INFO] [stderr] 94 | | ::std::io::stderr(), [INFO] [stderr] 95 | | "Please provide the SERVICE_PASSWORD environment variable" [INFO] [stderr] 96 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/train/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / writeln!( [INFO] [stderr] 43 | | ::std::io::stderr(), [INFO] [stderr] 44 | | "Please provide the SERVICE_USERNAME environment variable" [INFO] [stderr] 45 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/train/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / writeln!( [INFO] [stderr] 54 | | ::std::io::stderr(), [INFO] [stderr] 55 | | "Please provide the SERVICE_PASSWORD environment variable" [INFO] [stderr] 56 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/train/mod.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | self.service_attributes_details.locations.iter().nth(0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/train/mod.rs:82:54 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn get_destination_details(&self, destination: &String) -> Option<&TrainLocation> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/train/mod.rs:87:45 [INFO] [stderr] | [INFO] [stderr] 87 | .find(|location| location.location == destination.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destination` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/train/mod.rs:90:46 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn get_total_delay(&self, destination: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/train/mod.rs:106:67 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn was_delayed_on_arrival(&self, minutes: i64, destination: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:17:40 [INFO] [stderr] | [INFO] [stderr] 17 | fn parse_args_into_service_query(args: &Vec) -> ServiceQuery { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / writeln!( [INFO] [stderr] 33 | | std::io::stderr(), [INFO] [stderr] 34 | | "Usage: train-delay DEPARTURE_STATION DESTINATION_STATION DEPARTURE_HOUR ARRIVAL_HOUR" [INFO] [stderr] 35 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / writeln!( [INFO] [stderr] 44 | | std::io::stderr(), [INFO] [stderr] 45 | | "Unable to load data for the given arguments" [INFO] [stderr] 46 | | ).unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | writeln!(std::io::stderr(), "Unable to load data for train service").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/service_query/mod.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / writeln!( [INFO] [stderr] 83 | | ::std::io::stderr(), [INFO] [stderr] 84 | | "Please provide the SERVICE_USERNAME environment variable" [INFO] [stderr] 85 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/service_query/mod.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / writeln!( [INFO] [stderr] 94 | | ::std::io::stderr(), [INFO] [stderr] 95 | | "Please provide the SERVICE_PASSWORD environment variable" [INFO] [stderr] 96 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/train/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / writeln!( [INFO] [stderr] 43 | | ::std::io::stderr(), [INFO] [stderr] 44 | | "Please provide the SERVICE_USERNAME environment variable" [INFO] [stderr] 45 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/train/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / writeln!( [INFO] [stderr] 54 | | ::std::io::stderr(), [INFO] [stderr] 55 | | "Please provide the SERVICE_PASSWORD environment variable" [INFO] [stderr] 56 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/train/mod.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | self.service_attributes_details.locations.iter().nth(0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/train/mod.rs:82:54 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn get_destination_details(&self, destination: &String) -> Option<&TrainLocation> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/train/mod.rs:87:45 [INFO] [stderr] | [INFO] [stderr] 87 | .find(|location| location.location == destination.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `destination` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/train/mod.rs:90:46 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn get_total_delay(&self, destination: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/train/mod.rs:106:67 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn was_delayed_on_arrival(&self, minutes: i64, destination: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:17:40 [INFO] [stderr] | [INFO] [stderr] 17 | fn parse_args_into_service_query(args: &Vec) -> ServiceQuery { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / writeln!( [INFO] [stderr] 33 | | std::io::stderr(), [INFO] [stderr] 34 | | "Usage: train-delay DEPARTURE_STATION DESTINATION_STATION DEPARTURE_HOUR ARRIVAL_HOUR" [INFO] [stderr] 35 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / writeln!( [INFO] [stderr] 44 | | std::io::stderr(), [INFO] [stderr] 45 | | "Unable to load data for the given arguments" [INFO] [stderr] 46 | | ).unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | writeln!(std::io::stderr(), "Unable to load data for train service").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.96s [INFO] running `"docker" "inspect" "a83f3b582da4559bc2f6df413d0a6eb69053b87a327960412788f346cee7a11d"` [INFO] running `"docker" "rm" "-f" "a83f3b582da4559bc2f6df413d0a6eb69053b87a327960412788f346cee7a11d"` [INFO] [stdout] a83f3b582da4559bc2f6df413d0a6eb69053b87a327960412788f346cee7a11d