[INFO] updating cached repository chrisduerr/userstyles-manager [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrisduerr/userstyles-manager [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrisduerr/userstyles-manager" "work/ex/clippy-test-run/sources/stable/gh/chrisduerr/userstyles-manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisduerr/userstyles-manager'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrisduerr/userstyles-manager" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisduerr/userstyles-manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisduerr/userstyles-manager'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 28e4dbce2ade39a0e98208f9f8b4f1b85ee6a818 [INFO] sha for GitHub repo chrisduerr/userstyles-manager: 28e4dbce2ade39a0e98208f9f8b4f1b85ee6a818 [INFO] validating manifest of chrisduerr/userstyles-manager on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrisduerr/userstyles-manager on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrisduerr/userstyles-manager [INFO] finished frobbing chrisduerr/userstyles-manager [INFO] frobbed toml for chrisduerr/userstyles-manager written to work/ex/clippy-test-run/sources/stable/gh/chrisduerr/userstyles-manager/Cargo.toml [INFO] started frobbing chrisduerr/userstyles-manager [INFO] finished frobbing chrisduerr/userstyles-manager [INFO] frobbed toml for chrisduerr/userstyles-manager written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisduerr/userstyles-manager/Cargo.toml [INFO] crate chrisduerr/userstyles-manager has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrisduerr/userstyles-manager against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chrisduerr/userstyles-manager:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df2024fb8ba4be5dede1b38ce9efd55b7ab3e60b499fba550ef0df56700ed627 [INFO] running `"docker" "start" "-a" "df2024fb8ba4be5dede1b38ce9efd55b7ab3e60b499fba550ef0df56700ed627"` [INFO] [stderr] Compiling gcc v0.3.52 [INFO] [stderr] Checking json v0.11.9 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Compiling openssl-sys v0.9.17 [INFO] [stderr] Compiling backtrace-sys v0.1.12 [INFO] [stderr] Compiling openssl v0.9.17 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.7.2 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking userstyles-manager v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/get_style.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | id: 146771, [INFO] [stderr] | ^^^^^^ help: consider: `146_771` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/update_style_settings.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | style.id = 146771; [INFO] [stderr] | ^^^^^^ help: consider: `146_771` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/update_style_settings.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | style.id = 107653; [INFO] [stderr] | ^^^^^^ help: consider: `107_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/update_style_settings.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | style.id = 146771; [INFO] [stderr] | ^^^^^^ help: consider: `146_771` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/update_style_settings.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | style.id = 146771; [INFO] [stderr] | ^^^^^^ help: consider: `146_771` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/update_style_settings.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(style.id, 146771); [INFO] [stderr] | ^^^^^^ help: consider: `146_771` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/update_style_settings.rs:91:16 [INFO] [stderr] | [INFO] [stderr] 91 | style.id = 146775; [INFO] [stderr] | ^^^^^^ help: consider: `146_775` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:221:16 [INFO] [stderr] | [INFO] [stderr] 221 | if setting_option["default"] == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `setting_option["default"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:221:16 [INFO] [stderr] | [INFO] [stderr] 221 | if setting_option["default"] == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `setting_option["default"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.74s [INFO] running `"docker" "inspect" "df2024fb8ba4be5dede1b38ce9efd55b7ab3e60b499fba550ef0df56700ed627"` [INFO] running `"docker" "rm" "-f" "df2024fb8ba4be5dede1b38ce9efd55b7ab3e60b499fba550ef0df56700ed627"` [INFO] [stdout] df2024fb8ba4be5dede1b38ce9efd55b7ab3e60b499fba550ef0df56700ed627