[INFO] updating cached repository chrisduerr/rum [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrisduerr/rum [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrisduerr/rum" "work/ex/clippy-test-run/sources/stable/gh/chrisduerr/rum"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisduerr/rum'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrisduerr/rum" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisduerr/rum"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisduerr/rum'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 475bc72519a91342b2452959a661595880fa5032 [INFO] sha for GitHub repo chrisduerr/rum: 475bc72519a91342b2452959a661595880fa5032 [INFO] validating manifest of chrisduerr/rum on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrisduerr/rum on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrisduerr/rum [INFO] finished frobbing chrisduerr/rum [INFO] frobbed toml for chrisduerr/rum written to work/ex/clippy-test-run/sources/stable/gh/chrisduerr/rum/Cargo.toml [INFO] started frobbing chrisduerr/rum [INFO] finished frobbing chrisduerr/rum [INFO] frobbed toml for chrisduerr/rum written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisduerr/rum/Cargo.toml [INFO] crate chrisduerr/rum has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrisduerr/rum against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chrisduerr/rum:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 052aab41bab69911856befa49c73e018c2d2419ee379c47d61123fc0a30bddeb [INFO] running `"docker" "start" "-a" "052aab41bab69911856befa49c73e018c2d2419ee379c47d61123fc0a30bddeb"` [INFO] [stderr] Compiling backtrace-sys v0.1.12 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking openssl-sys v0.9.17 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking openssl v0.9.17 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking userstyles v0.1.3 [INFO] [stderr] Checking rum v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/add.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/list.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/remove.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | styles: styles, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `styles` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/update.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/update.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/add.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/list.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/remove.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | styles: styles, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `styles` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/update.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/update.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:247:20 [INFO] [stderr] | [INFO] [stderr] 247 | let mut path = env::home_dir().ok_or("Unable to locate home directory")?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:319:20 [INFO] [stderr] | [INFO] [stderr] 319 | let mut path = env::home_dir().ok_or("Unable to find home directory.")?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/config.rs:1:41 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{self, BufRead, BufReader, Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:247:20 [INFO] [stderr] | [INFO] [stderr] 247 | let mut path = env::home_dir().ok_or("Unable to locate home directory")?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:319:20 [INFO] [stderr] | [INFO] [stderr] 319 | let mut path = env::home_dir().ok_or("Unable to find home directory.")?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/userstyle.rs:129:28 [INFO] [stderr] | [INFO] [stderr] 129 | let allow_custom = !(setting.setting_type == "dropdown"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `setting.setting_type != "dropdown"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: function is never used: `config_exists` [INFO] [stderr] --> src/config.rs:193:1 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn config_exists() -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `create_config` [INFO] [stderr] --> src/config.rs:220:1 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn create_config() -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/userstyle.rs:129:28 [INFO] [stderr] | [INFO] [stderr] 129 | let allow_custom = !(setting.setting_type == "dropdown"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `setting.setting_type != "dropdown"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/userstyle.rs:289:16 [INFO] [stderr] | [INFO] [stderr] 289 | assert_eq!(settings.get("ACCENTCOLOR").unwrap(), "#0F9D58"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&settings["ACCENTCOLOR"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/userstyle.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | settings.get("CONVOBG").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&settings["CONVOBG"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/userstyle.rs:361:16 [INFO] [stderr] | [INFO] [stderr] 361 | let elem = map.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/userstyle.rs:380:16 [INFO] [stderr] | [INFO] [stderr] 380 | let elem = map.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.81s [INFO] running `"docker" "inspect" "052aab41bab69911856befa49c73e018c2d2419ee379c47d61123fc0a30bddeb"` [INFO] running `"docker" "rm" "-f" "052aab41bab69911856befa49c73e018c2d2419ee379c47d61123fc0a30bddeb"` [INFO] [stdout] 052aab41bab69911856befa49c73e018c2d2419ee379c47d61123fc0a30bddeb