[INFO] updating cached repository chrisdone/pid1-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/chrisdone/pid1-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/chrisdone/pid1-rust" "work/ex/clippy-test-run/sources/stable/gh/chrisdone/pid1-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisdone/pid1-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/chrisdone/pid1-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisdone/pid1-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisdone/pid1-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 871d2c7240761d1c5efdd48799e2515a0e2470fb
[INFO] sha for GitHub repo chrisdone/pid1-rust: 871d2c7240761d1c5efdd48799e2515a0e2470fb
[INFO] validating manifest of chrisdone/pid1-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chrisdone/pid1-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chrisdone/pid1-rust
[INFO] finished frobbing chrisdone/pid1-rust
[INFO] frobbed toml for chrisdone/pid1-rust written to work/ex/clippy-test-run/sources/stable/gh/chrisdone/pid1-rust/Cargo.toml
[INFO] started frobbing chrisdone/pid1-rust
[INFO] finished frobbing chrisdone/pid1-rust
[INFO] frobbed toml for chrisdone/pid1-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisdone/pid1-rust/Cargo.toml
[INFO] crate chrisdone/pid1-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chrisdone/pid1-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chrisdone/pid1-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1398ed48242995312c2d4b655151aa4be0c04713c91bfe738b1afcc7b1d996e7
[INFO] running `"docker" "start" "-a" "1398ed48242995312c2d4b655151aa4be0c04713c91bfe738b1afcc7b1d996e7"`
[INFO] [stderr]     Checking users v0.7.0
[INFO] [stderr]     Checking chan v0.1.23
[INFO] [stderr]     Checking chan-signal v0.3.2
[INFO] [stderr]     Checking pid1-rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 |         env: env,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `env`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 |         env: env,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `env`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:137:13
[INFO] [stderr]     |
[INFO] [stderr] 137 |             return Ok(RunResult::Signalled(signal));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RunResult::Signalled(signal))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:141:25
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 None => return Ok(RunResult::ChanEnded),
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RunResult::ChanEnded)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:143:21
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     return exit_result.map(RunResult::Exited).map_err(RunError::Process)
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `exit_result.map(RunResult::Exited).map_err(RunError::Process)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:137:13
[INFO] [stderr]     |
[INFO] [stderr] 137 |             return Ok(RunResult::Signalled(signal));
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RunResult::Signalled(signal))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:141:25
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 None => return Ok(RunResult::ChanEnded),
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RunResult::ChanEnded)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:143:21
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     return exit_result.map(RunResult::Exited).map_err(RunError::Process)
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `exit_result.map(RunResult::Exited).map_err(RunError::Process)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.28s
[INFO] running `"docker" "inspect" "1398ed48242995312c2d4b655151aa4be0c04713c91bfe738b1afcc7b1d996e7"`
[INFO] running `"docker" "rm" "-f" "1398ed48242995312c2d4b655151aa4be0c04713c91bfe738b1afcc7b1d996e7"`
[INFO] [stdout] 1398ed48242995312c2d4b655151aa4be0c04713c91bfe738b1afcc7b1d996e7