[INFO] updating cached repository chrisballinger/chip_led-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chrisballinger/chip_led-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chrisballinger/chip_led-rs" "work/ex/clippy-test-run/sources/stable/gh/chrisballinger/chip_led-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chrisballinger/chip_led-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chrisballinger/chip_led-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisballinger/chip_led-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisballinger/chip_led-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ece1402d975fce6c8248e608f9fdeb15e81b42f [INFO] sha for GitHub repo chrisballinger/chip_led-rs: 7ece1402d975fce6c8248e608f9fdeb15e81b42f [INFO] validating manifest of chrisballinger/chip_led-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chrisballinger/chip_led-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chrisballinger/chip_led-rs [INFO] finished frobbing chrisballinger/chip_led-rs [INFO] frobbed toml for chrisballinger/chip_led-rs written to work/ex/clippy-test-run/sources/stable/gh/chrisballinger/chip_led-rs/Cargo.toml [INFO] started frobbing chrisballinger/chip_led-rs [INFO] finished frobbing chrisballinger/chip_led-rs [INFO] frobbed toml for chrisballinger/chip_led-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chrisballinger/chip_led-rs/Cargo.toml [INFO] crate chrisballinger/chip_led-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chrisballinger/chip_led-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chrisballinger/chip_led-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd820c792cd9a9b26181e87efaa8ead9069b1050cfc8d15b1b66906f9a96262e [INFO] running `"docker" "start" "-a" "bd820c792cd9a9b26181e87efaa8ead9069b1050cfc8d15b1b66906f9a96262e"` [INFO] [stderr] Checking ctrlc v3.1.0 [INFO] [stderr] Checking sysfs_gpio v0.5.2 [INFO] [stderr] Checking chip-gpio v0.1.1 [INFO] [stderr] Checking chip_led v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | fn reset_pins(pins: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Pin]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | fn blink_pin(pin: &Pin, duration: u64) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | fn blink_pins(pins: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Pin]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | fn reset_pins(pins: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Pin]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | fn blink_pin(pin: &Pin, duration: u64) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | fn blink_pins(pins: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Pin]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.18s [INFO] running `"docker" "inspect" "bd820c792cd9a9b26181e87efaa8ead9069b1050cfc8d15b1b66906f9a96262e"` [INFO] running `"docker" "rm" "-f" "bd820c792cd9a9b26181e87efaa8ead9069b1050cfc8d15b1b66906f9a96262e"` [INFO] [stdout] bd820c792cd9a9b26181e87efaa8ead9069b1050cfc8d15b1b66906f9a96262e