[INFO] updating cached repository chris007de/flex [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chris007de/flex [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chris007de/flex" "work/ex/clippy-test-run/sources/stable/gh/chris007de/flex"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chris007de/flex'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chris007de/flex" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chris007de/flex"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chris007de/flex'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8127a50ab92a8d6218fbce31dd8a57a5c8c8091f [INFO] sha for GitHub repo chris007de/flex: 8127a50ab92a8d6218fbce31dd8a57a5c8c8091f [INFO] validating manifest of chris007de/flex on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chris007de/flex on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chris007de/flex [INFO] finished frobbing chris007de/flex [INFO] frobbed toml for chris007de/flex written to work/ex/clippy-test-run/sources/stable/gh/chris007de/flex/Cargo.toml [INFO] started frobbing chris007de/flex [INFO] finished frobbing chris007de/flex [INFO] frobbed toml for chris007de/flex written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chris007de/flex/Cargo.toml [INFO] crate chris007de/flex has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chris007de/flex against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chris007de/flex:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e67593b8bd349e9742157ed65074002f6ae61a41d76bebe9518f1faaba952e0a [INFO] running `"docker" "start" "-a" "e67593b8bd349e9742157ed65074002f6ae61a41d76bebe9518f1faaba952e0a"` [INFO] [stderr] Checking bit_reverse v0.1.7 [INFO] [stderr] Checking flex v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/fiw.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | cycle_number: cycle_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cycle_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/fiw.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | frame_number: frame_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/fiw.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | repeat_paging: repeat_paging, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repeat_paging` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/fiw.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | low_traffic_flags: low_traffic_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `low_traffic_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/biw3.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/biw3.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | day: day, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/biw4.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | hour: hour, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/biw4.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | minute: minute, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/address_short.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(CWAddressShort { capcode: capcode }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `capcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/vector_alpha.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | message_start: message_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/vector_alpha.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | message_words: message_words, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | message_continued_flag: message_continued_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_continued_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | fragment_number: fragment_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fragment_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/fiw.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | cycle_number: cycle_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cycle_number` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | message_number: message_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] --> src/codewords/message_alpha_header.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | retrieval_flag: retrieval_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `retrieval_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | mail_drop_flag: mail_drop_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mail_drop_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/fiw.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | frame_number: frame_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/fiw.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | repeat_paging: repeat_paging, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repeat_paging` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/fiw.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | low_traffic_flags: low_traffic_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `low_traffic_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/biw3.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/biw3.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | day: day, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(Message{frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/biw4.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | hour: hour, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | msgtype: msgtype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `msgtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:37:27 [INFO] [stderr] | [INFO] [stderr] 37 | capcode: capcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `capcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/biw4.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | minute: minute, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | data: data}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/address_short.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(CWAddressShort { capcode: capcode }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `capcode` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/frame.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(Frame{fiw: fiw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fiw` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/vector_alpha.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | message_start: message_start, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_start` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | num_cws: num_cws, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `num_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/vector_alpha.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | message_words: message_words, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_words` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | message_continued_flag: message_continued_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_continued_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | fragment_number: fragment_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fragment_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | message_number: message_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | retrieval_flag: retrieval_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `retrieval_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_header.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | mail_drop_flag: mail_drop_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mail_drop_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codewords/message_alpha.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(Message{frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | msgtype: msgtype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `msgtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:37:27 [INFO] [stderr] | [INFO] [stderr] 37 | capcode: capcode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `capcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | data: data}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(Frame{fiw: fiw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fiw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | num_cws: num_cws, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `num_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return bytes.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bytes.to_vec()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return msgs.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `msgs.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return biw_cws; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `biw_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/blocks.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | let biw3 = BIW3::new(23, 05, 1999).unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 70 | let biw3 = BIW3::new(23, 5, 1999).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 70 | let biw3 = BIW3::new(23, 0o5, 1999).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return addr_cws; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `addr_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return (vector_cws, content_cws); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(vector_cws, content_cws)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return filled_cws; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `filled_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | filled_cws.push(0xFFFFFFFF); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return output_data; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:134:71 [INFO] [stderr] | [INFO] [stderr] 134 | let backshifted_input = (masked_input >> bit_index) & 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/fiw.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw1.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw2.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw3.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return day >= 1 && day <= 31; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `day >= 1 && day <= 31` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw3.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return month >= 1 && month <= 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `month >= 1 && month <= 12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw3.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return year >= 1994 && year <= 2025; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `year >= 1994 && year <= 2025` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw3.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw4.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return minute <= 59; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `minute <= 59` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw4.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return hour <= 23; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hour <= 23` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw4.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/address_short.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | if capcode >= 0x0001 && capcode <= 0x1EA7FF { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001E_A7FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/address_short.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/vector_alpha.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_header.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | / return Ok(CWMessageAlphaSignature { [INFO] [stderr] 17 | | signature: signature, [INFO] [stderr] 18 | | chars: chars.to_vec(), [INFO] [stderr] 19 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Ok(CWMessageAlphaSignature { [INFO] [stderr] 17 | signature: signature, [INFO] [stderr] 18 | chars: chars.to_vec(), [INFO] [stderr] 19 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | return Err("Alphanumeric Message Signature: Invalid Parameter."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Alphanumeric Message Signature: Invalid Parameter.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_content.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Ok(CWMessageAlphaContent { chars: chars.to_vec() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(CWMessageAlphaContent { chars: chars.to_vec() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_content.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / return Ok(CWMessageAlpha { [INFO] [stderr] 37 | | header: header, [INFO] [stderr] 38 | | signature: signature, [INFO] [stderr] 39 | | content: content, [INFO] [stderr] 40 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | Ok(CWMessageAlpha { [INFO] [stderr] 37 | header: header, [INFO] [stderr] 38 | signature: signature, [INFO] [stderr] 39 | content: content, [INFO] [stderr] 40 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return sum & 0x7F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum & 0x7F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | sum ^= 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return fragment_check & 0x3FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fragment_check & 0x3FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | fragment_check ^= 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return cws; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:87:48 [INFO] [stderr] | [INFO] [stderr] 87 | cws[0] = apply_bch_and_parity(header & 0x1FFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/fourbit_checksum.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return codeword | sum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `codeword | sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/apply_bch_and_parity.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/bch_calculator.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return codeword | crc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `codeword | crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/bch_calculator.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | if (crc & (0x00000001 << i)) != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/parity.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return odd; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `odd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/parity.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return ones; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `ones` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let parity_bit = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | *codeword = *codeword & 0x7FFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / return Ok(Message{frame: frame, [INFO] [stderr] 36 | | msgtype: msgtype, [INFO] [stderr] 37 | | capcode: capcode, [INFO] [stderr] 38 | | data: data}); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | Ok(Message{frame: frame, [INFO] [stderr] 36 | msgtype: msgtype, [INFO] [stderr] 37 | capcode: capcode, [INFO] [stderr] 38 | data: data}) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return size; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return CapcodeType::Invalid; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CapcodeType::Invalid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:66:44 [INFO] [stderr] | [INFO] [stderr] 66 | if capcode >= 0x0001 && capcode <= 0x1EA7FF { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001E_A7FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | const PATTERN_BS1 : u32 = 0x55555555; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5555_5555` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | const PATTERN_A1 : u32 = 0x9C9ACF1E; // A1: 1600 / 2 FM [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9C9A_CF1E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / return Ok(Frame{fiw: fiw, [INFO] [stderr] 39 | | num_cws: num_cws, [INFO] [stderr] 40 | | send_time, [INFO] [stderr] 41 | | msgs: Vec::new()}); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Frame{fiw: fiw, [INFO] [stderr] 39 | num_cws: num_cws, [INFO] [stderr] 40 | send_time, [INFO] [stderr] 41 | msgs: Vec::new()}) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return sync1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `sync1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame.rs:49:66 [INFO] [stderr] | [INFO] [stderr] 49 | sync1.extend_from_slice(&Frame::u32_to_4_u8(PATTERN_A1 ^ 0xFFFFFFFF)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return sync2; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `sync2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return header; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return Err("could not add message to frame"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("could not add message to frame")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return MAX_CODEWORDS_PER_BLOCK_1600 - self.num_cws; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MAX_CODEWORDS_PER_BLOCK_1600 - self.num_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return (cycle,frame as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(cycle,frame as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return array; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return array; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return bytes.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bytes.to_vec()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return msgs.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `msgs.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return biw_cws; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `biw_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/blocks.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | let biw3 = BIW3::new(23, 05, 1999).unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 70 | let biw3 = BIW3::new(23, 5, 1999).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 70 | let biw3 = BIW3::new(23, 0o5, 1999).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return addr_cws; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `addr_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return (vector_cws, content_cws); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(vector_cws, content_cws)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return filled_cws; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `filled_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | filled_cws.push(0xFFFFFFFF); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blocks.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return output_data; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:134:71 [INFO] [stderr] | [INFO] [stderr] 134 | let backshifted_input = (masked_input >> bit_index) & 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:153:29 [INFO] [stderr] | [INFO] [stderr] 153 | assert_eq!(cws[0] & 0x1FFFF0, 0x000800); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:153:39 [INFO] [stderr] | [INFO] [stderr] 153 | assert_eq!(cws[0] & 0x1FFFF0, 0x000800); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | assert_eq!(cws[0] & 0x1FFFF0, 0x001700); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:160:39 [INFO] [stderr] | [INFO] [stderr] 160 | assert_eq!(cws[0] & 0x1FFFF0, 0x001700); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_1700` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:169:29 [INFO] [stderr] | [INFO] [stderr] 169 | assert_eq!(cws[0] & 0x1FFFFF, 0x8001); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:178:36 [INFO] [stderr] | [INFO] [stderr] 178 | assert_eq!(vector_cws[0] & 0x1FFFF0, 0x00C1D0); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:178:46 [INFO] [stderr] | [INFO] [stderr] 178 | assert_eq!(vector_cws[0] & 0x1FFFF0, 0x00C1D0); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_C1D0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:210:36 [INFO] [stderr] | [INFO] [stderr] 210 | let test_data: [u32; 8] = [0x00000200, 0, 0, 0, 0, 0, 0, 0]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/blocks.rs:220:36 [INFO] [stderr] | [INFO] [stderr] 220 | let test_data: [u32; 8] = [0xaaaaaaaa; 8]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xaaaa_aaaa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/fiw.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/fiw.rs:53:41 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(fiw.get_codeword() & 0x1FFFF0, 0x103C30); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/fiw.rs:53:51 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(fiw.get_codeword() & 0x1FFFF0, 0x103C30); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_3C30` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/fiw.rs:74:40 [INFO] [stderr] | [INFO] [stderr] 74 | assert_eq!(fiw.get_codeword(), 0xE4A06B3B); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xE4A0_6B3B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw1.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw1.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(biw1.get_codeword() & 0x1FFFF0, 0x19F2A0); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw1.rs:53:52 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(biw1.get_codeword() & 0x1FFFF0, 0x19F2A0); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0019_F2A0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw1.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | assert_eq!(biw1.get_codeword(), 0x19400807); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1940_0807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw2.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw2.rs:38:42 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(biw2.get_codeword() & 0x1FFFF0, 0x1FF080); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw2.rs:38:52 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(biw2.get_codeword() & 0x1FFFF0, 0x1FF080); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_F080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw3.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return day >= 1 && day <= 31; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `day >= 1 && day <= 31` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw3.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return month >= 1 && month <= 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `month >= 1 && month <= 12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw3.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return year >= 1994 && year <= 2025; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `year >= 1994 && year <= 2025` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw3.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw3.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(biw3.get_codeword() & 0x1FFFF0, 0x19F290); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw3.rs:58:52 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(biw3.get_codeword() & 0x1FFFF0, 0x19F290); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0019_F290` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw4.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return minute <= 59; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `minute <= 59` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw4.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return hour <= 23; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hour <= 23` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/biw4.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw4.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | assert_eq!(biw4.get_codeword() & 0x1FFFF0, 0x1FBBA0); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw4.rs:54:52 [INFO] [stderr] | [INFO] [stderr] 54 | assert_eq!(biw4.get_codeword() & 0x1FFFF0, 0x1FBBA0); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_BBA0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw4.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | assert_eq!(biw4.get_codeword() & 0x1FFFF0, 0x13BBA0); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw4.rs:60:52 [INFO] [stderr] | [INFO] [stderr] 60 | assert_eq!(biw4.get_codeword() & 0x1FFFF0, 0x13BBA0); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0013_BBA0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw4.rs:66:42 [INFO] [stderr] | [INFO] [stderr] 66 | assert_eq!(biw4.get_codeword() & 0x1FFFF0, 0x000020); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/biw4.rs:66:52 [INFO] [stderr] | [INFO] [stderr] 66 | assert_eq!(biw4.get_codeword() & 0x1FFFF0, 0x000020); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/address_short.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | if capcode >= 0x0001 && capcode <= 0x1EA7FF { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001E_A7FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/address_short.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/address_short.rs:36:54 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(cw_address_short.get_codeword() & 0x1FFFFF, 0x008001) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/address_short.rs:36:64 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(cw_address_short.get_codeword() & 0x1FFFFF, 0x008001) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_8001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/address_short.rs:42:53 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(cw_address_short.get_codeword(), 0xBF008204) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBF00_8204` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/address_short.rs:47:52 [INFO] [stderr] | [INFO] [stderr] 47 | let cw_address_short = CWAddressShort::new(0x1EA7FF).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001E_A7FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/address_short.rs:48:53 [INFO] [stderr] | [INFO] [stderr] 48 | assert_eq!(cw_address_short.get_codeword(), 0x13DF27FF) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x13DF_27FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/address_short.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(CWAddressShort::new(0x1EA800).is_err(), true); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001E_A800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/vector_alpha.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/vector_alpha.rs:42:56 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(cw_vector_alphanum.get_codeword() & 0x1FFFF0, 0x0041D0) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/vector_alpha.rs:42:66 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(cw_vector_alphanum.get_codeword() & 0x1FFFF0, 0x0041D0) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_41D0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/vector_alpha.rs:48:56 [INFO] [stderr] | [INFO] [stderr] 48 | assert_eq!(cw_vector_alphanum.get_codeword() & 0x1FFFF0, 0x156BD0) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/vector_alpha.rs:48:66 [INFO] [stderr] | [INFO] [stderr] 48 | assert_eq!(cw_vector_alphanum.get_codeword() & 0x1FFFF0, 0x156BD0) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0015_6BD0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/vector_alpha.rs:54:55 [INFO] [stderr] | [INFO] [stderr] 54 | assert_eq!(cw_vector_alphanum.get_codeword(), 0xD98C41D1) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD98C_41D1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_header.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha_header.rs:56:48 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(msg_header.get_codeword() & 0x1FFA00, 0x0FF800); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FA00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha_header.rs:56:58 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(msg_header.get_codeword() & 0x1FFA00, 0x0FF800); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x000F_F800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha_header.rs:62:48 [INFO] [stderr] | [INFO] [stderr] 62 | assert_eq!(msg_header.get_codeword() & 0x1FFA00, 0x2F800); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FA00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | / return Ok(CWMessageAlphaSignature { [INFO] [stderr] 17 | | signature: signature, [INFO] [stderr] 18 | | chars: chars.to_vec(), [INFO] [stderr] 19 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Ok(CWMessageAlphaSignature { [INFO] [stderr] 17 | signature: signature, [INFO] [stderr] 18 | chars: chars.to_vec(), [INFO] [stderr] 19 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | return Err("Alphanumeric Message Signature: Invalid Parameter."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Alphanumeric Message Signature: Invalid Parameter.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:45:51 [INFO] [stderr] | [INFO] [stderr] 45 | assert_eq!(msg_signature.get_codeword() & 0x1FFFFF, 0x8E17F); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_content.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Ok(CWMessageAlphaContent { chars: chars.to_vec() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(CWMessageAlphaContent { chars: chars.to_vec() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha_content.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha_content.rs:38:47 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(msg_chars.get_codeword() & 0x1FFFFF, 0x151C2); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / return Ok(CWMessageAlpha { [INFO] [stderr] 37 | | header: header, [INFO] [stderr] 38 | | signature: signature, [INFO] [stderr] 39 | | content: content, [INFO] [stderr] 40 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | Ok(CWMessageAlpha { [INFO] [stderr] 37 | header: header, [INFO] [stderr] 38 | signature: signature, [INFO] [stderr] 39 | content: content, [INFO] [stderr] 40 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return sum & 0x7F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum & 0x7F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | sum ^= 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return fragment_check & 0x3FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fragment_check & 0x3FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | fragment_check ^= 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codewords/message_alpha.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return cws; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:87:48 [INFO] [stderr] | [INFO] [stderr] 87 | cws[0] = apply_bch_and_parity(header & 0x1FFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:128:51 [INFO] [stderr] | [INFO] [stderr] 128 | assert_eq!(msg_alpha.get_codewords()[0] & 0x1FFA00, 0x02F800); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FA00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:128:61 [INFO] [stderr] | [INFO] [stderr] 128 | assert_eq!(msg_alpha.get_codewords()[0] & 0x1FFA00, 0x02F800); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0002_F800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:130:51 [INFO] [stderr] | [INFO] [stderr] 130 | assert_eq!(msg_alpha.get_codewords()[1] & 0x1FFF80, 0x1D6380); // Gu [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FF80` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:130:61 [INFO] [stderr] | [INFO] [stderr] 130 | assert_eq!(msg_alpha.get_codewords()[1] & 0x1FFF80, 0x1D6380); // Gu [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001D_6380` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:131:51 [INFO] [stderr] | [INFO] [stderr] 131 | assert_eq!(msg_alpha.get_codewords()[2] & 0x1FFFFF, 0x1975F2); // rke [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:131:61 [INFO] [stderr] | [INFO] [stderr] 131 | assert_eq!(msg_alpha.get_codewords()[2] & 0x1FFFFF, 0x1975F2); // rke [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0019_75F2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:132:51 [INFO] [stderr] | [INFO] [stderr] 132 | assert_eq!(msg_alpha.get_codewords()[3] & 0x1FFFFF, 0x1879EE); // nsa [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:132:61 [INFO] [stderr] | [INFO] [stderr] 132 | assert_eq!(msg_alpha.get_codewords()[3] & 0x1FFFFF, 0x1879EE); // nsa [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0018_79EE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:133:51 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(msg_alpha.get_codewords()[4] & 0x1FFFFF, 0x1D30EC); // lat [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:133:61 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(msg_alpha.get_codewords()[4] & 0x1FFFFF, 0x1D30EC); // lat [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001D_30EC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:140:51 [INFO] [stderr] | [INFO] [stderr] 140 | assert_eq!(msg_alpha.get_codewords()[1] & 0x1FFF80, 0x1D6380); // Gu [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FF80` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:140:61 [INFO] [stderr] | [INFO] [stderr] 140 | assert_eq!(msg_alpha.get_codewords()[1] & 0x1FFF80, 0x1D6380); // Gu [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001D_6380` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:141:51 [INFO] [stderr] | [INFO] [stderr] 141 | assert_eq!(msg_alpha.get_codewords()[2] & 0x1FFFFF, 0x1975F2); // rke [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:141:61 [INFO] [stderr] | [INFO] [stderr] 141 | assert_eq!(msg_alpha.get_codewords()[2] & 0x1FFFFF, 0x1975F2); // rke [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0019_75F2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:142:51 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(msg_alpha.get_codewords()[3] & 0x1FFFFF, 0x00C1EE); // nETXETX [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:142:61 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(msg_alpha.get_codewords()[3] & 0x1FFFFF, 0x00C1EE); // nETXETX [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_C1EE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:147:53 [INFO] [stderr] | [INFO] [stderr] 147 | assert_eq!(CWMessageAlpha::get_bitgroup_sum(0x1FFFFF), 0x21D); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:152:30 [INFO] [stderr] | [INFO] [stderr] 152 | let codewords = vec![0x1FFFFF]; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | let codewords = vec![0x1FFFFF, 0x1FFFFF]; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codewords/message_alpha.rs:158:40 [INFO] [stderr] | [INFO] [stderr] 158 | let codewords = vec![0x1FFFFF, 0x1FFFFF]; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/fourbit_checksum.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return codeword | sum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `codeword | sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/fourbit_checksum.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | let test_codeword: u32 = 0x00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/fourbit_checksum.rs:21:33 [INFO] [stderr] | [INFO] [stderr] 21 | let expected_crc: u32 = 0x0000000F; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/fourbit_checksum.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | let test_codeword: u32 = 0x001FFFF0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x001F_FFF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/fourbit_checksum.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | let expected_crc: u32 = 0x001FFFF2; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x001F_FFF2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/fourbit_checksum.rs:40:34 [INFO] [stderr] | [INFO] [stderr] 40 | let test_codeword: u32 = 0x00139C50; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0013_9C50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/fourbit_checksum.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | let expected_crc: u32 = 0x00139C51; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0013_9C51` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/apply_bch_and_parity.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return cw; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/bch_calculator.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return codeword | crc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `codeword | crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/bch_calculator.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | if (crc & (0x00000001 << i)) != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/bch_calculator.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | let test_codeword: u32 = 0x001FFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/bch_calculator.rs:29:28 [INFO] [stderr] | [INFO] [stderr] 29 | let expected_crc = 0x7FFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/bch_calculator.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | let test_codeword: u32 = 0x1D40CD; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001D_40CD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/bch_calculator.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | let expected_crc: u32 = 0x1EDD40CD; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1EDD_40CD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/bch_calculator.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | let expected_crc: u32 = 0x38C87523; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x38C8_7523` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/parity.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return odd; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `odd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/helper/parity.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return ones; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `ones` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let parity_bit = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | *codeword = *codeword & 0x7FFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | let mut test_data: u32 = 0x7FFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:57:31 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(test_data, 0xFFFFFFFF); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:63:34 [INFO] [stderr] | [INFO] [stderr] 63 | let mut test_data: u32 = 0x00000003; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | let mut test_data: u32 = 0x80000003; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(test_data, 0x00000003); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | let mut test_data: u32 = 0x80000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/helper/parity.rs:87:31 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(test_data, 0x80000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / return Ok(Message{frame: frame, [INFO] [stderr] 36 | | msgtype: msgtype, [INFO] [stderr] 37 | | capcode: capcode, [INFO] [stderr] 38 | | data: data}); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | Ok(Message{frame: frame, [INFO] [stderr] 36 | msgtype: msgtype, [INFO] [stderr] 37 | capcode: capcode, [INFO] [stderr] 38 | data: data}) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return size; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return CapcodeType::Invalid; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CapcodeType::Invalid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:66:44 [INFO] [stderr] | [INFO] [stderr] 66 | if capcode >= 0x0001 && capcode <= 0x1EA7FF { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001E_A7FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:108:46 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(Message::get_capcode_type(0x1EB000), CapcodeType::Invalid); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001E_B000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | const PATTERN_BS1 : u32 = 0x55555555; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5555_5555` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | const PATTERN_A1 : u32 = 0x9C9ACF1E; // A1: 1600 / 2 FM [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9C9A_CF1E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / return Ok(Frame{fiw: fiw, [INFO] [stderr] 39 | | num_cws: num_cws, [INFO] [stderr] 40 | | send_time, [INFO] [stderr] 41 | | msgs: Vec::new()}); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Frame{fiw: fiw, [INFO] [stderr] 39 | num_cws: num_cws, [INFO] [stderr] 40 | send_time, [INFO] [stderr] 41 | msgs: Vec::new()}) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return sync1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `sync1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame.rs:49:66 [INFO] [stderr] | [INFO] [stderr] 49 | sync1.extend_from_slice(&Frame::u32_to_4_u8(PATTERN_A1 ^ 0xFFFFFFFF)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return sync2; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `sync2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return header; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return Err("could not add message to frame"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("could not add message to frame")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return MAX_CODEWORDS_PER_BLOCK_1600 - self.num_cws; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MAX_CODEWORDS_PER_BLOCK_1600 - self.num_cws` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return (cycle,frame as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(cycle,frame as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return array; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return array; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame.rs:186:39 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(Frame::u32_to_4_u8(0x12345678), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn get_bytes(msgs: &Vec, send_time: bool) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Message]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | fn count_address_cws(msgs: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Message]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/blocks.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / let mut startword_addresses = 0; [INFO] [stderr] 49 | | if send_time { [INFO] [stderr] 50 | | startword_addresses = 3; // offset because of BIW 2,3 and 4 [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let startword_addresses = if send_time { 3 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | fn get_addr_cws(msgs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Message]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:89:15 [INFO] [stderr] | [INFO] [stderr] 89 | msgs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Message]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:111:32 [INFO] [stderr] | [INFO] [stderr] 111 | fn fill_up_block_1600(cws: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `bit_index` is used to index `output_data` [INFO] [stderr] --> src/blocks.rs:130:26 [INFO] [stderr] | [INFO] [stderr] 130 | for bit_index in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 130 | for (bit_index, ) in output_data.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `codeword` is used to index `input` [INFO] [stderr] --> src/blocks.rs:131:29 [INFO] [stderr] | [INFO] [stderr] 131 | for codeword in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 131 | for (codeword, ) in input.iter().enumerate().take(8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/blocks.rs:133:36 [INFO] [stderr] | [INFO] [stderr] 133 | let masked_input = &input[codeword] & input_mask; [INFO] [stderr] | ----------------^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `input[codeword]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/blocks.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | output_data[bit_index] = output_data[bit_index] ^ bit_to_write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_data[bit_index] ^= bit_to_write` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:30:15 [INFO] [stderr] | [INFO] [stderr] 30 | cw |= ((self.chars[0] & 0x7F) as u32) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[0] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | cw |= ((self.chars[1] & 0x7F) as u32) << 14; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[1] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_content.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | cw |= (self.chars[0] & 0x7F) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[0] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_content.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | cw |= ((self.chars[1] & 0x7F) as u32) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[1] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_content.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | cw |= ((self.chars[2] & 0x7F) as u32) << 14; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[2] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | sum += chr as u32 & 0x7F; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(chr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/codewords/message_alpha.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | fn calculate_fragment_check(codewords: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/helper/parity.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *codeword = *codeword | parity_bit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*codeword |= parity_bit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/helper/parity.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | *codeword = *codeword & 0x7FFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*codeword &= 0x7FFFFFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | tmp |= (PATTERN_BS2 & 0xF) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(PATTERN_BS2 & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:57:16 [INFO] [stderr] | [INFO] [stderr] 57 | tmp |= (PATTERN_C as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(PATTERN_C)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | tmp |= (((PATTERN_BS2 ^ 0xF) & 0xF) as u32) << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((PATTERN_BS2 ^ 0xF) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | tmp |= ((PATTERN_C ^ 0xFFFF) as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(PATTERN_C ^ 0xFFFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | let frame = ((minutes % 4) * 60 + seconds) as f64 / 1.875; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((minutes % 4) * 60 + seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn get_bytes(msgs: &Vec, send_time: bool) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Message]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | fn count_address_cws(msgs: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Message]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/blocks.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / let mut startword_addresses = 0; [INFO] [stderr] 49 | | if send_time { [INFO] [stderr] 50 | | startword_addresses = 3; // offset because of BIW 2,3 and 4 [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let startword_addresses = if send_time { 3 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | fn get_addr_cws(msgs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Message]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:89:15 [INFO] [stderr] | [INFO] [stderr] 89 | msgs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Message]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/blocks.rs:111:32 [INFO] [stderr] | [INFO] [stderr] 111 | fn fill_up_block_1600(cws: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `bit_index` is used to index `output_data` [INFO] [stderr] --> src/blocks.rs:130:26 [INFO] [stderr] | [INFO] [stderr] 130 | for bit_index in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 130 | for (bit_index, ) in output_data.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `codeword` is used to index `input` [INFO] [stderr] --> src/blocks.rs:131:29 [INFO] [stderr] | [INFO] [stderr] 131 | for codeword in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 131 | for (codeword, ) in input.iter().enumerate().take(8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/blocks.rs:133:36 [INFO] [stderr] | [INFO] [stderr] 133 | let masked_input = &input[codeword] & input_mask; [INFO] [stderr] | ----------------^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `input[codeword]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/blocks.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | output_data[bit_index] = output_data[bit_index] ^ bit_to_write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_data[bit_index] ^= bit_to_write` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:30:15 [INFO] [stderr] | [INFO] [stderr] 30 | cw |= ((self.chars[0] & 0x7F) as u32) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[0] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_signature.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | cw |= ((self.chars[1] & 0x7F) as u32) << 14; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[1] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_content.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | cw |= (self.chars[0] & 0x7F) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[0] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_content.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | cw |= ((self.chars[1] & 0x7F) as u32) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[1] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha_content.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | cw |= ((self.chars[2] & 0x7F) as u32) << 14; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chars[2] & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/codewords/message_alpha.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | sum += chr as u32 & 0x7F; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(chr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/codewords/message_alpha.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | fn calculate_fragment_check(codewords: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/helper/parity.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *codeword = *codeword | parity_bit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*codeword |= parity_bit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/helper/parity.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | *codeword = *codeword & 0x7FFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*codeword &= 0x7FFFFFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | tmp |= (PATTERN_BS2 & 0xF) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(PATTERN_BS2 & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:57:16 [INFO] [stderr] | [INFO] [stderr] 57 | tmp |= (PATTERN_C as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(PATTERN_C)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | tmp |= (((PATTERN_BS2 ^ 0xF) & 0xF) as u32) << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((PATTERN_BS2 ^ 0xF) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | tmp |= ((PATTERN_C ^ 0xFFFF) as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(PATTERN_C ^ 0xFFFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/frame.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | let frame = ((minutes % 4) * 60 + seconds) as f64 / 1.875; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((minutes % 4) * 60 + seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok((in_file, out_file, mode)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((in_file, out_file, mode))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return reversed_bytes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reversed_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | / if msg_vec[i].frame == frame_nr { [INFO] [stderr] 178 | | if msg_vec[i].get_num_of_message_codewords().unwrap() < frame.space_left() { [INFO] [stderr] 179 | | frame.add_message(&msg_vec[i]).unwrap(); [INFO] [stderr] 180 | | msg_vec.remove(i); [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 177 | if msg_vec[i].frame == frame_nr && msg_vec[i].get_num_of_message_codewords().unwrap() < frame.space_left() { [INFO] [stderr] 178 | frame.add_message(&msg_vec[i]).unwrap(); [INFO] [stderr] 179 | msg_vec.remove(i); [INFO] [stderr] 180 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok((in_file, out_file, mode)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((in_file, out_file, mode))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return reversed_bytes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reversed_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | / if msg_vec[i].frame == frame_nr { [INFO] [stderr] 178 | | if msg_vec[i].get_num_of_message_codewords().unwrap() < frame.space_left() { [INFO] [stderr] 179 | | frame.add_message(&msg_vec[i]).unwrap(); [INFO] [stderr] 180 | | msg_vec.remove(i); [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 177 | if msg_vec[i].frame == frame_nr && msg_vec[i].get_num_of_message_codewords().unwrap() < frame.space_left() { [INFO] [stderr] 178 | frame.add_message(&msg_vec[i]).unwrap(); [INFO] [stderr] 179 | msg_vec.remove(i); [INFO] [stderr] 180 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | fn parse_arguments(args: &Vec) -> Result<(String, String, OperationMode), &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / let mut out_file = "/dev/null".to_string(); [INFO] [stderr] 77 | | if matches.opt_present("o") { [INFO] [stderr] 78 | | out_file = matches.opt_str("o").unwrap(); [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let out_file = if matches.opt_present("o") { matches.opt_str("o").unwrap() } else { "/dev/null".to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:129:33 [INFO] [stderr] | [INFO] [stderr] 129 | fn write_frames_to_file(frames: &Vec, filename: &String) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:129:56 [INFO] [stderr] | [INFO] [stderr] 129 | fn write_frames_to_file(frames: &Vec, filename: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:134:24 [INFO] [stderr] | [INFO] [stderr] 134 | fn frames_hton(frames: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `msg_vec` [INFO] [stderr] --> src/main.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | for i in 0..msg_vec.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 176 | for (i, ) in msg_vec.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | fn parse_arguments(args: &Vec) -> Result<(String, String, OperationMode), &'static str> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / let mut out_file = "/dev/null".to_string(); [INFO] [stderr] 77 | | if matches.opt_present("o") { [INFO] [stderr] 78 | | out_file = matches.opt_str("o").unwrap(); [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let out_file = if matches.opt_present("o") { matches.opt_str("o").unwrap() } else { "/dev/null".to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:129:33 [INFO] [stderr] | [INFO] [stderr] 129 | fn write_frames_to_file(frames: &Vec, filename: &String) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:129:56 [INFO] [stderr] | [INFO] [stderr] 129 | fn write_frames_to_file(frames: &Vec, filename: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:134:24 [INFO] [stderr] | [INFO] [stderr] 134 | fn frames_hton(frames: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `msg_vec` [INFO] [stderr] --> src/main.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | for i in 0..msg_vec.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 176 | for (i, ) in msg_vec.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.05s [INFO] running `"docker" "inspect" "e67593b8bd349e9742157ed65074002f6ae61a41d76bebe9518f1faaba952e0a"` [INFO] running `"docker" "rm" "-f" "e67593b8bd349e9742157ed65074002f6ae61a41d76bebe9518f1faaba952e0a"` [INFO] [stdout] e67593b8bd349e9742157ed65074002f6ae61a41d76bebe9518f1faaba952e0a