[INFO] updating cached repository chr4/cache_warmer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chr4/cache_warmer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chr4/cache_warmer" "work/ex/clippy-test-run/sources/stable/gh/chr4/cache_warmer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chr4/cache_warmer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chr4/cache_warmer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chr4/cache_warmer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chr4/cache_warmer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5e7e1416909fbe5ad0e40f0db9fcc533573bac97 [INFO] sha for GitHub repo chr4/cache_warmer: 5e7e1416909fbe5ad0e40f0db9fcc533573bac97 [INFO] validating manifest of chr4/cache_warmer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chr4/cache_warmer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chr4/cache_warmer [INFO] finished frobbing chr4/cache_warmer [INFO] frobbed toml for chr4/cache_warmer written to work/ex/clippy-test-run/sources/stable/gh/chr4/cache_warmer/Cargo.toml [INFO] started frobbing chr4/cache_warmer [INFO] finished frobbing chr4/cache_warmer [INFO] frobbed toml for chr4/cache_warmer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chr4/cache_warmer/Cargo.toml [INFO] crate chr4/cache_warmer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chr4/cache_warmer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chr4/cache_warmer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6508e31c7b0e09dda3c075c4748450ad480c94a6a1e864fca202f4d5505e335a [INFO] running `"docker" "start" "-a" "6508e31c7b0e09dda3c075c4748450ad480c94a6a1e864fca202f4d5505e335a"` [INFO] [stderr] Compiling openssl-sys v0.9.25 [INFO] [stderr] Checking pbr v1.0.0 [INFO] [stderr] Checking hyper v0.11.18 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking cache_warmer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | cookies: cookies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cookies` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | user_agent: user_agent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_agent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | cookies: cookies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cookies` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | user_agent: user_agent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_agent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/cli.rs:107:67 [INFO] [stderr] | [INFO] [stderr] 107 | let cookie_args = values_t!(args.values_of("cookie"), String).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/loader.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | if self.captcha_string.len() > 0 && html.contains(&self.captcha_string) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.captcha_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/loader.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | / match captcha_found.first() { [INFO] [stderr] 202 | | Some(_) => true, [INFO] [stderr] 203 | | None => false, [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ help: try this: `captcha_found.first().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:45 [INFO] [stderr] | [INFO] [stderr] 87 | duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/cli.rs:107:67 [INFO] [stderr] | [INFO] [stderr] 107 | let cookie_args = values_t!(args.values_of("cookie"), String).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/loader.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | if self.captcha_string.len() > 0 && html.contains(&self.captcha_string) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.captcha_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/loader.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | / match captcha_found.first() { [INFO] [stderr] 202 | | Some(_) => true, [INFO] [stderr] 203 | | None => false, [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ help: try this: `captcha_found.first().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:45 [INFO] [stderr] | [INFO] [stderr] 87 | duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.19s [INFO] running `"docker" "inspect" "6508e31c7b0e09dda3c075c4748450ad480c94a6a1e864fca202f4d5505e335a"` [INFO] running `"docker" "rm" "-f" "6508e31c7b0e09dda3c075c4748450ad480c94a6a1e864fca202f4d5505e335a"` [INFO] [stdout] 6508e31c7b0e09dda3c075c4748450ad480c94a6a1e864fca202f4d5505e335a