[INFO] updating cached repository cholcombe973/ceph_rpc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cholcombe973/ceph_rpc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cholcombe973/ceph_rpc" "work/ex/clippy-test-run/sources/stable/gh/cholcombe973/ceph_rpc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cholcombe973/ceph_rpc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cholcombe973/ceph_rpc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cholcombe973/ceph_rpc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cholcombe973/ceph_rpc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b43ef6fc5eebee2482f3eed7947e1e9c45248db9 [INFO] sha for GitHub repo cholcombe973/ceph_rpc: b43ef6fc5eebee2482f3eed7947e1e9c45248db9 [INFO] validating manifest of cholcombe973/ceph_rpc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cholcombe973/ceph_rpc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cholcombe973/ceph_rpc [INFO] finished frobbing cholcombe973/ceph_rpc [INFO] frobbed toml for cholcombe973/ceph_rpc written to work/ex/clippy-test-run/sources/stable/gh/cholcombe973/ceph_rpc/Cargo.toml [INFO] started frobbing cholcombe973/ceph_rpc [INFO] finished frobbing cholcombe973/ceph_rpc [INFO] frobbed toml for cholcombe973/ceph_rpc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cholcombe973/ceph_rpc/Cargo.toml [INFO] crate cholcombe973/ceph_rpc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cholcombe973/ceph_rpc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cholcombe973/ceph_rpc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98f7acaa422bfaf6b2b72d3bcd4876049add736bbcdbac6768a840ce88e24f82 [INFO] running `"docker" "start" "-a" "98f7acaa422bfaf6b2b72d3bcd4876049add736bbcdbac6768a840ce88e24f82"` [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking nom v3.2.0 [INFO] [stderr] Checking ceph-rpc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Cursor` [INFO] [stderr] --> src/primitives.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Cursor, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ReadBytesExt` [INFO] [stderr] --> src/primitives.rs:7:37 [INFO] [stderr] | [INFO] [stderr] 7 | use self::byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitives.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | static AUTH_ENC_MAGIC: u64 = 0xff009cad8826aa55; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xff00_9cad_8826_aa55` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cursor` [INFO] [stderr] --> src/primitives.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Cursor, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ReadBytesExt` [INFO] [stderr] --> src/primitives.rs:7:37 [INFO] [stderr] | [INFO] [stderr] 7 | use self::byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitives.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | static AUTH_ENC_MAGIC: u64 = 0xff009cad8826aa55; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xff00_9cad_8826_aa55` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `CEPH_AES_IV` [INFO] [stderr] --> src/primitives.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | static CEPH_AES_IV: &'static str = "cephsageyudagreg"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `AUTH_ENC_MAGIC` [INFO] [stderr] --> src/primitives.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | static AUTH_ENC_MAGIC: u64 = 0xff009cad8826aa55; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/primitives.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match self { [INFO] [stderr] 128 | | &Some(ref t) => { [INFO] [stderr] 129 | | buff.write_u8(1)?; [INFO] [stderr] 130 | | t.serialize(buff)?; [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *self { [INFO] [stderr] 128 | Some(ref t) => { [INFO] [stderr] 129 | buff.write_u8(1)?; [INFO] [stderr] 130 | t.serialize(buff)?; [INFO] [stderr] 131 | } [INFO] [stderr] 132 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/primitives.rs:140:26 [INFO] [stderr] | [INFO] [stderr] 140 | impl Serialize for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 140 | impl Serialize for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `CEPH_AES_IV` [INFO] [stderr] --> src/primitives.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | static CEPH_AES_IV: &'static str = "cephsageyudagreg"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `AUTH_ENC_MAGIC` [INFO] [stderr] --> src/primitives.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | static AUTH_ENC_MAGIC: u64 = 0xff009cad8826aa55; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/primitives.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match self { [INFO] [stderr] 128 | | &Some(ref t) => { [INFO] [stderr] 129 | | buff.write_u8(1)?; [INFO] [stderr] 130 | | t.serialize(buff)?; [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *self { [INFO] [stderr] 128 | Some(ref t) => { [INFO] [stderr] 129 | buff.write_u8(1)?; [INFO] [stderr] 130 | t.serialize(buff)?; [INFO] [stderr] 131 | } [INFO] [stderr] 132 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/primitives.rs:140:26 [INFO] [stderr] | [INFO] [stderr] 140 | impl Serialize for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 140 | impl Serialize for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.02s [INFO] running `"docker" "inspect" "98f7acaa422bfaf6b2b72d3bcd4876049add736bbcdbac6768a840ce88e24f82"` [INFO] running `"docker" "rm" "-f" "98f7acaa422bfaf6b2b72d3bcd4876049add736bbcdbac6768a840ce88e24f82"` [INFO] [stdout] 98f7acaa422bfaf6b2b72d3bcd4876049add736bbcdbac6768a840ce88e24f82