[INFO] updating cached repository chippers/rndc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chippers/rndc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chippers/rndc" "work/ex/clippy-test-run/sources/stable/gh/chippers/rndc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chippers/rndc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chippers/rndc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chippers/rndc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chippers/rndc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91b56fb5a0531101d5e049e870aa02cb0e80c35e [INFO] sha for GitHub repo chippers/rndc: 91b56fb5a0531101d5e049e870aa02cb0e80c35e [INFO] validating manifest of chippers/rndc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chippers/rndc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chippers/rndc [INFO] finished frobbing chippers/rndc [INFO] frobbed toml for chippers/rndc written to work/ex/clippy-test-run/sources/stable/gh/chippers/rndc/Cargo.toml [INFO] started frobbing chippers/rndc [INFO] finished frobbing chippers/rndc [INFO] frobbed toml for chippers/rndc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chippers/rndc/Cargo.toml [INFO] crate chippers/rndc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chippers/rndc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chippers/rndc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e105fc81a862817bd0fcd6abdaf287d5c39ebc4a8a9b9f336a9f1789c60f7a78 [INFO] running `"docker" "start" "-a" "e105fc81a862817bd0fcd6abdaf287d5c39ebc4a8a9b9f336a9f1789c60f7a78"` [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking rndc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/package/mod.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / fn fda_pkg_to_ndc<'a>(b: &'a [u8]) -> NDC<'a> { [INFO] [stderr] 42 | | let p: Vec<&str> = str::from_utf8(b).unwrap().split('-').collect(); [INFO] [stderr] 43 | | NDC { [INFO] [stderr] 44 | | full: ndc_parts_to_ndc(p[0], p[1], p[2]), [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/package/mod.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / fn fda_description_to_description<'a>(b: &'a [u8]) -> Option<&'a str> { [INFO] [stderr] 68 | | match b.len() { [INFO] [stderr] 69 | | 0 => None, [INFO] [stderr] 70 | | _ => Some(str::from_utf8(b).unwrap()) [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/package/mod.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn new(&ref bs: &ByteRecord) -> Package { [INFO] [stderr] | ^^^^^^^ help: try removing the `&ref` part and just keep: `bs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/package/mod.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / fn fda_pkg_to_ndc<'a>(b: &'a [u8]) -> NDC<'a> { [INFO] [stderr] 42 | | let p: Vec<&str> = str::from_utf8(b).unwrap().split('-').collect(); [INFO] [stderr] 43 | | NDC { [INFO] [stderr] 44 | | full: ndc_parts_to_ndc(p[0], p[1], p[2]), [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/package/mod.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / fn fda_description_to_description<'a>(b: &'a [u8]) -> Option<&'a str> { [INFO] [stderr] 68 | | match b.len() { [INFO] [stderr] 69 | | 0 => None, [INFO] [stderr] 70 | | _ => Some(str::from_utf8(b).unwrap()) [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/package/mod.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn new(&ref bs: &ByteRecord) -> Package { [INFO] [stderr] | ^^^^^^^ help: try removing the `&ref` part and just keep: `bs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.28s [INFO] running `"docker" "inspect" "e105fc81a862817bd0fcd6abdaf287d5c39ebc4a8a9b9f336a9f1789c60f7a78"` [INFO] running `"docker" "rm" "-f" "e105fc81a862817bd0fcd6abdaf287d5c39ebc4a8a9b9f336a9f1789c60f7a78"` [INFO] [stdout] e105fc81a862817bd0fcd6abdaf287d5c39ebc4a8a9b9f336a9f1789c60f7a78