[INFO] updating cached repository chemist/rsync-resource
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/chemist/rsync-resource
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/chemist/rsync-resource" "work/ex/clippy-test-run/sources/stable/gh/chemist/rsync-resource"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chemist/rsync-resource'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/chemist/rsync-resource" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chemist/rsync-resource"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chemist/rsync-resource'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cd3026aba04e10fd6e4fa2a9ac631c669504587f
[INFO] sha for GitHub repo chemist/rsync-resource: cd3026aba04e10fd6e4fa2a9ac631c669504587f
[INFO] validating manifest of chemist/rsync-resource on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chemist/rsync-resource on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chemist/rsync-resource
[INFO] finished frobbing chemist/rsync-resource
[INFO] frobbed toml for chemist/rsync-resource written to work/ex/clippy-test-run/sources/stable/gh/chemist/rsync-resource/Cargo.toml
[INFO] started frobbing chemist/rsync-resource
[INFO] finished frobbing chemist/rsync-resource
[INFO] frobbed toml for chemist/rsync-resource written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chemist/rsync-resource/Cargo.toml
[INFO] crate chemist/rsync-resource has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chemist/rsync-resource against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chemist/rsync-resource:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0dfccd7c3f6f6409f7e7a3b85f1e1623617567186241bb12a7d494441e1d3e41
[INFO] running `"docker" "start" "-a" "0dfccd7c3f6f6409f7e7a3b85f1e1623617567186241bb12a7d494441e1d3e41"`
[INFO] [stderr]     Checking rsync-resource v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:157:5
[INFO] [stderr]     |
[INFO] [stderr] 157 |     return out;
[INFO] [stderr]     |     ^^^^^^^^^^^ help: remove `return` as shown: `out`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:166:9
[INFO] [stderr]     |
[INFO] [stderr] 166 |         return Out::Empty;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Out::Empty`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:185:9
[INFO] [stderr]     |
[INFO] [stderr] 185 |         return out;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `out`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:215:5
[INFO] [stderr]     |
[INFO] [stderr] 215 |     return Out::Many(result)
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Out::Many(result)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:157:5
[INFO] [stderr]     |
[INFO] [stderr] 157 |     return out;
[INFO] [stderr]     |     ^^^^^^^^^^^ help: remove `return` as shown: `out`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:166:9
[INFO] [stderr]     |
[INFO] [stderr] 166 |         return Out::Empty;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Out::Empty`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:185:9
[INFO] [stderr]     |
[INFO] [stderr] 185 |         return out;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `out`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:215:5
[INFO] [stderr]     |
[INFO] [stderr] 215 |     return Out::Many(result)
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Out::Many(result)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:82:9
[INFO] [stderr]    |
[INFO] [stderr] 82 | /         match self {
[INFO] [stderr] 83 | |             &Out::Empty => Json::Object(BTreeMap::new()),
[INFO] [stderr] 84 | |             &Out::One(ref v) => {
[INFO] [stderr] 85 | |                 let mut d = BTreeMap::new();
[INFO] [stderr] ...  |
[INFO] [stderr] 89 | |             &Out::Many(ref v) => v.to_json(),
[INFO] [stderr] 90 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 82 |         match *self {
[INFO] [stderr] 83 |             Out::Empty => Json::Object(BTreeMap::new()),
[INFO] [stderr] 84 |             Out::One(ref v) => {
[INFO] [stderr] 85 |                 let mut d = BTreeMap::new();
[INFO] [stderr] 86 |                 d.insert("version".to_string(), v.to_json());
[INFO] [stderr] 87 |                 Json::Object(d)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/main.rs:118:21
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let out = match bin_name.as_ref() {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^ help: try this: `bin_name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:161:29
[INFO] [stderr]     |
[INFO] [stderr] 161 | fn concourse_in<'a>(source: &String, resource: &'a Resource) -> Out<'a> {
[INFO] [stderr]     |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:210:22
[INFO] [stderr]     |
[INFO] [stderr] 210 |         if folder != ".".to_string() && folder[0..4] == mask && folder.to_string() >= version {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^ help: try: `"."`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:210:65
[INFO] [stderr]     |
[INFO] [stderr] 210 |         if folder != ".".to_string() && folder[0..4] == mask && folder.to_string() >= version {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^ help: try: `folder`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:82:9
[INFO] [stderr]    |
[INFO] [stderr] 82 | /         match self {
[INFO] [stderr] 83 | |             &Out::Empty => Json::Object(BTreeMap::new()),
[INFO] [stderr] 84 | |             &Out::One(ref v) => {
[INFO] [stderr] 85 | |                 let mut d = BTreeMap::new();
[INFO] [stderr] ...  |
[INFO] [stderr] 89 | |             &Out::Many(ref v) => v.to_json(),
[INFO] [stderr] 90 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 82 |         match *self {
[INFO] [stderr] 83 |             Out::Empty => Json::Object(BTreeMap::new()),
[INFO] [stderr] 84 |             Out::One(ref v) => {
[INFO] [stderr] 85 |                 let mut d = BTreeMap::new();
[INFO] [stderr] 86 |                 d.insert("version".to_string(), v.to_json());
[INFO] [stderr] 87 |                 Json::Object(d)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/main.rs:118:21
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let out = match bin_name.as_ref() {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^ help: try this: `bin_name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:161:29
[INFO] [stderr]     |
[INFO] [stderr] 161 | fn concourse_in<'a>(source: &String, resource: &'a Resource) -> Out<'a> {
[INFO] [stderr]     |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:210:22
[INFO] [stderr]     |
[INFO] [stderr] 210 |         if folder != ".".to_string() && folder[0..4] == mask && folder.to_string() >= version {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^ help: try: `"."`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:210:65
[INFO] [stderr]     |
[INFO] [stderr] 210 |         if folder != ".".to_string() && folder[0..4] == mask && folder.to_string() >= version {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^ help: try: `folder`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.64s
[INFO] running `"docker" "inspect" "0dfccd7c3f6f6409f7e7a3b85f1e1623617567186241bb12a7d494441e1d3e41"`
[INFO] running `"docker" "rm" "-f" "0dfccd7c3f6f6409f7e7a3b85f1e1623617567186241bb12a7d494441e1d3e41"`
[INFO] [stdout] 0dfccd7c3f6f6409f7e7a3b85f1e1623617567186241bb12a7d494441e1d3e41