[INFO] updating cached repository chasent/IronSMTP [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/chasent/IronSMTP [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/chasent/IronSMTP" "work/ex/clippy-test-run/sources/stable/gh/chasent/IronSMTP"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/chasent/IronSMTP'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/chasent/IronSMTP" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chasent/IronSMTP"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chasent/IronSMTP'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c2e3c19b848d020ebbe341afcbe2f6d6431adc3 [INFO] sha for GitHub repo chasent/IronSMTP: 3c2e3c19b848d020ebbe341afcbe2f6d6431adc3 [INFO] validating manifest of chasent/IronSMTP on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chasent/IronSMTP on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chasent/IronSMTP [INFO] finished frobbing chasent/IronSMTP [INFO] frobbed toml for chasent/IronSMTP written to work/ex/clippy-test-run/sources/stable/gh/chasent/IronSMTP/Cargo.toml [INFO] started frobbing chasent/IronSMTP [INFO] finished frobbing chasent/IronSMTP [INFO] frobbed toml for chasent/IronSMTP written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/chasent/IronSMTP/Cargo.toml [INFO] crate chasent/IronSMTP has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chasent/IronSMTP against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/chasent/IronSMTP:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b8964caa29f6294a7086e5f0b4f4884153803d7cf22c5696420e3ce6daabf51 [INFO] running `"docker" "start" "-a" "0b8964caa29f6294a7086e5f0b4f4884153803d7cf22c5696420e3ce6daabf51"` [INFO] [stderr] Checking lazycell v1.1.0 [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking rsmtp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:103:1 [INFO] [stderr] | [INFO] [stderr] 103 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | use tokio::net::{TcpStream, TcpListener}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tokio::prelude` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | use tokio::prelude; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Either`, `FutureResult`, `ok`, `self` [INFO] [stderr] --> src/main.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | use futures::future::{self, Either, ok, loop_fn, Future, FutureResult, Loop}; [INFO] [stderr] | ^^^^ ^^^^^^ ^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | return Box::new(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(res)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | return Box::new(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:342:21 [INFO] [stderr] | [INFO] [stderr] 342 | return handle_connecting(smtp_session); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `handle_connecting(smtp_session)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | return handle_connected(smtp_session); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `handle_connected(smtp_session)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:103:1 [INFO] [stderr] | [INFO] [stderr] 103 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | use tokio::net::{TcpStream, TcpListener}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tokio::prelude` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | use tokio::prelude; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Either`, `FutureResult`, `ok`, `self` [INFO] [stderr] --> src/main.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | use futures::future::{self, Either, ok, loop_fn, Future, FutureResult, Loop}; [INFO] [stderr] | ^^^^ ^^^^^^ ^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | return Box::new(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(res)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | return Box::new(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:342:21 [INFO] [stderr] | [INFO] [stderr] 342 | return handle_connecting(smtp_session); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `handle_connecting(smtp_session)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | return handle_connected(smtp_session); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `handle_connected(smtp_session)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `disconnect` [INFO] [stderr] --> src/main.rs:152:1 [INFO] [stderr] | [INFO] [stderr] 152 | fn disconnect(state: Disconnected) -> impl Future { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `from_hex` [INFO] [stderr] --> src/main.rs:535:1 [INFO] [stderr] | [INFO] [stderr] 535 | fn from_hex(input: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_hex_digit` [INFO] [stderr] --> src/main.rs:539:1 [INFO] [stderr] | [INFO] [stderr] 539 | fn is_hex_digit(c: char) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/main.rs:543:1 [INFO] [stderr] | [INFO] [stderr] 543 | / named!(hex_primary<&str, u8>, [INFO] [stderr] 544 | | map_res!(take_while_m_n!(2, 2, is_hex_digit), from_hex) [INFO] [stderr] 545 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/main.rs:569:27 [INFO] [stderr] | [INFO] [stderr] 569 | reverse_path: "" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | expected struct `std::string::String`, found reference [INFO] [stderr] | help: try using a conversion method: `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: expected type `std::string::String` [INFO] [stderr] found type `&'static str` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `rsmtp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0b8964caa29f6294a7086e5f0b4f4884153803d7cf22c5696420e3ce6daabf51"` [INFO] running `"docker" "rm" "-f" "0b8964caa29f6294a7086e5f0b4f4884153803d7cf22c5696420e3ce6daabf51"` [INFO] [stdout] 0b8964caa29f6294a7086e5f0b4f4884153803d7cf22c5696420e3ce6daabf51