[INFO] updating cached repository charleskorn/ascii-clock [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/charleskorn/ascii-clock [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/charleskorn/ascii-clock" "work/ex/clippy-test-run/sources/stable/gh/charleskorn/ascii-clock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/charleskorn/ascii-clock'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/charleskorn/ascii-clock" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/charleskorn/ascii-clock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/charleskorn/ascii-clock'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e0fdc83fdb6a363921a17b937a5f763b4d75e58d [INFO] sha for GitHub repo charleskorn/ascii-clock: e0fdc83fdb6a363921a17b937a5f763b4d75e58d [INFO] validating manifest of charleskorn/ascii-clock on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of charleskorn/ascii-clock on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing charleskorn/ascii-clock [INFO] finished frobbing charleskorn/ascii-clock [INFO] frobbed toml for charleskorn/ascii-clock written to work/ex/clippy-test-run/sources/stable/gh/charleskorn/ascii-clock/Cargo.toml [INFO] started frobbing charleskorn/ascii-clock [INFO] finished frobbing charleskorn/ascii-clock [INFO] frobbed toml for charleskorn/ascii-clock written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/charleskorn/ascii-clock/Cargo.toml [INFO] crate charleskorn/ascii-clock has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting charleskorn/ascii-clock against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/charleskorn/ascii-clock:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f09de0512f2220efa231e3d69b10b27af31be3bb69d451905b6d506eb11fc01e [INFO] running `"docker" "start" "-a" "f09de0512f2220efa231e3d69b10b27af31be3bb69d451905b6d506eb11fc01e"` [INFO] [stderr] Checking ascii-clock v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/time.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(Time { hour: hour, minute: minute }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/time.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(Time { hour: hour, minute: minute }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/time.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(Time { hour: hour, minute: minute }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/time.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(Time { hour: hour, minute: minute }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generator.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return clock; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `clock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/time.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(Time { hour: hour, minute: minute }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Time { hour: hour, minute: minute })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/time.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / if separator_index.is_none() { [INFO] [stderr] 12 | | return None; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `separator_index?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generator.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return clock; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `clock` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/time.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(Time { hour: hour, minute: minute }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Time { hour: hour, minute: minute })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/time.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / if separator_index.is_none() { [INFO] [stderr] 12 | | return None; [INFO] [stderr] 13 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `separator_index?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.20s [INFO] running `"docker" "inspect" "f09de0512f2220efa231e3d69b10b27af31be3bb69d451905b6d506eb11fc01e"` [INFO] running `"docker" "rm" "-f" "f09de0512f2220efa231e3d69b10b27af31be3bb69d451905b6d506eb11fc01e"` [INFO] [stdout] f09de0512f2220efa231e3d69b10b27af31be3bb69d451905b6d506eb11fc01e