[INFO] updating cached repository ceymard/rust-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ceymard/rust-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ceymard/rust-test" "work/ex/clippy-test-run/sources/stable/gh/ceymard/rust-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ceymard/rust-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ceymard/rust-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ceymard/rust-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ceymard/rust-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b1b4e5212ac9e80185cd6a1267f09b91d3a0b9e2 [INFO] sha for GitHub repo ceymard/rust-test: b1b4e5212ac9e80185cd6a1267f09b91d3a0b9e2 [INFO] validating manifest of ceymard/rust-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ceymard/rust-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ceymard/rust-test [INFO] finished frobbing ceymard/rust-test [INFO] frobbed toml for ceymard/rust-test written to work/ex/clippy-test-run/sources/stable/gh/ceymard/rust-test/Cargo.toml [INFO] started frobbing ceymard/rust-test [INFO] finished frobbing ceymard/rust-test [INFO] frobbed toml for ceymard/rust-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ceymard/rust-test/Cargo.toml [INFO] crate ceymard/rust-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ceymard/rust-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ceymard/rust-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5df2d957157ecf0a4120f21b95498f65c37f34e79f47539f386904a92be66423 [INFO] running `"docker" "start" "-a" "5df2d957157ecf0a4120f21b95498f65c37f34e79f47539f386904a92be66423"` [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking serde_json v1.0.8 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking quick-xml v0.10.0 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking zip v0.2.6 [INFO] [stderr] Checking calamine v0.12.1 [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | header [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | let header = row.iter().map(|ref x| x.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `cell_to_json` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | fn cell_to_json(cell: &DataType) -> std::result::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / match cell { [INFO] [stderr] 19 | | &DataType::Float(f) => Ok(json!(f)), [INFO] [stderr] 20 | | &DataType::Int(i) => Ok(json!(i)), [INFO] [stderr] 21 | | &DataType::String(ref s) => Ok(json!(s)), [INFO] [stderr] ... | [INFO] [stderr] 24 | | &DataType::Error(_) => Err("...") // On devrait probablement ne pas se passer d'erreurs... [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *cell { [INFO] [stderr] 19 | DataType::Float(f) => Ok(json!(f)), [INFO] [stderr] 20 | DataType::Int(i) => Ok(json!(i)), [INFO] [stderr] 21 | DataType::String(ref s) => Ok(json!(s)), [INFO] [stderr] 22 | DataType::Bool(b) => Ok(json!(b)), [INFO] [stderr] 23 | DataType::Empty => Ok(Value::Null), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | let path = format!("{}", pth); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `pth.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | header [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | let header = row.iter().map(|ref x| x.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `cell_to_json` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | fn cell_to_json(cell: &DataType) -> std::result::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / match cell { [INFO] [stderr] 19 | | &DataType::Float(f) => Ok(json!(f)), [INFO] [stderr] 20 | | &DataType::Int(i) => Ok(json!(i)), [INFO] [stderr] 21 | | &DataType::String(ref s) => Ok(json!(s)), [INFO] [stderr] ... | [INFO] [stderr] 24 | | &DataType::Error(_) => Err("...") // On devrait probablement ne pas se passer d'erreurs... [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *cell { [INFO] [stderr] 19 | DataType::Float(f) => Ok(json!(f)), [INFO] [stderr] 20 | DataType::Int(i) => Ok(json!(i)), [INFO] [stderr] 21 | DataType::String(ref s) => Ok(json!(s)), [INFO] [stderr] 22 | DataType::Bool(b) => Ok(json!(b)), [INFO] [stderr] 23 | DataType::Empty => Ok(Value::Null), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | let path = format!("{}", pth); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `pth.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.18s [INFO] running `"docker" "inspect" "5df2d957157ecf0a4120f21b95498f65c37f34e79f47539f386904a92be66423"` [INFO] running `"docker" "rm" "-f" "5df2d957157ecf0a4120f21b95498f65c37f34e79f47539f386904a92be66423"` [INFO] [stdout] 5df2d957157ecf0a4120f21b95498f65c37f34e79f47539f386904a92be66423