[INFO] updating cached repository cetra3/rustcloud
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cetra3/rustcloud
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cetra3/rustcloud" "work/ex/clippy-test-run/sources/stable/gh/cetra3/rustcloud"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cetra3/rustcloud'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cetra3/rustcloud" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/rustcloud"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/rustcloud'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 576a2d4b8a42be5bcf44d359a2ce86da19ee4d2d
[INFO] sha for GitHub repo cetra3/rustcloud: 576a2d4b8a42be5bcf44d359a2ce86da19ee4d2d
[INFO] validating manifest of cetra3/rustcloud on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cetra3/rustcloud on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cetra3/rustcloud
[INFO] finished frobbing cetra3/rustcloud
[INFO] frobbed toml for cetra3/rustcloud written to work/ex/clippy-test-run/sources/stable/gh/cetra3/rustcloud/Cargo.toml
[INFO] started frobbing cetra3/rustcloud
[INFO] finished frobbing cetra3/rustcloud
[INFO] frobbed toml for cetra3/rustcloud written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/rustcloud/Cargo.toml
[INFO] crate cetra3/rustcloud has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cetra3/rustcloud against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cetra3/rustcloud:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 47a6cec3483170a77c847789c2e343cb11b0d26f0490a620c834cd81c81c7e2a
[INFO] running `"docker" "start" "-a" "47a6cec3483170a77c847789c2e343cb11b0d26f0490a620c834cd81c81c7e2a"`
[INFO] [stderr]     Checking term v0.4.5
[INFO] [stderr]     Checking threadpool v0.2.1
[INFO] [stderr]     Checking filetime v0.1.10
[INFO] [stderr]    Compiling hyper v0.10.8
[INFO] [stderr]     Checking openssl-sys v0.9.11
[INFO] [stderr]     Checking flate2 v0.2.19
[INFO] [stderr]     Checking chrono v0.3.0
[INFO] [stderr]     Checking openssl v0.9.11
[INFO] [stderr]     Checking term-painter v0.2.3
[INFO] [stderr]     Checking id3 v0.1.11
[INFO] [stderr]     Checking native-tls v0.1.2
[INFO] [stderr]     Checking hyper-native-tls v0.2.2
[INFO] [stderr]     Checking rustcloud v0.0.4 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:143:21
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     print!(" at: {}\n", file_path);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:149:21
[INFO] [stderr]     |
[INFO] [stderr] 149 |                     print!(" to: {}\n", file_path);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:154:21
[INFO] [stderr]     |
[INFO] [stderr] 154 |                     print!("\n");
[INFO] [stderr]     |                     ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:379:21
[INFO] [stderr]     |
[INFO] [stderr] 379 |                     print!(" ({})\n", song.kind);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:143:21
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     print!(" at: {}\n", file_path);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:149:21
[INFO] [stderr]     |
[INFO] [stderr] 149 |                     print!(" to: {}\n", file_path);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:154:21
[INFO] [stderr]     |
[INFO] [stderr] 154 |                     print!("\n");
[INFO] [stderr]     |                     ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/main.rs:379:21
[INFO] [stderr]     |
[INFO] [stderr] 379 |                     print!(" ({})\n", song.kind);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:315:27
[INFO] [stderr]     |
[INFO] [stderr] 315 |     let hours = time_ms / 3600000;
[INFO] [stderr]     |                           ^^^^^^^ help: consider: `3_600_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:386:5
[INFO] [stderr]     |
[INFO] [stderr] 386 |     return songs;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `songs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:416:5
[INFO] [stderr]     |
[INFO] [stderr] 416 |     return json::decode(&*body).unwrap();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `json::decode(&*body).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:315:27
[INFO] [stderr]     |
[INFO] [stderr] 315 |     let hours = time_ms / 3600000;
[INFO] [stderr]     |                           ^^^^^^^ help: consider: `3_600_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:386:5
[INFO] [stderr]     |
[INFO] [stderr] 386 |     return songs;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `songs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:416:5
[INFO] [stderr]     |
[INFO] [stderr] 416 |     return json::decode(&*body).unwrap();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `json::decode(&*body).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/main.rs:107:17
[INFO] [stderr]     |
[INFO] [stderr] 107 |                 Err(_) => panic!("Could not decode the auth_response file!")
[INFO] [stderr]     |                 ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:100:25
[INFO] [stderr]     |
[INFO] [stderr] 100 | /                         match (json.expires_in + mtime.seconds_relative_to_1970() as i64) < current_time.timestamp() {
[INFO] [stderr] 101 | |                             true => get_and_save_auth_token(auth_info),
[INFO] [stderr] 102 | |                             false => json
[INFO] [stderr] 103 | |                         }
[INFO] [stderr]     | |_________________________^ help: consider using an if/else expression: `if (json.expires_in + mtime.seconds_relative_to_1970() as i64) < current_time.timestamp() { get_and_save_auth_token(auth_info) } else { json }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:198:5
[INFO] [stderr]     |
[INFO] [stderr] 198 | /     match resolve_file("auth_response") {
[INFO] [stderr] 199 | |         Ok(_) => fs::remove_file("auth_response").unwrap(),
[INFO] [stderr] 200 | |         Err(_) => ()
[INFO] [stderr] 201 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let Ok(_) = resolve_file("auth_response") { fs::remove_file("auth_response").unwrap() }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:213:5
[INFO] [stderr]     |
[INFO] [stderr] 213 | /     match stdin.read_line(&mut input) {
[INFO] [stderr] 214 | |         Ok(_) => {
[INFO] [stderr] 215 | |             output = format!("{}", input.trim());
[INFO] [stderr] 216 | |         }
[INFO] [stderr] 217 | |         Err(_) => ()
[INFO] [stderr] 218 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 213 |     if let Ok(_) = stdin.read_line(&mut input) {
[INFO] [stderr] 214 |     output = format!("{}", input.trim());
[INFO] [stderr] 215 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:215:22
[INFO] [stderr]     |
[INFO] [stderr] 215 |             output = format!("{}", input.trim());
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `input.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:227:17
[INFO] [stderr]     |
[INFO] [stderr] 227 | /                 match can_download {
[INFO] [stderr] 228 | |                     true => "download",
[INFO] [stderr] 229 | |                     false => "stream"
[INFO] [stderr] 230 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if can_download { "download" } else { "stream" }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/main.rs:107:17
[INFO] [stderr]     |
[INFO] [stderr] 107 |                 Err(_) => panic!("Could not decode the auth_response file!")
[INFO] [stderr]     |                 ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:100:25
[INFO] [stderr]     |
[INFO] [stderr] 100 | /                         match (json.expires_in + mtime.seconds_relative_to_1970() as i64) < current_time.timestamp() {
[INFO] [stderr] 101 | |                             true => get_and_save_auth_token(auth_info),
[INFO] [stderr] 102 | |                             false => json
[INFO] [stderr] 103 | |                         }
[INFO] [stderr]     | |_________________________^ help: consider using an if/else expression: `if (json.expires_in + mtime.seconds_relative_to_1970() as i64) < current_time.timestamp() { get_and_save_auth_token(auth_info) } else { json }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:245:5
[INFO] [stderr]     |
[INFO] [stderr] 245 | /     match song.artwork_url {
[INFO] [stderr] 246 | |        Some(ref url) => {
[INFO] [stderr] 247 | |            let larger_url = url.replace("large.jpg", "t500x500.jpg");
[INFO] [stderr] 248 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 261 | |        None => ()
[INFO] [stderr] 262 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 245 |     if let Some(ref url) = song.artwork_url {
[INFO] [stderr] 246 |     let larger_url = url.replace("large.jpg", "t500x500.jpg");
[INFO] [stderr] 247 | 
[INFO] [stderr] 248 |     // Create a client.
[INFO] [stderr] 249 |     let client = get_client();
[INFO] [stderr] 250 |     let mut res = client.get(&*larger_url)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/main.rs:273:40
[INFO] [stderr]     |
[INFO] [stderr] 273 |     let mut file_handle = File::create(file_name.clone()).unwrap();
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 273 |     let mut file_handle = File::create(&(*file_name).clone()).unwrap();
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 273 |     let mut file_handle = File::create(&str::clone(file_name)).unwrap();
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:198:5
[INFO] [stderr]     |
[INFO] [stderr] 198 | /     match resolve_file("auth_response") {
[INFO] [stderr] 199 | |         Ok(_) => fs::remove_file("auth_response").unwrap(),
[INFO] [stderr] 200 | |         Err(_) => ()
[INFO] [stderr] 201 | |     }
[INFO] [stderr]     | |_____^ help: try this: `if let Ok(_) = resolve_file("auth_response") { fs::remove_file("auth_response").unwrap() }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:213:5
[INFO] [stderr]     |
[INFO] [stderr] 213 | /     match stdin.read_line(&mut input) {
[INFO] [stderr] 214 | |         Ok(_) => {
[INFO] [stderr] 215 | |             output = format!("{}", input.trim());
[INFO] [stderr] 216 | |         }
[INFO] [stderr] 217 | |         Err(_) => ()
[INFO] [stderr] 218 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:297:21
[INFO] [stderr]     |
[INFO] [stderr] 297 |       let seperator = match cfg!(target_os = "windows") {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 298 | |         true => "\\",
[INFO] [stderr] 299 | |         false => "/"
[INFO] [stderr] 300 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if cfg!(target_os = "windows") { "\\" } else { "/" }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 213 |     if let Ok(_) = stdin.read_line(&mut input) {
[INFO] [stderr] 214 |     output = format!("{}", input.trim());
[INFO] [stderr] 215 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:215:22
[INFO] [stderr]     |
[INFO] [stderr] 215 |             output = format!("{}", input.trim());
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `input.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:227:17
[INFO] [stderr]     |
[INFO] [stderr] 227 | /                 match can_download {
[INFO] [stderr] 228 | |                     true => "download",
[INFO] [stderr] 229 | |                     false => "stream"
[INFO] [stderr] 230 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if can_download { "download" } else { "stream" }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:333:5
[INFO] [stderr]     |
[INFO] [stderr] 333 | /     match path.exists(){
[INFO] [stderr] 334 | |         true => File::open(&path),
[INFO] [stderr] 335 | |         false => { Err(Error::new(ErrorKind::NotFound,
[INFO] [stderr] 336 | |             "the file cannot be found")) }
[INFO] [stderr] 337 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:245:5
[INFO] [stderr]     |
[INFO] [stderr] 245 | /     match song.artwork_url {
[INFO] [stderr] 246 | |        Some(ref url) => {
[INFO] [stderr] 247 | |            let larger_url = url.replace("large.jpg", "t500x500.jpg");
[INFO] [stderr] 248 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 261 | |        None => ()
[INFO] [stderr] 262 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 245 |     if let Some(ref url) = song.artwork_url {
[INFO] [stderr] 246 |     let larger_url = url.replace("large.jpg", "t500x500.jpg");
[INFO] [stderr] 247 | 
[INFO] [stderr] 248 |     // Create a client.
[INFO] [stderr] 249 |     let client = get_client();
[INFO] [stderr] 250 |     let mut res = client.get(&*larger_url)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/main.rs:273:40
[INFO] [stderr]     |
[INFO] [stderr] 273 |     let mut file_handle = File::create(file_name.clone()).unwrap();
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 273 |     let mut file_handle = File::create(&(*file_name).clone()).unwrap();
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 273 |     let mut file_handle = File::create(&str::clone(file_name)).unwrap();
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 333 |     if path.exists() { File::open(&path) } else { Err(Error::new(ErrorKind::NotFound,
[INFO] [stderr] 334 | "the file cannot be found")) }
[INFO] [stderr]     |
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:297:21
[INFO] [stderr]     |
[INFO] [stderr] 297 |       let seperator = match cfg!(target_os = "windows") {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 298 | |         true => "\\",
[INFO] [stderr] 299 | |         false => "/"
[INFO] [stderr] 300 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if cfg!(target_os = "windows") { "\\" } else { "/" }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:370:9
[INFO] [stderr]     |
[INFO] [stderr] 370 | /         match collection_info.origin {
[INFO] [stderr] 371 | |             Some(song) => {
[INFO] [stderr] 372 | |                 if song.duration >= duration_limit_ms && !processed_songs.contains(&song.id) && song.kind == "track" {
[INFO] [stderr] 373 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 382 | |             None => ()
[INFO] [stderr] 383 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 370 |         if let Some(song) = collection_info.origin {
[INFO] [stderr] 371 |     if song.duration >= duration_limit_ms && !processed_songs.contains(&song.id) && song.kind == "track" {
[INFO] [stderr] 372 | 
[INFO] [stderr] 373 |         processed_songs.insert(song.id);
[INFO] [stderr] 374 |         songs.push(song);
[INFO] [stderr] 375 |     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:333:5
[INFO] [stderr]     |
[INFO] [stderr] 333 | /     match path.exists(){
[INFO] [stderr] 334 | |         true => File::open(&path),
[INFO] [stderr] 335 | |         false => { Err(Error::new(ErrorKind::NotFound,
[INFO] [stderr] 336 | |             "the file cannot be found")) }
[INFO] [stderr] 337 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 333 |     if path.exists() { File::open(&path) } else { Err(Error::new(ErrorKind::NotFound,
[INFO] [stderr] 334 | "the file cannot be found")) }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rustcloud`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:370:9
[INFO] [stderr]     |
[INFO] [stderr] 370 | /         match collection_info.origin {
[INFO] [stderr] 371 | |             Some(song) => {
[INFO] [stderr] 372 | |                 if song.duration >= duration_limit_ms && !processed_songs.contains(&song.id) && song.kind == "track" {
[INFO] [stderr] 373 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 382 | |             None => ()
[INFO] [stderr] 383 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 370 |         if let Some(song) = collection_info.origin {
[INFO] [stderr] 371 |     if song.duration >= duration_limit_ms && !processed_songs.contains(&song.id) && song.kind == "track" {
[INFO] [stderr] 372 | 
[INFO] [stderr] 373 |         processed_songs.insert(song.id);
[INFO] [stderr] 374 |         songs.push(song);
[INFO] [stderr] 375 |     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rustcloud`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "47a6cec3483170a77c847789c2e343cb11b0d26f0490a620c834cd81c81c7e2a"`
[INFO] running `"docker" "rm" "-f" "47a6cec3483170a77c847789c2e343cb11b0d26f0490a620c834cd81c81c7e2a"`
[INFO] [stdout] 47a6cec3483170a77c847789c2e343cb11b0d26f0490a620c834cd81c81c7e2a