[INFO] updating cached repository cetra3/hsperf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cetra3/hsperf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cetra3/hsperf" "work/ex/clippy-test-run/sources/stable/gh/cetra3/hsperf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cetra3/hsperf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cetra3/hsperf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/hsperf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/hsperf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 79d616371567c1df9ed957e4b43829efe6b2706c [INFO] sha for GitHub repo cetra3/hsperf: 79d616371567c1df9ed957e4b43829efe6b2706c [INFO] validating manifest of cetra3/hsperf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cetra3/hsperf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cetra3/hsperf [INFO] finished frobbing cetra3/hsperf [INFO] frobbed toml for cetra3/hsperf written to work/ex/clippy-test-run/sources/stable/gh/cetra3/hsperf/Cargo.toml [INFO] started frobbing cetra3/hsperf [INFO] finished frobbing cetra3/hsperf [INFO] frobbed toml for cetra3/hsperf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cetra3/hsperf/Cargo.toml [INFO] crate cetra3/hsperf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cetra3/hsperf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cetra3/hsperf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 39705472f071ff4fb52e72b95e2c667071ec5d9d86315baf63dd816419e1eb44 [INFO] running `"docker" "start" "-a" "39705472f071ff4fb52e72b95e2c667071ec5d9d86315baf63dd816419e1eb44"` [INFO] [stderr] Compiling syn v0.12.12 [INFO] [stderr] Compiling structopt-derive v0.2.2 [INFO] [stderr] Checking structopt v0.2.2 [INFO] [stderr] Checking hsperf v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/perfdata.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | const MAGIC: u32 = 0xcafec0c0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcafe_c0c0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | / return Ok(PerfData { [INFO] [stderr] 77 | | entries [INFO] [stderr] 78 | | }) [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | Ok(PerfData { [INFO] [stderr] 77 | entries [INFO] [stderr] 78 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return app_time / freq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `app_time / freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return self.get_val("sun.gc.generation.0.maxCapacity") + self.get_val("sun.gc.generation.1.maxCapacity");; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_val("sun.gc.generation.0.maxCapacity") + self.get_val("sun.gc.generation.1.maxCapacity")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return gen_0_space_0_cap + gen_0_space_1_cap + gen_0_space_2_cap + gen_1_space_1_cap + metaspace_used; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gen_0_space_0_cap + gen_0_space_1_cap + gen_0_space_2_cap + gen_1_space_1_cap + metaspace_used` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return full_gc / freq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `full_gc / freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return (full_gc + other_gc) / freq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(full_gc + other_gc) / freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return self.get_val("sun.gc.collector.1.invocations"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_val("sun.gc.collector.1.invocations")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return self.get_val("sun.gc.collector.1.invocations") + self.get_val("sun.gc.collector.0.invocations") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_val("sun.gc.collector.1.invocations") + self.get_val("sun.gc.collector.0.invocations")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/perfdata.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | const MAGIC: u32 = 0xcafec0c0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcafe_c0c0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | / return Ok(PerfData { [INFO] [stderr] 77 | | entries [INFO] [stderr] 78 | | }) [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | Ok(PerfData { [INFO] [stderr] 77 | entries [INFO] [stderr] 78 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return app_time / freq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `app_time / freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return self.get_val("sun.gc.generation.0.maxCapacity") + self.get_val("sun.gc.generation.1.maxCapacity");; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_val("sun.gc.generation.0.maxCapacity") + self.get_val("sun.gc.generation.1.maxCapacity")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return gen_0_space_0_cap + gen_0_space_1_cap + gen_0_space_2_cap + gen_1_space_1_cap + metaspace_used; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gen_0_space_0_cap + gen_0_space_1_cap + gen_0_space_2_cap + gen_1_space_1_cap + metaspace_used` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return full_gc / freq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `full_gc / freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return (full_gc + other_gc) / freq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(full_gc + other_gc) / freq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return self.get_val("sun.gc.collector.1.invocations"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_val("sun.gc.collector.1.invocations")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/perfdata.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return self.get_val("sun.gc.collector.1.invocations") + self.get_val("sun.gc.collector.0.invocations") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_val("sun.gc.collector.1.invocations") + self.get_val("sun.gc.collector.0.invocations")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/perfdata.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | / let entries; [INFO] [stderr] 67 | | [INFO] [stderr] 68 | | if byte_order == 0 { [INFO] [stderr] 69 | | prolog = read_prologue::(f)?; [INFO] [stderr] ... | [INFO] [stderr] 73 | | entries = read_entries::(&prolog, f)?; [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let entries = if byte_order == 0 { ..; read_entries::(&prolog, f)? } else { ..; read_entries::(&prolog, f)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/perfdata.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / if let &PerfDataValue::Long(val) = val { [INFO] [stderr] 92 | | return Some(val) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | if let PerfDataValue::Long(val) = *val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/perfdata.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | / match self { [INFO] [stderr] 296 | | &PerfDataValue::String(ref val) => write!(f, "{}", val), [INFO] [stderr] 297 | | &PerfDataValue::Long(ref val) => write!(f, "{}", val), [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 295 | match *self { [INFO] [stderr] 296 | PerfDataValue::String(ref val) => write!(f, "{}", val), [INFO] [stderr] 297 | PerfDataValue::Long(ref val) => write!(f, "{}", val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/perfdata.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | / let entries; [INFO] [stderr] 67 | | [INFO] [stderr] 68 | | if byte_order == 0 { [INFO] [stderr] 69 | | prolog = read_prologue::(f)?; [INFO] [stderr] ... | [INFO] [stderr] 73 | | entries = read_entries::(&prolog, f)?; [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let entries = if byte_order == 0 { ..; read_entries::(&prolog, f)? } else { ..; read_entries::(&prolog, f)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/perfdata.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / if let &PerfDataValue::Long(val) = val { [INFO] [stderr] 92 | | return Some(val) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | if let PerfDataValue::Long(val) = *val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/perfdata.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | / match self { [INFO] [stderr] 296 | | &PerfDataValue::String(ref val) => write!(f, "{}", val), [INFO] [stderr] 297 | | &PerfDataValue::Long(ref val) => write!(f, "{}", val), [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 295 | match *self { [INFO] [stderr] 296 | PerfDataValue::String(ref val) => write!(f, "{}", val), [INFO] [stderr] 297 | PerfDataValue::Long(ref val) => write!(f, "{}", val), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.68s [INFO] running `"docker" "inspect" "39705472f071ff4fb52e72b95e2c667071ec5d9d86315baf63dd816419e1eb44"` [INFO] running `"docker" "rm" "-f" "39705472f071ff4fb52e72b95e2c667071ec5d9d86315baf63dd816419e1eb44"` [INFO] [stdout] 39705472f071ff4fb52e72b95e2c667071ec5d9d86315baf63dd816419e1eb44