[INFO] updating cached repository cessen/markov_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cessen/markov_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cessen/markov_rust" "work/ex/clippy-test-run/sources/stable/gh/cessen/markov_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cessen/markov_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cessen/markov_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cessen/markov_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cessen/markov_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e9872ae802dc4e1d948e679dc5831a98550799d5 [INFO] sha for GitHub repo cessen/markov_rust: e9872ae802dc4e1d948e679dc5831a98550799d5 [INFO] validating manifest of cessen/markov_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cessen/markov_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cessen/markov_rust [INFO] finished frobbing cessen/markov_rust [INFO] frobbed toml for cessen/markov_rust written to work/ex/clippy-test-run/sources/stable/gh/cessen/markov_rust/Cargo.toml [INFO] started frobbing cessen/markov_rust [INFO] finished frobbing cessen/markov_rust [INFO] frobbed toml for cessen/markov_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cessen/markov_rust/Cargo.toml [INFO] crate cessen/markov_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cessen/markov_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cessen/markov_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c5f591ee0a08550ab298449a737ed5decf2a2f4d4ed5dff732a3b350583a1b0 [INFO] running `"docker" "start" "-a" "8c5f591ee0a08550ab298449a737ed5decf2a2f4d4ed5dff732a3b350583a1b0"` [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking markov_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stats.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stats.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stats.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stats.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stats.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = r" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stats.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = r" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/stats.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | for ord in 0..(max_order + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=max_order` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/stats.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | .or_insert_with(|| HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if let None = args.arg_output { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 81 | | println!("----------------"); [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____- help: try this: `if args.arg_output.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/stats.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | for ord in 0..(max_order + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=max_order` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/stats.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | .or_insert_with(|| HashMap::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if let None = args.arg_output { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 81 | | println!("----------------"); [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____- help: try this: `if args.arg_output.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.22s [INFO] running `"docker" "inspect" "8c5f591ee0a08550ab298449a737ed5decf2a2f4d4ed5dff732a3b350583a1b0"` [INFO] running `"docker" "rm" "-f" "8c5f591ee0a08550ab298449a737ed5decf2a2f4d4ed5dff732a3b350583a1b0"` [INFO] [stdout] 8c5f591ee0a08550ab298449a737ed5decf2a2f4d4ed5dff732a3b350583a1b0