[INFO] updating cached repository cesare/rust_slack_client [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cesare/rust_slack_client [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cesare/rust_slack_client" "work/ex/clippy-test-run/sources/stable/gh/cesare/rust_slack_client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cesare/rust_slack_client'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cesare/rust_slack_client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust_slack_client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust_slack_client'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6cc3488df262e171bb813216403502d05f109a54 [INFO] sha for GitHub repo cesare/rust_slack_client: 6cc3488df262e171bb813216403502d05f109a54 [INFO] validating manifest of cesare/rust_slack_client on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cesare/rust_slack_client on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cesare/rust_slack_client [INFO] finished frobbing cesare/rust_slack_client [INFO] frobbed toml for cesare/rust_slack_client written to work/ex/clippy-test-run/sources/stable/gh/cesare/rust_slack_client/Cargo.toml [INFO] started frobbing cesare/rust_slack_client [INFO] finished frobbing cesare/rust_slack_client [INFO] frobbed toml for cesare/rust_slack_client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust_slack_client/Cargo.toml [INFO] crate cesare/rust_slack_client has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cesare/rust_slack_client against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cesare/rust_slack_client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 669213b587e62aa713db8f5e863f59c56383c9db90b8280e5fc3bc7d9aada1a7 [INFO] running `"docker" "start" "-a" "669213b587e62aa713db8f5e863f59c56383c9db90b8280e5fc3bc7d9aada1a7"` [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Compiling openssl v0.10.11 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.76 [INFO] [stderr] Checking hyper v0.12.9 [INFO] [stderr] Checking hyper-tls v0.3.0 [INFO] [stderr] Checking slack_client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conversation.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/conversation.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: field is never used: `client` [INFO] [stderr] --> src/conversation.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | client: HttpClient, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `authentication::AuthenticationRequest` [INFO] [stderr] --> src/authentication.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> AuthenticationRequest { [INFO] [stderr] 16 | | AuthenticationRequest {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `conversation::ListChannelsRequest` [INFO] [stderr] --> src/conversation.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> ListChannelsRequest { [INFO] [stderr] 70 | | ListChannelsRequest { [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `client` [INFO] [stderr] --> src/conversation.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | client: HttpClient, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `authentication::AuthenticationRequest` [INFO] [stderr] --> src/authentication.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> AuthenticationRequest { [INFO] [stderr] 16 | | AuthenticationRequest {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `conversation::ListChannelsRequest` [INFO] [stderr] --> src/conversation.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> ListChannelsRequest { [INFO] [stderr] 70 | | ListChannelsRequest { [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/rtm.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | fn connect_websocket(url: &String) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/rtm.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | fn connect_websocket(url: &String) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `"docker" "inspect" "669213b587e62aa713db8f5e863f59c56383c9db90b8280e5fc3bc7d9aada1a7"` [INFO] running `"docker" "rm" "-f" "669213b587e62aa713db8f5e863f59c56383c9db90b8280e5fc3bc7d9aada1a7"` [INFO] [stdout] 669213b587e62aa713db8f5e863f59c56383c9db90b8280e5fc3bc7d9aada1a7