[INFO] updating cached repository cesare/rust-upto-top
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cesare/rust-upto-top
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cesare/rust-upto-top" "work/ex/clippy-test-run/sources/stable/gh/cesare/rust-upto-top"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cesare/rust-upto-top'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cesare/rust-upto-top" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-upto-top"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-upto-top'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] dddaad2e24d9cacf1f6ba85e59c575ad31e419a7
[INFO] sha for GitHub repo cesare/rust-upto-top: dddaad2e24d9cacf1f6ba85e59c575ad31e419a7
[INFO] validating manifest of cesare/rust-upto-top on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cesare/rust-upto-top on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cesare/rust-upto-top
[INFO] finished frobbing cesare/rust-upto-top
[INFO] frobbed toml for cesare/rust-upto-top written to work/ex/clippy-test-run/sources/stable/gh/cesare/rust-upto-top/Cargo.toml
[INFO] started frobbing cesare/rust-upto-top
[INFO] finished frobbing cesare/rust-upto-top
[INFO] frobbed toml for cesare/rust-upto-top written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-upto-top/Cargo.toml
[INFO] crate cesare/rust-upto-top has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cesare/rust-upto-top against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cesare/rust-upto-top:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e42559f8b904a455880d7a2ce7510e5fb9f302bd325d6c75723b1d82bae847c9
[INFO] running `"docker" "start" "-a" "e42559f8b904a455880d7a2ce7510e5fb9f302bd325d6c75723b1d82bae847c9"`
[INFO] [stderr]     Checking upto_top v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/list_tops.rs:27:43
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let parent = target_path.parent().map(|path| PathBuf::from(path));
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     return target_path.is_dir();
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `target_path.is_dir()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 |                 visit(&dir).map(|path| println!("{}", path.display()));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |                 |
[INFO] [stderr]    |                 help: try this: `if let Some(path) = visit(&dir) { $ crate :: io :: _print ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     return target_path.is_dir();
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `target_path.is_dir()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 |                 visit(&dir).map(|path| println!("{}", path.display()));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |                 |
[INFO] [stderr]    |                 help: try this: `if let Some(path) = visit(&dir) { $ crate :: io :: _print ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/list_tops.rs:27:43
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let parent = target_path.parent().map(|path| PathBuf::from(path));
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.76s
[INFO] running `"docker" "inspect" "e42559f8b904a455880d7a2ce7510e5fb9f302bd325d6c75723b1d82bae847c9"`
[INFO] running `"docker" "rm" "-f" "e42559f8b904a455880d7a2ce7510e5fb9f302bd325d6c75723b1d82bae847c9"`
[INFO] [stdout] e42559f8b904a455880d7a2ce7510e5fb9f302bd325d6c75723b1d82bae847c9