[INFO] updating cached repository cesare/rust-list-ec2-instances [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cesare/rust-list-ec2-instances [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cesare/rust-list-ec2-instances" "work/ex/clippy-test-run/sources/stable/gh/cesare/rust-list-ec2-instances"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cesare/rust-list-ec2-instances'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cesare/rust-list-ec2-instances" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-list-ec2-instances"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-list-ec2-instances'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d108bc60553fd2046d4c98db1a0300a6dde2fdb2 [INFO] sha for GitHub repo cesare/rust-list-ec2-instances: d108bc60553fd2046d4c98db1a0300a6dde2fdb2 [INFO] validating manifest of cesare/rust-list-ec2-instances on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cesare/rust-list-ec2-instances on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cesare/rust-list-ec2-instances [INFO] finished frobbing cesare/rust-list-ec2-instances [INFO] frobbed toml for cesare/rust-list-ec2-instances written to work/ex/clippy-test-run/sources/stable/gh/cesare/rust-list-ec2-instances/Cargo.toml [INFO] started frobbing cesare/rust-list-ec2-instances [INFO] finished frobbing cesare/rust-list-ec2-instances [INFO] frobbed toml for cesare/rust-list-ec2-instances written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cesare/rust-list-ec2-instances/Cargo.toml [INFO] crate cesare/rust-list-ec2-instances has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cesare/rust-list-ec2-instances against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cesare/rust-list-ec2-instances:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98b2b32171b62584f291e7ea491bb7aee9bb1d7543660011d964d252eea87d39 [INFO] running `"docker" "start" "-a" "98b2b32171b62584f291e7ea491bb7aee9bb1d7543660011d964d252eea87d39"` [INFO] [stderr] Compiling cc v1.0.6 [INFO] [stderr] Checking serde v1.0.30 [INFO] [stderr] Checking dirs v1.0.3 [INFO] [stderr] Checking xml-rs v0.7.0 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking regex v0.2.8 [INFO] [stderr] Compiling rusoto_core v0.33.1 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking http v0.1.10 [INFO] [stderr] Compiling openssl-sys v0.9.27 [INFO] [stderr] Checking tokio-reactor v0.1.3 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.15 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking serde_json v1.0.11 [INFO] [stderr] Checking hyper v0.12.7 [INFO] [stderr] Checking hyper-tls v0.2.1 [INFO] [stderr] Checking rusoto_credential v0.12.0 [INFO] [stderr] Checking rusoto_ec2 v0.33.1 [INFO] [stderr] Checking list-ec2-instances v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/list_ec2_instances.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | fn show_instances(is: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Instance]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/list_ec2_instances.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | fn show_reservations(rs: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Reservation]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/list_ec2_instances.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | r.instances.as_ref().map(|is| show_instances(&is)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(is) = r.instances.as_ref() { show_instances(&is) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/list_ec2_instances.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | fn create_tag_name_filter(pattern: &String) -> Filter { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/list_ec2_instances.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | fn show_instances(is: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Instance]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/list_ec2_instances.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | fn show_reservations(rs: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Reservation]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/list_ec2_instances.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | r.instances.as_ref().map(|is| show_instances(&is)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(is) = r.instances.as_ref() { show_instances(&is) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/list_ec2_instances.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | fn create_tag_name_filter(pattern: &String) -> Filter { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 50s [INFO] running `"docker" "inspect" "98b2b32171b62584f291e7ea491bb7aee9bb1d7543660011d964d252eea87d39"` [INFO] running `"docker" "rm" "-f" "98b2b32171b62584f291e7ea491bb7aee9bb1d7543660011d964d252eea87d39"` [INFO] [stdout] 98b2b32171b62584f291e7ea491bb7aee9bb1d7543660011d964d252eea87d39