[INFO] updating cached repository cedrickcooke/litx
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cedrickcooke/litx
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cedrickcooke/litx" "work/ex/clippy-test-run/sources/stable/gh/cedrickcooke/litx"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cedrickcooke/litx'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cedrickcooke/litx" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cedrickcooke/litx"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cedrickcooke/litx'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 743c8f7db0b9983d5c30da66bb17c5893c303a25
[INFO] sha for GitHub repo cedrickcooke/litx: 743c8f7db0b9983d5c30da66bb17c5893c303a25
[INFO] validating manifest of cedrickcooke/litx on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cedrickcooke/litx on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cedrickcooke/litx
[INFO] finished frobbing cedrickcooke/litx
[INFO] frobbed toml for cedrickcooke/litx written to work/ex/clippy-test-run/sources/stable/gh/cedrickcooke/litx/Cargo.toml
[INFO] started frobbing cedrickcooke/litx
[INFO] finished frobbing cedrickcooke/litx
[INFO] frobbed toml for cedrickcooke/litx written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cedrickcooke/litx/Cargo.toml
[INFO] crate cedrickcooke/litx has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cedrickcooke/litx against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cedrickcooke/litx:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bc3ccbcaf7ada58dbe10e9387dd6a07e456807bf49916267f7e62698688a5dee
[INFO] running `"docker" "start" "-a" "bc3ccbcaf7ada58dbe10e9387dd6a07e456807bf49916267f7e62698688a5dee"`
[INFO] [stderr]     Checking litx v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lex/lexer.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             source_string: source_string,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_string`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lex/lexer.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             source_string: source_string,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_string`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lex/token.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             source_filename: source_filename,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_filename`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parse/production.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             ty: ty,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `ty`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lex/lexer.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             source_string: source_string,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_string`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lex/lexer.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             source_string: source_string,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_string`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lex/token.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             source_filename: source_filename,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_filename`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parse/production.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             ty: ty,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `ty`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `trivial_regex` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lex/lexer.rs:1:45
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(trivial_regex))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^ help: change it to: `clippy::trivial_regex`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `trivial_regex` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lex/lexer.rs:1:45
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(trivial_regex))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^ help: change it to: `clippy::trivial_regex`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `trivial_regex` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lex/lexer.rs:1:45
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(trivial_regex))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^ help: change it to: `clippy::trivial_regex`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/unslice.rs:39:17
[INFO] [stderr]    |
[INFO] [stderr] 39 |     const SRC: &'static str = "FOO BAR";
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `trivial_regex` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/lex/lexer.rs:1:45
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(trivial_regex))]
[INFO] [stderr]   |                                             ^^^^^^^^^^^^^ help: change it to: `clippy::trivial_regex`
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `spc`
[INFO] [stderr]   --> src/unslice.rs:48:19
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let (foo, spc, bar) = slice();
[INFO] [stderr]    |                   ^^^ help: consider using `_spc` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]   --> src/lex/token.rs:53:22
[INFO] [stderr]    |
[INFO] [stderr] 53 |     source_filename: Option<Option<&'b str>>,
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/unslice.rs:17:18
[INFO] [stderr]    |
[INFO] [stderr] 17 |         unsafe { self.as_ptr().offset(self.len() as isize) == next.as_ptr() }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(self.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/unslice.rs:28:18
[INFO] [stderr]    |
[INFO] [stderr] 28 |         unsafe { self.as_ptr().offset(self.len() as isize) == next.as_ptr() }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(self.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]   --> src/lex/token.rs:53:22
[INFO] [stderr]    |
[INFO] [stderr] 53 |     source_filename: Option<Option<&'b str>>,
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/unslice.rs:17:18
[INFO] [stderr]    |
[INFO] [stderr] 17 |         unsafe { self.as_ptr().offset(self.len() as isize) == next.as_ptr() }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(self.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/unslice.rs:28:18
[INFO] [stderr]    |
[INFO] [stderr] 28 |         unsafe { self.as_ptr().offset(self.len() as isize) == next.as_ptr() }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_ptr().add(self.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]   --> src/unslice.rs:48:14
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let (foo, spc, bar) = slice();
[INFO] [stderr]    |              ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> src/unslice.rs:48:24
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let (foo, spc, bar) = slice();
[INFO] [stderr]    |                        ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]   --> src/unslice.rs:54:14
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let (foo, spc, bar) = slice();
[INFO] [stderr]    |              ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> src/unslice.rs:54:24
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let (foo, spc, bar) = slice();
[INFO] [stderr]    |                        ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/main.rs:3:23
[INFO] [stderr]   |
[INFO] [stderr] 3 | const _MINIMAL_TEST: &'static str = r#"{}"#;
[INFO] [stderr]   |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/main.rs:5:22
[INFO] [stderr]   |
[INFO] [stderr] 5 | const _LITTLE_TEST: &'static str =
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/main.rs:15:19
[INFO] [stderr]    |
[INFO] [stderr] 15 | const _BIG_TEST: &'static str =
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/main.rs:3:23
[INFO] [stderr]   |
[INFO] [stderr] 3 | const _MINIMAL_TEST: &'static str = r#"{}"#;
[INFO] [stderr]   |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/main.rs:5:22
[INFO] [stderr]   |
[INFO] [stderr] 5 | const _LITTLE_TEST: &'static str =
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/main.rs:15:19
[INFO] [stderr]    |
[INFO] [stderr] 15 | const _BIG_TEST: &'static str =
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.92s
[INFO] running `"docker" "inspect" "bc3ccbcaf7ada58dbe10e9387dd6a07e456807bf49916267f7e62698688a5dee"`
[INFO] running `"docker" "rm" "-f" "bc3ccbcaf7ada58dbe10e9387dd6a07e456807bf49916267f7e62698688a5dee"`
[INFO] [stdout] bc3ccbcaf7ada58dbe10e9387dd6a07e456807bf49916267f7e62698688a5dee