[INFO] updating cached repository cdouglass/morse-practice
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cdouglass/morse-practice
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cdouglass/morse-practice" "work/ex/clippy-test-run/sources/stable/gh/cdouglass/morse-practice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cdouglass/morse-practice'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cdouglass/morse-practice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cdouglass/morse-practice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cdouglass/morse-practice'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1d9c32e9f1391fc62e7e773bde29064435efa732
[INFO] sha for GitHub repo cdouglass/morse-practice: 1d9c32e9f1391fc62e7e773bde29064435efa732
[INFO] validating manifest of cdouglass/morse-practice on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cdouglass/morse-practice on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cdouglass/morse-practice
[INFO] finished frobbing cdouglass/morse-practice
[INFO] frobbed toml for cdouglass/morse-practice written to work/ex/clippy-test-run/sources/stable/gh/cdouglass/morse-practice/Cargo.toml
[INFO] started frobbing cdouglass/morse-practice
[INFO] finished frobbing cdouglass/morse-practice
[INFO] frobbed toml for cdouglass/morse-practice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cdouglass/morse-practice/Cargo.toml
[INFO] crate cdouglass/morse-practice has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cdouglass/morse-practice against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cdouglass/morse-practice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ee6400972295aee385727dd4a6c867da44cdb0143f07889bb6df9920788c47bb
[INFO] running `"docker" "start" "-a" "ee6400972295aee385727dd4a6c867da44cdb0143f07889bb6df9920788c47bb"`
[INFO] [stderr]     Checking rand v0.4.2
[INFO] [stderr]     Checking docopt v0.8.3
[INFO] [stderr]     Checking morse v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encoding.rs:20:21
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Character { elements: elements, name: name, phonetic: Some(phonetic) }
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encoding.rs:20:41
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Character { elements: elements, name: name, phonetic: Some(phonetic) }
[INFO] [stderr]    |                                         ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/words.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             reservoir: reservoir,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reservoir`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encoding.rs:20:21
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Character { elements: elements, name: name, phonetic: Some(phonetic) }
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/encoding.rs:20:41
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Character { elements: elements, name: name, phonetic: Some(phonetic) }
[INFO] [stderr]    |                                         ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/words.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             reservoir: reservoir,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reservoir`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:20:15
[INFO] [stderr]    |
[INFO] [stderr] 20 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:20:15
[INFO] [stderr]    |
[INFO] [stderr] 20 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/audio.rs:29:23
[INFO] [stderr]    |
[INFO] [stderr] 29 | pub fn play(elements: &Vec<Element>, pitch: u32, dot_length: u32) -> Command {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^ help: change this to: `&[Element]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/encoding.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     char_map().keys().map(|c| *c).filter(|c| c != &' ').collect()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `char_map().keys().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/encoding.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     words.chars().into_iter()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `words.chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/words.rs:32:17
[INFO] [stderr]    |
[INFO] [stderr] 32 |                 self.rng.choose(&d).map(|s| s.clone())
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.rng.choose(&d).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/words.rs:65:49
[INFO] [stderr]    |
[INFO] [stderr] 65 |         text_file.read_to_string(&mut contents).expect(&format!("Couldn't read file {}", filename));
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't read file {}", filename))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:74:18
[INFO] [stderr]    |
[INFO] [stderr] 74 | fn quiz(message: &Vec<String>, stdin: &std::io::Stdin, pitch: u32, dot_length: u32) -> usize {
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         correct_word.chars().into_iter().map(|_| "_").collect::<Vec<&str>>().join("")
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `correct_word.chars()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/audio.rs:29:23
[INFO] [stderr]    |
[INFO] [stderr] 29 | pub fn play(elements: &Vec<Element>, pitch: u32, dot_length: u32) -> Command {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^ help: change this to: `&[Element]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/encoding.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     char_map().keys().map(|c| *c).filter(|c| c != &' ').collect()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `char_map().keys().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/encoding.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     words.chars().into_iter()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `words.chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/words.rs:32:17
[INFO] [stderr]    |
[INFO] [stderr] 32 |                 self.rng.choose(&d).map(|s| s.clone())
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.rng.choose(&d).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/words.rs:65:49
[INFO] [stderr]    |
[INFO] [stderr] 65 |         text_file.read_to_string(&mut contents).expect(&format!("Couldn't read file {}", filename));
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't read file {}", filename))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:74:18
[INFO] [stderr]    |
[INFO] [stderr] 74 | fn quiz(message: &Vec<String>, stdin: &std::io::Stdin, pitch: u32, dot_length: u32) -> usize {
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         correct_word.chars().into_iter().map(|_| "_").collect::<Vec<&str>>().join("")
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `correct_word.chars()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.95s
[INFO] running `"docker" "inspect" "ee6400972295aee385727dd4a6c867da44cdb0143f07889bb6df9920788c47bb"`
[INFO] running `"docker" "rm" "-f" "ee6400972295aee385727dd4a6c867da44cdb0143f07889bb6df9920788c47bb"`
[INFO] [stdout] ee6400972295aee385727dd4a6c867da44cdb0143f07889bb6df9920788c47bb