[INFO] updating cached repository cdbfoster/cryptrack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cdbfoster/cryptrack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cdbfoster/cryptrack" "work/ex/clippy-test-run/sources/stable/gh/cdbfoster/cryptrack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cdbfoster/cryptrack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cdbfoster/cryptrack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cdbfoster/cryptrack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cdbfoster/cryptrack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b730e9030e5fa97e275e6e923dc2d463a5836716 [INFO] sha for GitHub repo cdbfoster/cryptrack: b730e9030e5fa97e275e6e923dc2d463a5836716 [INFO] validating manifest of cdbfoster/cryptrack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cdbfoster/cryptrack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cdbfoster/cryptrack [INFO] finished frobbing cdbfoster/cryptrack [INFO] frobbed toml for cdbfoster/cryptrack written to work/ex/clippy-test-run/sources/stable/gh/cdbfoster/cryptrack/Cargo.toml [INFO] started frobbing cdbfoster/cryptrack [INFO] finished frobbing cdbfoster/cryptrack [INFO] frobbed toml for cdbfoster/cryptrack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cdbfoster/cryptrack/Cargo.toml [INFO] crate cdbfoster/cryptrack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cdbfoster/cryptrack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cdbfoster/cryptrack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bdec50adb0ed89b4be080c007f163bf0bb815fa7986e9645a40bba29105bfdad [INFO] running `"docker" "start" "-a" "bdec50adb0ed89b4be080c007f163bf0bb815fa7986e9645a40bba29105bfdad"` [INFO] [stderr] Compiling openssl v0.9.22 [INFO] [stderr] Compiling openssl-sys v0.9.22 [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking ctrlc v3.0.3 [INFO] [stderr] Checking ws v0.7.3 [INFO] [stderr] Checking cryptrack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:50:49 [INFO] [stderr] | [INFO] [stderr] 50 | let _ = write!( [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 51 | | trade_file.lock().unwrap(), [INFO] [stderr] 52 | | "{} {} {} {}\n", [INFO] [stderr] 53 | | object["timestampms"], [INFO] [stderr] ... | [INFO] [stderr] 60 | | }, [INFO] [stderr] 61 | | ); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | trade_file: trade_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trade_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:50:49 [INFO] [stderr] | [INFO] [stderr] 50 | let _ = write!( [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 51 | | trade_file.lock().unwrap(), [INFO] [stderr] 52 | | "{} {} {} {}\n", [INFO] [stderr] 53 | | object["timestampms"], [INFO] [stderr] ... | [INFO] [stderr] 60 | | }, [INFO] [stderr] 61 | | ); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | trade_file: trade_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trade_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | const LOG_PATH_PREFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | const LOG_PATH_PREFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.55s [INFO] running `"docker" "inspect" "bdec50adb0ed89b4be080c007f163bf0bb815fa7986e9645a40bba29105bfdad"` [INFO] running `"docker" "rm" "-f" "bdec50adb0ed89b4be080c007f163bf0bb815fa7986e9645a40bba29105bfdad"` [INFO] [stdout] bdec50adb0ed89b4be080c007f163bf0bb815fa7986e9645a40bba29105bfdad